Skip to content

Commit 262be13

Browse files
committed
Use f{32,64}::to_bits for is_zero test in vec::SpecFromElem
vec::SpecFromElem provides an optimization to use calloc to fill a Vec when the element given to fill the Vec is represented by 0. For floats, the test for that currently used is `x == 0. && x.is_sign_positive()`. When compiled in a standalone function, rustc generates the following assembly: ``` xorps xmm1, xmm1 ucomisd xmm0, xmm1 setnp al sete cl and cl, al movq rax, xmm0 test rax, rax setns al and al, cl ret ``` A simpler test telling us whether the value is represented by 0, is `x.to_bits() == 0`, which rustc compiles to: ``` movq rax, xmm0 test rax, rax sete al ret ``` Not that the test is hot in any way, but it also makes it clearer what the intent in the rust code is.
1 parent e5277c1 commit 262be13

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/liballoc/vec.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1574,8 +1574,8 @@ impl_spec_from_elem!(u64, |x| x == 0);
15741574
impl_spec_from_elem!(u128, |x| x == 0);
15751575
impl_spec_from_elem!(usize, |x| x == 0);
15761576

1577-
impl_spec_from_elem!(f32, |x: f32| x == 0. && x.is_sign_positive());
1578-
impl_spec_from_elem!(f64, |x: f64| x == 0. && x.is_sign_positive());
1577+
impl_spec_from_elem!(f32, |x: f32| x.to_bits() == 0);
1578+
impl_spec_from_elem!(f64, |x: f64| x.to_bits() == 0);
15791579

15801580
////////////////////////////////////////////////////////////////////////////////
15811581
// Common trait implementations for Vec

0 commit comments

Comments
 (0)