Skip to content

Commit 249f017

Browse files
committed
rt: Add FIXME's about future changes to LLVM's __morestack impl
1 parent 6da1a3f commit 249f017

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

src/rt/arch/i386/morestack.S

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
#define MORESTACK __morestack
2020
#endif
2121

22+
// FIXME: Future LLVM patches remove these 8 alignment bytes from
23+
// the function prologue in order to match gcc's behavior
2224
#define ALIGNMENT 8
2325
#define RETURN_OFFSET 7
2426

src/rt/rust_task.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -588,6 +588,9 @@ rust_task::del_stack() {
588588

589589
void
590590
rust_task::record_stack_limit() {
591+
// FIXME: Future LLVM patches expect us to add an additional 256 bytes
592+
// here so that, if the frame size is < 256 it can generate the
593+
// comparison against esp directly, instead of some offset from esp
591594
record_sp(stk->data + RED_ZONE_SIZE);
592595
}
593596
//

0 commit comments

Comments
 (0)