Fix invalid private types in public APIs

Author: GuillaumeGomez

library/core/src/error.rs

@@ -7,6 +7,9 @@ mod tests;
 use crate::any::{Demand, Provider, TypeId};
 use crate::fmt::{Debug, Display};
 
+#[doc(hidden)]
+pub use private::Internal;
+
 /// `Error` is a trait representing the basic expectations for error values,
 /// i.e., values of type `E` in [`Result<T, E>`].
 ///
@@ -205,8 +208,8 @@ where
 }
 
 mod private {
-    // This is a hack to prevent `type_id` from being overridden by `Error`
-    // implementations, since that can enable unsound downcasting.
+    /// This is a hack to prevent `type_id` from being overridden by `Error`
+    /// implementations, since that can enable unsound downcasting.
     #[unstable(feature = "error_type_id", issue = "60784")]
     #[derive(Debug)]
     pub struct Internal;

library/core/src/iter/mod.rs

@@ -390,6 +390,13 @@ pub use self::range::Step;
     reason = "generators are unstable"
 )]
 pub use self::sources::from_generator;
+#[unstable(
+    feature = "iter_from_generator",
+    issue = "43122",
+    reason = "generators are unstable"
+)]
+#[doc(hidden)]
+pub use self::sources::FromGenerator;
 #[stable(feature = "iter_empty", since = "1.2.0")]
 pub use self::sources::{empty, Empty};
 #[stable(feature = "iter_from_fn", since = "1.34.0")]

library/core/src/iter/sources.rs

@@ -32,6 +32,13 @@ pub use self::from_fn::{from_fn, FromFn};
     reason = "generators are unstable"
 )]
 pub use self::from_generator::from_generator;
+#[unstable(
+    feature = "iter_from_generator",
+    issue = "43122",
+    reason = "generators are unstable"
+)]
+#[doc(hidden)]
+pub use self::from_generator::FromGenerator;
 
 #[stable(feature = "iter_successors", since = "1.34.0")]
 pub use self::successors::{successors, Successors};

library/core/src/num/dec2flt/lemire.rs

@@ -1,6 +1,7 @@
 //! Implementation of the Eisel-Lemire algorithm.
 
-use crate::num::dec2flt::common::BiasedFp;
+#[doc(hidden)]
+pub use crate::num::dec2flt::common::BiasedFp;
 use crate::num::dec2flt::float::RawFloat;
 use crate::num::dec2flt::table::{
     LARGEST_POWER_OF_FIVE, POWER_OF_FIVE_128, SMALLEST_POWER_OF_FIVE,

library/core/src/str/lossy.rs

@@ -69,6 +69,7 @@ impl<'a> Utf8Chunk<'a> {
     }
 }
 
+/// Utility struct for debug printing `Utf8Chunks`.
 #[must_use]
 #[unstable(feature = "str_internals", issue = "none")]
 pub struct Debug<'a>(&'a [u8]);

library/core/src/str/mod.rs

@@ -24,6 +24,9 @@ pub mod pattern;
 
 mod lossy;
 #[unstable(feature = "utf8_chunks", issue = "99543")]
+#[doc(hidden)]
+pub use lossy::Debug;
+#[unstable(feature = "utf8_chunks", issue = "99543")]
 pub use lossy::{Utf8Chunk, Utf8Chunks};
 
 #[stable(feature = "rust1", since = "1.0.0")]

library/portable-simd/crates/core_simd/src/masks.rs

@@ -107,6 +107,17 @@ where
     }
 }
 
+#[cfg(not(all(target_arch = "x86_64", target_feature = "avx512f")))]
+impl<T, const LANES: usize> core::convert::From<Mask<T, LANES>> for Simd<T, LANES>
+where
+    T: MaskElement,
+    LaneCount<LANES>: SupportedLaneCount,
+{
+    fn from(value: Mask<T, LANES>) -> Self {
+        value.0.0
+    }
+}
+
 impl<T, const LANES: usize> Mask<T, LANES>
 where
     T: MaskElement,

library/portable-simd/crates/core_simd/src/masks/full_masks.rs

@@ -8,7 +8,7 @@ use crate::simd::{LaneCount, Simd, SupportedLaneCount, ToBitMask};
 use crate::simd::ToBitMaskArray;
 
 #[repr(transparent)]
-pub struct Mask<T, const LANES: usize>(Simd<T, LANES>)
+pub struct Mask<T, const LANES: usize>(pub(super) Simd<T, LANES>)
 where
     T: MaskElement,
     LaneCount<LANES>: SupportedLaneCount;
@@ -257,16 +257,6 @@ where
     }
 }
 
-impl<T, const LANES: usize> core::convert::From<Mask<T, LANES>> for Simd<T, LANES>
-where
-    T: MaskElement,
-    LaneCount<LANES>: SupportedLaneCount,
-{
-    fn from(value: Mask<T, LANES>) -> Self {
-        value.0
-    }
-}
-
 impl<T, const LANES: usize> core::ops::BitAnd for Mask<T, LANES>
 where
     T: MaskElement,

library/proc_macro/src/bridge/mod.rs

@@ -155,7 +155,8 @@ pub mod server;
 #[allow(unsafe_code)]
 mod symbol;
 
-use buffer::Buffer;
+#[doc(hidden)]
+pub use buffer::Buffer;
 pub use rpc::PanicMessage;
 use rpc::{Decode, DecodeMut, Encode, Reader, Writer};
 

library/proc_macro/src/lib.rs

@@ -40,6 +40,9 @@ pub mod bridge;
 
 mod diagnostic;
 
+#[unstable(feature = "proc_macro_diagnostic", issue = "54140")]
+#[doc(hidden)]
+pub use diagnostic::Children;
 #[unstable(feature = "proc_macro_diagnostic", issue = "54140")]
 pub use diagnostic::{Diagnostic, Level, MultiSpan};
 

library/test/src/lib.rs

@@ -26,6 +26,7 @@
 // Public reexports
 pub use self::bench::{black_box, Bencher};
 pub use self::console::run_tests_console;
+pub use self::event::{CompletedTest, TestEvent};
 pub use self::options::{ColorConfig, Options, OutputFormat, RunIgnored, ShouldPanic};
 pub use self::types::TestName::*;
 pub use self::types::*;
@@ -43,7 +44,7 @@ pub mod test {
         options::{Options, RunIgnored, RunStrategy, ShouldPanic},
         run_test, test_main, test_main_static,
         test_result::{TestResult, TrFailed, TrFailedMsg, TrIgnored, TrOk},
-        time::{TestExecTime, TestTimeOptions},
+        time::{TestExecTime, TestTimeOptions, TimeThreshold},
         types::{
             DynTestFn, DynTestName, StaticBenchFn, StaticTestFn, StaticTestName, TestDesc,
             TestDescAndFn, TestId, TestName, TestType,
@@ -81,7 +82,6 @@ mod types;
 mod tests;
 
 use core::any::Any;
-use event::{CompletedTest, TestEvent};
 use helpers::concurrency::get_concurrency;
 use helpers::exit_code::get_exit_code;
 use helpers::shuffle::{get_shuffle_seed, shuffle_tests};