Skip to content

Commit 1eba1b5

Browse files
committed
rustdoc: rip out all the gui tests for <100% width mobile sidebar
stuff like "clicking the settings menu closes the mobile sidebar" is now impossible for users to observe, since the mobile sidebar will always cover the settings menu due to being full-width, which is good because that behavior is also now impossible for our testing framework to observe.
1 parent 5326fc9 commit 1eba1b5

File tree

3 files changed

+5
-19
lines changed

3 files changed

+5
-19
lines changed

tests/rustdoc-gui/notable-trait.goml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -244,10 +244,6 @@ click: ".sidebar-menu-toggle"
244244
assert: "//*[@class='sidebar shown']"
245245
assert-count: ("//*[@class='tooltip popover']", 0)
246246
assert-false: "#method\.create_an_iterator_from_read .tooltip:focus"
247-
// Clicking a notable trait tooltip popover should close the sidebar.
248-
click: "//*[@id='method.create_an_iterator_from_read']//*[@class='tooltip']"
249-
assert-count: ("//*[@class='tooltip popover']", 1)
250-
assert-false: "//*[@class='sidebar shown']"
251247

252248
// Also check the focus handling for the settings button.
253249
set-window-size: (1100, 600)

tests/rustdoc-gui/pocket-menu.goml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -68,16 +68,3 @@ assert-css: ("#settings-menu .popover", {"display": "block"})
6868
click: ".sidebar-menu-toggle"
6969
assert: "//*[@class='sidebar shown']"
7070
assert-css: ("#settings-menu .popover", {"display": "none"})
71-
// Opening the settings popover should close the sidebar.
72-
click: "#settings-menu a"
73-
assert-css: ("#settings-menu .popover", {"display": "block"})
74-
assert-false: "//*[@class='sidebar shown']"
75-
76-
// Opening the settings popover at start (which async loads stuff) should also close.
77-
reload:
78-
click: ".sidebar-menu-toggle"
79-
assert: "//*[@class='sidebar shown']"
80-
assert-false: "#settings-menu .popover"
81-
click: "#settings-menu a"
82-
assert-false: "//*[@class='sidebar shown']"
83-
wait-for: "#settings-menu .popover"

tests/rustdoc-gui/sidebar-mobile.goml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ assert-css: (
3232
{"display": "block"}
3333
)
3434

35-
// Click elsewhere.
36-
click: "body"
35+
// Click the toggle to close it
36+
click: ".sidebar-menu-toggle"
3737
assert-css: (".sidebar", {"display": "block", "left": "-1000px"})
3838

3939
// Open the sidebar menu, and make sure pressing Escape closes it.
@@ -57,6 +57,7 @@ scroll-to: ".block.keyword li:nth-child(1)"
5757
compare-elements-position-near: (".block.keyword li:nth-child(1)", ".mobile-topbar", {"y": 544})
5858

5959
// Now checking the background color of the sidebar.
60+
reload:
6061
show-text: true
6162

6263
define-function: (
@@ -72,6 +73,8 @@ define-function: (
7273
"background-color": |background|,
7374
"color": |color|,
7475
})
76+
// Close the sidebar menu.
77+
press-key: "Escape"
7578
},
7679
)
7780

0 commit comments

Comments
 (0)