Make Target::name method pass by copy

hdelc · hdelc · commit 1e8abe7da2ea · 2022-08-02T16:30:09.000-04:00
diff --git a/compiler/rustc_hir/src/target.rs b/compiler/rustc_hir/src/target.rs
@@ -60,7 +60,7 @@ pub enum Target {
 
 impl Display for Target {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        write!(f, "{}", Self::name(&self))
+        write!(f, "{}", Self::name(*self))
     }
 }
 
@@ -142,8 +142,8 @@ impl Target {
         }
     }
 
-    pub fn name(&self) -> &str {
-        match *self {
+    pub fn name(self) -> &'static str {
+        match self {
             Target::ExternCrate => "extern crate",
             Target::Use => "use",
             Target::Static => "static item",

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ pub enum Target {`
`60`	`60`
`61`	`61`	`impl Display for Target {`
`62`	`62`	`fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {`
`63`		`- write!(f, "{}", Self::name(&self))`
	`63`	`+ write!(f, "{}", Self::name(*self))`
`64`	`64`	`}`
`65`	`65`	`}`
`66`	`66`
`@@ -142,8 +142,8 @@ impl Target {`
`142`	`142`	`}`
`143`	`143`	`}`
`144`	`144`
`145`		`- pub fn name(&self) -> &str {`
`146`		`- match *self {`
	`145`	`+ pub fn name(self) -> &'static str {`
	`146`	`+ match self {`
`147`	`147`	`Target::ExternCrate => "extern crate",`
`148`	`148`	`Target::Use => "use",`
`149`	`149`	`Target::Static => "static item",`