Point to the value instead of the TAIT declaration for obligation failures

oli-obk · oli-obk · commit 092e9ccd8aaf · 2021-08-06T10:42:05.000Z
diff --git a/compiler/rustc_trait_selection/src/opaque_types.rs b/compiler/rustc_trait_selection/src/opaque_types.rs
@@ -965,10 +965,10 @@ impl<'a, 'tcx> Instantiator<'a, 'tcx> {
             debug!("instantiate_opaque_types: returning concrete ty {:?}", opaque_defn.concrete_ty);
             return opaque_defn.concrete_ty;
         }
-        let span = tcx.def_span(def_id);
-        debug!("fold_opaque_ty {:?} {:?}", self.value_span, span);
-        let ty_var = infcx
-            .next_ty_var(TypeVariableOrigin { kind: TypeVariableOriginKind::TypeInference, span });
+        let ty_var = infcx.next_ty_var(TypeVariableOrigin {
+            kind: TypeVariableOriginKind::TypeInference,
+            span: self.value_span,
+        });
 
         // Make sure that we are in fact defining the *entire* type
         // (e.g., `type Foo<T: Bound> = impl Bar;` needs to be
@@ -993,16 +993,12 @@ impl<'a, 'tcx> Instantiator<'a, 'tcx> {
         }
 
         debug!("instantiate_opaque_types: ty_var={:?}", ty_var);
-        self.compute_opaque_type_obligations(opaque_type_key, span);
+        self.compute_opaque_type_obligations(opaque_type_key);
 
         ty_var
     }
 
-    fn compute_opaque_type_obligations(
-        &mut self,
-        opaque_type_key: OpaqueTypeKey<'tcx>,
-        span: Span,
-    ) {
+    fn compute_opaque_type_obligations(&mut self, opaque_type_key: OpaqueTypeKey<'tcx>) {
         let infcx = self.infcx;
         let tcx = infcx.tcx;
         let OpaqueTypeKey { def_id, substs } = opaque_type_key;
@@ -1014,7 +1010,7 @@ impl<'a, 'tcx> Instantiator<'a, 'tcx> {
 
         let param_env = tcx.param_env(def_id);
         let InferOk { value: bounds, obligations } = infcx.partially_normalize_associated_types_in(
-            ObligationCause::misc(span, self.body_id),
+            ObligationCause::misc(self.value_span, self.body_id),
             param_env,
             bounds,
         );
@@ -1038,7 +1034,8 @@ impl<'a, 'tcx> Instantiator<'a, 'tcx> {
             // This also instantiates nested instances of `impl Trait`.
             let predicate = self.instantiate_opaque_types_in_map(predicate);
 
-            let cause = traits::ObligationCause::new(span, self.body_id, traits::OpaqueType);
+            let cause =
+                traits::ObligationCause::new(self.value_span, self.body_id, traits::OpaqueType);
 
             // Require that the predicate holds for the concrete type.
             debug!("instantiate_opaque_types: predicate={:?}", predicate);
diff --git a/src/test/ui/associated-type-bounds/assoc-type-eq-with-dyn-atb-fail.rs b/src/test/ui/associated-type-bounds/assoc-type-eq-with-dyn-atb-fail.rs
@@ -28,9 +28,9 @@ impl Bar for AssocNoCopy {
 
 impl Thing for AssocNoCopy {
     type Out = Box<dyn Bar<Assoc: Copy>>;
-    //~^ ERROR the trait bound `String: Copy` is not satisfied
 
     fn func() -> Self::Out {
+        //~^ ERROR the trait bound `String: Copy` is not satisfied
         Box::new(AssocNoCopy)
     }
 }
diff --git a/src/test/ui/associated-type-bounds/assoc-type-eq-with-dyn-atb-fail.stderr b/src/test/ui/associated-type-bounds/assoc-type-eq-with-dyn-atb-fail.stderr
@@ -1,8 +1,8 @@
 error[E0277]: the trait bound `String: Copy` is not satisfied
-  --> $DIR/assoc-type-eq-with-dyn-atb-fail.rs:30:28
+  --> $DIR/assoc-type-eq-with-dyn-atb-fail.rs:32:18
    |
-LL |     type Out = Box<dyn Bar<Assoc: Copy>>;
-   |                            ^^^^^^^^^^^ the trait `Copy` is not implemented for `String`
+LL |     fn func() -> Self::Out {
+   |                  ^^^^^^^^^ the trait `Copy` is not implemented for `String`
 
 error: aborting due to previous error
 
diff --git a/src/test/ui/impl-trait/issue-55872-1.rs b/src/test/ui/impl-trait/issue-55872-1.rs
@@ -8,12 +8,12 @@ pub trait Bar {
 
 impl<S: Default> Bar for S {
     type E = impl Copy;
-    //~^ ERROR the trait bound `S: Copy` is not satisfied in `(S, T)` [E0277]
-    //~^^ ERROR the trait bound `T: Copy` is not satisfied in `(S, T)` [E0277]
 
     fn foo<T: Default>() -> Self::E {
         //~^ ERROR type parameter `T` is part of concrete type but not used in parameter list for the `impl Trait` type alias
         //~| ERROR impl has stricter requirements than trait
+        //~| ERROR the trait bound `S: Copy` is not satisfied in `(S, T)` [E0277]
+        //~| ERROR the trait bound `T: Copy` is not satisfied in `(S, T)` [E0277]
         (S::default(), T::default())
     }
 }
diff --git a/src/test/ui/impl-trait/issue-55872-1.stderr b/src/test/ui/impl-trait/issue-55872-1.stderr
@@ -1,5 +1,5 @@
 error[E0276]: impl has stricter requirements than trait
-  --> $DIR/issue-55872-1.rs:14:5
+  --> $DIR/issue-55872-1.rs:12:5
    |
 LL |     fn foo<T>() -> Self::E;
    |     ----------------------- definition of `foo` from trait
@@ -8,10 +8,10 @@ LL |     fn foo<T: Default>() -> Self::E {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ impl has extra requirement `T: Default`
 
 error[E0277]: the trait bound `S: Copy` is not satisfied in `(S, T)`
-  --> $DIR/issue-55872-1.rs:10:14
+  --> $DIR/issue-55872-1.rs:12:29
    |
-LL |     type E = impl Copy;
-   |              ^^^^^^^^^ within `(S, T)`, the trait `Copy` is not implemented for `S`
+LL |     fn foo<T: Default>() -> Self::E {
+   |                             ^^^^^^^ within `(S, T)`, the trait `Copy` is not implemented for `S`
    |
    = note: required because it appears within the type `(S, T)`
 help: consider further restricting this bound
@@ -20,10 +20,10 @@ LL | impl<S: Default + std::marker::Copy> Bar for S {
    |                 ^^^^^^^^^^^^^^^^^^^
 
 error[E0277]: the trait bound `T: Copy` is not satisfied in `(S, T)`
-  --> $DIR/issue-55872-1.rs:10:14
+  --> $DIR/issue-55872-1.rs:12:29
    |
-LL |     type E = impl Copy;
-   |              ^^^^^^^^^ within `(S, T)`, the trait `Copy` is not implemented for `T`
+LL |     fn foo<T: Default>() -> Self::E {
+   |                             ^^^^^^^ within `(S, T)`, the trait `Copy` is not implemented for `T`
    |
    = note: required because it appears within the type `(S, T)`
 help: consider further restricting this bound
@@ -32,12 +32,14 @@ LL |     fn foo<T: Default + std::marker::Copy>() -> Self::E {
    |                       ^^^^^^^^^^^^^^^^^^^
 
 error: type parameter `T` is part of concrete type but not used in parameter list for the `impl Trait` type alias
-  --> $DIR/issue-55872-1.rs:14:37
+  --> $DIR/issue-55872-1.rs:12:37
    |
 LL |       fn foo<T: Default>() -> Self::E {
    |  _____________________________________^
 LL | |
 LL | |
+LL | |
+LL | |
 LL | |         (S::default(), T::default())
 LL | |     }
    | |_____^
diff --git a/src/test/ui/impl-trait/issue-55872-2.rs b/src/test/ui/impl-trait/issue-55872-2.rs
@@ -11,9 +11,9 @@ pub trait Bar {
 
 impl<S> Bar for S {
     type E = impl std::marker::Copy;
-    //~^ ERROR the trait bound `impl Future: Copy` is not satisfied [E0277]
     fn foo<T>() -> Self::E {
         //~^ ERROR type parameter `T` is part of concrete type but not used in parameter list for the `impl Trait` type alias
+        //~| ERROR the trait bound `impl Future: Copy` is not satisfied [E0277]
         async {}
     }
 }
diff --git a/src/test/ui/impl-trait/issue-55872-2.stderr b/src/test/ui/impl-trait/issue-55872-2.stderr
@@ -1,15 +1,16 @@
 error[E0277]: the trait bound `impl Future: Copy` is not satisfied
-  --> $DIR/issue-55872-2.rs:13:14
+  --> $DIR/issue-55872-2.rs:14:20
    |
-LL |     type E = impl std::marker::Copy;
-   |              ^^^^^^^^^^^^^^^^^^^^^^ the trait `Copy` is not implemented for `impl Future`
+LL |     fn foo<T>() -> Self::E {
+   |                    ^^^^^^^ the trait `Copy` is not implemented for `impl Future`
 
 error: type parameter `T` is part of concrete type but not used in parameter list for the `impl Trait` type alias
-  --> $DIR/issue-55872-2.rs:15:28
+  --> $DIR/issue-55872-2.rs:14:28
    |
 LL |       fn foo<T>() -> Self::E {
    |  ____________________________^
 LL | |
+LL | |
 LL | |         async {}
 LL | |     }
    | |_____^
diff --git a/src/test/ui/type-alias-impl-trait/generic_type_does_not_live_long_enough.rs b/src/test/ui/type-alias-impl-trait/generic_type_does_not_live_long_enough.rs
@@ -7,9 +7,9 @@ fn main() {
 }
 
 type WrongGeneric<T> = impl 'static;
-//~^ ERROR the parameter type `T` may not live long enough
-//~| ERROR: at least one trait must be specified
+//~^ ERROR: at least one trait must be specified
 
 fn wrong_generic<T>(t: T) -> WrongGeneric<T> {
+    //~^ ERROR the parameter type `T` may not live long enough
     t
 }
diff --git a/src/test/ui/type-alias-impl-trait/generic_type_does_not_live_long_enough.stderr b/src/test/ui/type-alias-impl-trait/generic_type_does_not_live_long_enough.stderr
@@ -19,13 +19,12 @@ LL | type WrongGeneric<T> = impl 'static;
            found opaque type `impl Sized`
 
 error[E0310]: the parameter type `T` may not live long enough
-  --> $DIR/generic_type_does_not_live_long_enough.rs:9:24
+  --> $DIR/generic_type_does_not_live_long_enough.rs:12:30
    |
-LL | type WrongGeneric<T> = impl 'static;
-   |                        ^^^^^^^^^^^^ ...so that the type `T` will meet its required lifetime bounds
-...
 LL | fn wrong_generic<T>(t: T) -> WrongGeneric<T> {
-   |                  - help: consider adding an explicit lifetime bound...: `T: 'static`
+   |                  -           ^^^^^^^^^^^^^^^ ...so that the type `T` will meet its required lifetime bounds
+   |                  |
+   |                  help: consider adding an explicit lifetime bound...: `T: 'static`
 
 error: aborting due to 3 previous errors
 
diff --git a/src/test/ui/type-alias-impl-trait/issue-57611-trait-alias.rs b/src/test/ui/type-alias-impl-trait/issue-57611-trait-alias.rs
@@ -15,9 +15,9 @@ struct X;
 
 impl Foo for X {
     type Bar = impl Baz<Self, Self>;
-    //~^ ERROR implementation of `FnOnce` is not general enough
 
     fn bar(&self) -> Self::Bar {
+        //~^ ERROR implementation of `FnOnce` is not general enough
         |x| x
     }
 }
diff --git a/src/test/ui/type-alias-impl-trait/issue-57611-trait-alias.stderr b/src/test/ui/type-alias-impl-trait/issue-57611-trait-alias.stderr
@@ -1,8 +1,8 @@
 error: implementation of `FnOnce` is not general enough
-  --> $DIR/issue-57611-trait-alias.rs:17:16
+  --> $DIR/issue-57611-trait-alias.rs:19:22
    |
-LL |     type Bar = impl Baz<Self, Self>;
-   |                ^^^^^^^^^^^^^^^^^^^^ implementation of `FnOnce` is not general enough
+LL |     fn bar(&self) -> Self::Bar {
+   |                      ^^^^^^^^^ implementation of `FnOnce` is not general enough
    |
    = note: closure with signature `fn(&'2 X) -> &X` must implement `FnOnce<(&'1 X,)>`, for any lifetime `'1`...
    = note: ...but it actually implements `FnOnce<(&'2 X,)>`, for some specific lifetime `'2`
diff --git a/src/test/ui/type-alias-impl-trait/issue-60371.rs b/src/test/ui/type-alias-impl-trait/issue-60371.rs
@@ -8,9 +8,9 @@ trait Bug {
 
 impl Bug for &() {
     type Item = impl Bug; //~ ERROR `impl Trait` in type aliases is unstable
-    //~^ ERROR the trait bound `(): Bug` is not satisfied
 
     const FUN: fn() -> Self::Item = || ();
+    //~^ ERROR the trait bound `(): Bug` is not satisfied
 }
 
 fn main() {}
diff --git a/src/test/ui/type-alias-impl-trait/issue-60371.stderr b/src/test/ui/type-alias-impl-trait/issue-60371.stderr
@@ -8,10 +8,10 @@ LL |     type Item = impl Bug;
    = help: add `#![feature(type_alias_impl_trait)]` to the crate attributes to enable
 
 error[E0277]: the trait bound `(): Bug` is not satisfied
-  --> $DIR/issue-60371.rs:10:17
+  --> $DIR/issue-60371.rs:12:40
    |
-LL |     type Item = impl Bug;
-   |                 ^^^^^^^^ the trait `Bug` is not implemented for `()`
+LL |     const FUN: fn() -> Self::Item = || ();
+   |                                        ^ the trait `Bug` is not implemented for `()`
    |
    = help: the following implementations were found:
              <&() as Bug>
diff --git a/src/test/ui/type-alias-impl-trait/multiple-def-uses-in-one-fn.rs b/src/test/ui/type-alias-impl-trait/multiple-def-uses-in-one-fn.rs
@@ -5,9 +5,9 @@
 #![feature(type_alias_impl_trait)]
 
 type X<A, B> = impl Into<&'static A>;
-//~^ ERROR the trait bound `&'static B: From<&A>` is not satisfied
 
 fn f<A, B: 'static>(a: &'static A, b: B) -> (X<A, B>, X<B, A>) {
+    //~^ ERROR the trait bound `&'static B: From<&A>` is not satisfied
     (a, a)
 }
 
diff --git a/src/test/ui/type-alias-impl-trait/multiple-def-uses-in-one-fn.stderr b/src/test/ui/type-alias-impl-trait/multiple-def-uses-in-one-fn.stderr
@@ -1,8 +1,8 @@
 error[E0277]: the trait bound `&'static B: From<&A>` is not satisfied
-  --> $DIR/multiple-def-uses-in-one-fn.rs:7:16
+  --> $DIR/multiple-def-uses-in-one-fn.rs:9:45
    |
-LL | type X<A, B> = impl Into<&'static A>;
-   |                ^^^^^^^^^^^^^^^^^^^^^ the trait `From<&A>` is not implemented for `&'static B`
+LL | fn f<A, B: 'static>(a: &'static A, b: B) -> (X<A, B>, X<B, A>) {
+   |                                             ^^^^^^^^^^^^^^^^^^ the trait `From<&A>` is not implemented for `&'static B`
    |
    = note: required because of the requirements on the impl of `Into<&'static B>` for `&A`
 help: consider introducing a `where` bound, but there might be an alternative better way to express this requirement

Original file line number	Diff line number	Diff line change
`@@ -28,9 +28,9 @@ impl Bar for AssocNoCopy {`
`28`	`28`
`29`	`29`	`impl Thing for AssocNoCopy {`
`30`	`30`	`type Out = Box<dyn Bar<Assoc: Copy>>;`
`31`		- //~^ ERROR the trait bound `String: Copy` is not satisfied
`32`	`31`
`33`	`32`	`fn func() -> Self::Out {`
	`33`	+ //~^ ERROR the trait bound `String: Copy` is not satisfied
`34`	`34`	`Box::new(AssocNoCopy)`
`35`	`35`	`}`
`36`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,12 +8,12 @@ pub trait Bar {`
`8`	`8`
`9`	`9`	`impl<S: Default> Bar for S {`
`10`	`10`	`type E = impl Copy;`
`11`		- //~^ ERROR the trait bound `S: Copy` is not satisfied in `(S, T)` [E0277]
`12`		- //~^^ ERROR the trait bound `T: Copy` is not satisfied in `(S, T)` [E0277]
`13`	`11`
`14`	`12`	`fn foo<T: Default>() -> Self::E {`
`15`	`13`	//~^ ERROR type parameter `T` is part of concrete type but not used in parameter list for the `impl Trait` type alias
`16`	`14`	`//~\| ERROR impl has stricter requirements than trait`
	`15`	+ //~\| ERROR the trait bound `S: Copy` is not satisfied in `(S, T)` [E0277]
	`16`	+ //~\| ERROR the trait bound `T: Copy` is not satisfied in `(S, T)` [E0277]
`17`	`17`	`(S::default(), T::default())`
`18`	`18`	`}`
`19`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,9 +11,9 @@ pub trait Bar {`
`11`	`11`
`12`	`12`	`impl<S> Bar for S {`
`13`	`13`	`type E = impl std::marker::Copy;`
`14`		- //~^ ERROR the trait bound `impl Future: Copy` is not satisfied [E0277]
`15`	`14`	`fn foo<T>() -> Self::E {`
`16`	`15`	//~^ ERROR type parameter `T` is part of concrete type but not used in parameter list for the `impl Trait` type alias
	`16`	+ //~\| ERROR the trait bound `impl Future: Copy` is not satisfied [E0277]
`17`	`17`	`async {}`
`18`	`18`	`}`
`19`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,9 +7,9 @@ fn main() {`
`7`	`7`	`}`
`8`	`8`
`9`	`9`	`type WrongGeneric<T> = impl 'static;`
`10`		-//~^ ERROR the parameter type `T` may not live long enough
`11`		`-//~\| ERROR: at least one trait must be specified`
	`10`	`+//~^ ERROR: at least one trait must be specified`
`12`	`11`
`13`	`12`	`fn wrong_generic<T>(t: T) -> WrongGeneric<T> {`
	`13`	+ //~^ ERROR the parameter type `T` may not live long enough
`14`	`14`	`t`
`15`	`15`	`}`
Original file line number	Diff line number	Diff line change
`@@ -15,9 +15,9 @@ struct X;`
`15`	`15`
`16`	`16`	`impl Foo for X {`
`17`	`17`	`type Bar = impl Baz<Self, Self>;`
`18`		- //~^ ERROR implementation of `FnOnce` is not general enough
`19`	`18`
`20`	`19`	`fn bar(&self) -> Self::Bar {`
	`20`	+ //~^ ERROR implementation of `FnOnce` is not general enough
`21`	`21`	`\|x\| x`
`22`	`22`	`}`
`23`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,8 @@`
`1`	`1`	error: implementation of `FnOnce` is not general enough
`2`		`- --> $DIR/issue-57611-trait-alias.rs:17:16`
	`2`	`+ --> $DIR/issue-57611-trait-alias.rs:19:22`
`3`	`3`	`\|`
`4`		`-LL \| type Bar = impl Baz<Self, Self>;`
`5`		- \| ^^^^^^^^^^^^^^^^^^^^ implementation of `FnOnce` is not general enough
	`4`	`+LL \| fn bar(&self) -> Self::Bar {`
	`5`	+ \| ^^^^^^^^^ implementation of `FnOnce` is not general enough
`6`	`6`	`\|`
`7`	`7`	= note: closure with signature `fn(&'2 X) -> &X` must implement `FnOnce<(&'1 X,)>`, for any lifetime `'1`...
`8`	`8`	= note: ...but it actually implements `FnOnce<(&'2 X,)>`, for some specific lifetime `'2`
Original file line number	Diff line number	Diff line change
`@@ -8,9 +8,9 @@ trait Bug {`
`8`	`8`
`9`	`9`	`impl Bug for &() {`
`10`	`10`	type Item = impl Bug; //~ ERROR `impl Trait` in type aliases is unstable
`11`		- //~^ ERROR the trait bound `(): Bug` is not satisfied
`12`	`11`
`13`	`12`	`const FUN: fn() -> Self::Item = \|\| ();`
	`13`	+ //~^ ERROR the trait bound `(): Bug` is not satisfied
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`fn main() {}`
Original file line number	Diff line number	Diff line change
`@@ -8,10 +8,10 @@ LL \| type Item = impl Bug;`
`8`	`8`	= help: add `#![feature(type_alias_impl_trait)]` to the crate attributes to enable
`9`	`9`
`10`	`10`	error[E0277]: the trait bound `(): Bug` is not satisfied
`11`		`- --> $DIR/issue-60371.rs:10:17`
	`11`	`+ --> $DIR/issue-60371.rs:12:40`
`12`	`12`	`\|`
`13`		`-LL \| type Item = impl Bug;`
`14`		- \| ^^^^^^^^ the trait `Bug` is not implemented for `()`
	`13`	`+LL \| const FUN: fn() -> Self::Item = \|\| ();`
	`14`	+ \| ^ the trait `Bug` is not implemented for `()`
`15`	`15`	`\|`
`16`	`16`	`= help: the following implementations were found:`
`17`	`17`	`<&() as Bug>`
Original file line number	Diff line number	Diff line change
`@@ -5,9 +5,9 @@`
`5`	`5`	`#![feature(type_alias_impl_trait)]`
`6`	`6`
`7`	`7`	`type X<A, B> = impl Into<&'static A>;`
`8`		-//~^ ERROR the trait bound `&'static B: From<&A>` is not satisfied
`9`	`8`
`10`	`9`	`fn f<A, B: 'static>(a: &'static A, b: B) -> (X<A, B>, X<B, A>) {`
	`10`	+ //~^ ERROR the trait bound `&'static B: From<&A>` is not satisfied
`11`	`11`	`(a, a)`
`12`	`12`	`}`
`13`	`13`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,8 @@`
`1`	`1`	error[E0277]: the trait bound `&'static B: From<&A>` is not satisfied
`2`		`- --> $DIR/multiple-def-uses-in-one-fn.rs:7:16`
	`2`	`+ --> $DIR/multiple-def-uses-in-one-fn.rs:9:45`
`3`	`3`	`\|`
`4`		`-LL \| type X<A, B> = impl Into<&'static A>;`
`5`		- \| ^^^^^^^^^^^^^^^^^^^^^ the trait `From<&A>` is not implemented for `&'static B`
	`4`	`+LL \| fn f<A, B: 'static>(a: &'static A, b: B) -> (X<A, B>, X<B, A>) {`
	`5`	+ \| ^^^^^^^^^^^^^^^^^^ the trait `From<&A>` is not implemented for `&'static B`
`6`	`6`	`\|`
`7`	`7`	= note: required because of the requirements on the impl of `Into<&'static B>` for `&A`
`8`	`8`	help: consider introducing a `where` bound, but there might be an alternative better way to express this requirement