Skip to content

Commit 949d1d9

Browse files
[JITLink] Remove some std::move(MemoryBufferRef) below createLinkGraphFromObject() (NFC)
1 parent 0c5e0cf commit 949d1d9

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

llvm/lib/ExecutionEngine/JITLink/ELF.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ createLinkGraphFromELFObject(MemoryBufferRef ObjectBuffer) {
6565

6666
switch (*TargetMachineArch) {
6767
case ELF::EM_X86_64:
68-
return createLinkGraphFromELFObject_x86_64(std::move(ObjectBuffer));
68+
return createLinkGraphFromELFObject_x86_64(ObjectBuffer);
6969
default:
7070
return make_error<JITLinkError>(
7171
"Unsupported target machine architecture in ELF object " +

llvm/lib/ExecutionEngine/JITLink/JITLink.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -327,9 +327,9 @@ createLinkGraphFromObject(MemoryBufferRef ObjectBuffer) {
327327
auto Magic = identify_magic(ObjectBuffer.getBuffer());
328328
switch (Magic) {
329329
case file_magic::macho_object:
330-
return createLinkGraphFromMachOObject(std::move(ObjectBuffer));
330+
return createLinkGraphFromMachOObject(ObjectBuffer);
331331
case file_magic::elf_relocatable:
332-
return createLinkGraphFromELFObject(std::move(ObjectBuffer));
332+
return createLinkGraphFromELFObject(ObjectBuffer);
333333
default:
334334
return make_error<JITLinkError>("Unsupported file format");
335335
};

llvm/lib/ExecutionEngine/JITLink/MachO.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,9 @@ createLinkGraphFromMachOObject(MemoryBufferRef ObjectBuffer) {
6464

6565
switch (CPUType) {
6666
case MachO::CPU_TYPE_ARM64:
67-
return createLinkGraphFromMachOObject_arm64(std::move(ObjectBuffer));
67+
return createLinkGraphFromMachOObject_arm64(ObjectBuffer);
6868
case MachO::CPU_TYPE_X86_64:
69-
return createLinkGraphFromMachOObject_x86_64(std::move(ObjectBuffer));
69+
return createLinkGraphFromMachOObject_x86_64(ObjectBuffer);
7070
}
7171
return make_error<JITLinkError>("MachO-64 CPU type not valid");
7272
} else

llvm/lib/ExecutionEngine/Orc/ObjectLinkingLayer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -486,7 +486,7 @@ void ObjectLinkingLayer::emit(std::unique_ptr<MaterializationResponsibility> R,
486486
auto ObjBuffer = O->getMemBufferRef();
487487
auto Ctx = std::make_unique<ObjectLinkingLayerJITLinkContext>(
488488
*this, std::move(R), std::move(O));
489-
if (auto G = createLinkGraphFromObject(std::move(ObjBuffer)))
489+
if (auto G = createLinkGraphFromObject(ObjBuffer))
490490
link(std::move(*G), std::move(Ctx));
491491
else
492492
Ctx->notifyFailed(G.takeError());

0 commit comments

Comments
 (0)