Skip to content

Commit 1de70a7

Browse files
committed
Revert "[OpenMPOpt] ICV tracking for calls"
This commits breaks certain OpenMP codes (on power) because it expanded the Attributor scope without telling the Attributor about the SCC extend. See: https://reviews.llvm.org/D85544#2227611 This reverts commit b0b32e6.
1 parent 0289696 commit 1de70a7

File tree

3 files changed

+116
-889
lines changed

3 files changed

+116
-889
lines changed

llvm/lib/Transforms/IPO/Attributor.cpp

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -901,15 +901,13 @@ bool Attributor::checkForAllInstructions(function_ref<bool(Instruction &)> Pred,
901901

902902
// TODO: use the function scope once we have call site AAReturnedValues.
903903
const IRPosition &QueryIRP = IRPosition::function(*AssociatedFunction);
904-
const auto *LivenessAA =
905-
CheckBBLivenessOnly ? nullptr
906-
: &(getAAFor<AAIsDead>(QueryingAA, QueryIRP,
907-
/* TrackDependence */ false));
904+
const auto &LivenessAA =
905+
getAAFor<AAIsDead>(QueryingAA, QueryIRP, /* TrackDependence */ false);
908906

909907
auto &OpcodeInstMap =
910908
InfoCache.getOpcodeInstMapForFunction(*AssociatedFunction);
911909
if (!checkForAllInstructionsImpl(this, OpcodeInstMap, Pred, &QueryingAA,
912-
LivenessAA, Opcodes, CheckBBLivenessOnly))
910+
&LivenessAA, Opcodes, CheckBBLivenessOnly))
913911
return false;
914912

915913
return true;

0 commit comments

Comments
 (0)