Skip to content

Add crates to the database before building them #1011

Closed
@jyn514

Description

@jyn514

Right now, all targets are built before the crate is added to the database. We should change this:

  • We could avoid having documentation on S3 that isn't deleted if the queue reader panics and doesn't add the crate to the database (Upload sources even for binaries and failed builds #928 (comment)) - if a panic or crash happens, we can delete the documentation the next time the server starts up.

  • We could display documentation for the default target before all crates have finished being built. After that, we would upload each target as it completes.

  • We could show which crate is currently being built. Currently, the queue looks like this:
    image

This shows the crates that are scheduled, but doesn't say which is currently being built. You can usually infer that it's the first in the queue, but this isn't always the case - sometimes a crate will be de-prioritized while building, so it will show up at the bottom of the queue even though it's currently being built.

It would be great to show
a) which crate is being built
b) a link on /:crate/:version to the build queue

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-buildsArea: Building the documentation for a crate

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions