Fix some nightly clippy warnings

Author: Nemo157

build.rs

@@ -162,7 +162,7 @@ fn write_known_targets(out_dir: &Path) -> Result<()> {
     use std::io::BufRead;
 
     let targets: Vec<String> = std::process::Command::new("rustc")
-        .args(&["--print", "target-list"])
+        .args(["--print", "target-list"])
         .output()?
         .stdout
         .lines()

src/index/mod.rs

@@ -109,7 +109,7 @@ impl Index {
         let gc = Command::new("git")
             .arg("-C")
             .arg(&self.path)
-            .args(&["gc", "--auto"])
+            .args(["gc", "--auto"])
             .output()
             .with_context(|| format!("failed to run `git gc --auto`\npath: {:#?}", &self.path));
 

src/storage/mod.rs

@@ -302,7 +302,7 @@ impl Storage {
 
         Ok(Blob {
             path: format!("{}/{}", archive_path, path),
-            mime: detect_mime(&path).into(),
+            mime: detect_mime(path).into(),
             date_updated: blob.date_updated,
             content: blob.content,
             compression: None,

src/web/crate_details.rs

@@ -303,7 +303,7 @@ pub fn crate_details_handler(req: &mut Request) -> IronResult<Response> {
     let name = cexpect!(req, router.find("name"));
     let req_version = router.find("version");
 
-    if req_version == None {
+    if req_version.is_none() {
         let url = ctry!(
             req,
             Url::parse(&format!("{}/crate/{}/latest", redirect_base(req), name,)),

src/web/csp.rs

@@ -15,7 +15,7 @@ impl Csp {
         getrandom::getrandom(&mut random).expect("failed to generate a nonce");
 
         Self {
-            nonce: base64::encode(&random),
+            nonce: base64::encode(random),
             suppress: false,
         }
     }

src/web/features.rs

@@ -85,10 +85,7 @@ pub fn build_features_handler(req: &mut Request) -> IronResult<Response> {
 fn order_features_and_count_default_len(raw: Vec<Feature>) -> (Vec<Feature>, usize) {
     let mut feature_map = get_feature_map(raw);
     let mut features = get_tree_structure_from_default(&mut feature_map);
-    let mut remaining: Vec<_> = feature_map
-        .into_iter()
-        .map(|(_, feature)| feature)
-        .collect();
+    let mut remaining = Vec::from_iter(feature_map.into_values());
     remaining.sort_by_key(|feature| feature.subfeatures.len());
 
     let default_len = features.len();

src/web/releases.rs

@@ -535,7 +535,7 @@ pub fn search_handler(req: &mut Request) -> IronResult<Response> {
     let search_result = ctry!(
         req,
         if let Some(paginate) = params.get("paginate") {
-            let decoded = base64::decode(&paginate.as_bytes()).map_err(|e| -> IronError {
+            let decoded = base64::decode(paginate.as_bytes()).map_err(|e| -> IronError {
                 warn!(
                     "error when decoding pagination base64 string \"{}\": {:?}",
                     paginate, e
@@ -571,9 +571,7 @@ pub fn search_handler(req: &mut Request) -> IronResult<Response> {
         }
     );
 
-    let executed_query = search_result
-        .executed_query
-        .unwrap_or_else(|| "".to_string());
+    let executed_query = search_result.executed_query.unwrap_or_default();
 
     let title = if search_result.results.is_empty() {
         format!("No results found for '{}'", executed_query)

src/web/rustdoc.rs

@@ -154,7 +154,7 @@ pub fn rustdoc_redirector_handler(req: &mut Request) -> IronResult<Response> {
     }
     let (mut version, id) = v.version.into_parts();
 
-    if req_version == None || req_version == Some("latest") {
+    if let None | Some("latest") = req_version {
         version = "latest".to_string()
     }
 

src/web/source.rs

@@ -98,9 +98,9 @@ impl FileList {
                     }
 
                     // look only files for req_path
-                    if path.starts_with(&req_path) {
+                    if path.starts_with(req_path) {
                         // remove req_path from path to reach files in this directory
-                        let path = path.replace(&req_path, "");
+                        let path = path.replace(req_path, "");
                         let path_splited: Vec<&str> = path.split('/').collect();
 
                         // if path have '/' it is a directory
@@ -245,10 +245,10 @@ pub fn source_browser_handler(req: &mut Request) -> IronResult<Response> {
             conn.query(
                 "
                 SELECT archive_storage
-                FROM releases 
+                FROM releases
                 INNER JOIN crates ON releases.crate_id = crates.id
-                WHERE 
-                    name = $1 AND 
+                WHERE
+                    name = $1 AND
                     version = $2
                 ",
                 &[&crate_name, &version]