Skip to content

Commit b0f5bb8

Browse files
joshtriplettsyphar
authored andcommitted
Fix search redirection for crate::some::path to use ?search=
Search within crates uses `?search=`, not `?query=`.
1 parent 6aa2e0f commit b0f5bb8

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/web/releases.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,7 @@ pub fn search_handler(req: &mut Request) -> IronResult<Response> {
562562
}
563563

564564
let (krate, query) = match query.split_once("::") {
565-
Some((krate, query)) => (krate.to_string(), format!("?query={query}")),
565+
Some((krate, query)) => (krate.to_string(), format!("?search={query}")),
566566
None => (query.clone(), "".to_string()),
567567
};
568568

@@ -884,12 +884,12 @@ mod tests {
884884

885885
assert_redirect(
886886
"/releases/search?query=some_random_crate::somepath",
887-
"/some_random_crate/1.0.0/some_random_crate/?query=somepath",
887+
"/some_random_crate/1.0.0/some_random_crate/?search=somepath",
888888
web,
889889
)?;
890890
assert_redirect(
891891
"/releases/search?query=some_random_crate::some::path",
892-
"/some_random_crate/1.0.0/some_random_crate/?query=some::path",
892+
"/some_random_crate/1.0.0/some_random_crate/?search=some::path",
893893
web,
894894
)?;
895895
Ok(())

src/web/rustdoc.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ pub fn rustdoc_redirector_handler(req: &mut Request) -> IronResult<Response> {
7171
url_str.push('?');
7272
url_str.push_str(query);
7373
} else if let Some(path) = path_in_crate {
74-
url_str.push_str("?query=");
74+
url_str.push_str("?search=");
7575
url_str.push_str(path);
7676
}
7777
let url = ctry!(req, Url::parse(&url_str));
@@ -1724,12 +1724,12 @@ mod test {
17241724

17251725
assert_redirect(
17261726
"/some_random_crate::somepath",
1727-
"/some_random_crate/latest/some_random_crate/?query=somepath",
1727+
"/some_random_crate/latest/some_random_crate/?search=somepath",
17281728
web,
17291729
)?;
17301730
assert_redirect(
17311731
"/some_random_crate::some::path",
1732-
"/some_random_crate/latest/some_random_crate/?query=some::path",
1732+
"/some_random_crate/latest/some_random_crate/?search=some::path",
17331733
web,
17341734
)?;
17351735
Ok(())

0 commit comments

Comments
 (0)