From 091daeecc4ff5652c68531a4a61b24d768d1fd95 Mon Sep 17 00:00:00 2001 From: Tobias Bieniek Date: Tue, 22 Nov 2022 20:13:23 +0100 Subject: [PATCH 1/5] tests: Use `assert.true/false()` where possible --- tests/acceptance/email-change-test.js | 8 ++++---- tests/acceptance/email-confirmation-test.js | 10 +++++----- tests/mirage/confirm/put-by-id-test.js | 8 ++++---- tests/mirage/users/update-by-id-test.js | 2 +- tests/models/user-test.js | 8 ++++---- 5 files changed, 18 insertions(+), 18 deletions(-) diff --git a/tests/acceptance/email-change-test.js b/tests/acceptance/email-change-test.js index c83f9088a45..a7bf2949bb8 100644 --- a/tests/acceptance/email-change-test.js +++ b/tests/acceptance/email-change-test.js @@ -45,7 +45,7 @@ module('Acceptance | Email Change', function (hooks) { user.reload(); assert.strictEqual(user.email, 'new@email.com'); - assert.strictEqual(user.emailVerified, false); + assert.false(user.emailVerified); assert.ok(user.emailVerificationToken); }); @@ -82,7 +82,7 @@ module('Acceptance | Email Change', function (hooks) { user.reload(); assert.strictEqual(user.email, 'new@email.com'); - assert.strictEqual(user.emailVerified, false); + assert.false(user.emailVerified); assert.ok(user.emailVerificationToken); }); @@ -104,7 +104,7 @@ module('Acceptance | Email Change', function (hooks) { user.reload(); assert.strictEqual(user.email, 'old@email.com'); - assert.strictEqual(user.emailVerified, true); + assert.true(user.emailVerified); assert.notOk(user.emailVerificationToken); }); @@ -128,7 +128,7 @@ module('Acceptance | Email Change', function (hooks) { user.reload(); assert.strictEqual(user.email, 'old@email.com'); - assert.strictEqual(user.emailVerified, true); + assert.true(user.emailVerified); assert.notOk(user.emailVerificationToken); }); diff --git a/tests/acceptance/email-confirmation-test.js b/tests/acceptance/email-confirmation-test.js index c4895e66b1f..4014e03e0bd 100644 --- a/tests/acceptance/email-confirmation-test.js +++ b/tests/acceptance/email-confirmation-test.js @@ -10,19 +10,19 @@ module('Acceptance | Email Confirmation', function (hooks) { test('unauthenticated happy path', async function (assert) { let user = this.server.create('user', { emailVerificationToken: 'badc0ffee' }); - assert.strictEqual(user.emailVerified, false); + assert.false(user.emailVerified); await visit('/confirm/badc0ffee'); assert.equal(currentURL(), '/'); assert.dom('[data-test-notification-message="success"]').exists(); user.reload(); - assert.strictEqual(user.emailVerified, true); + assert.true(user.emailVerified); }); test('authenticated happy path', async function (assert) { let user = this.server.create('user', { emailVerificationToken: 'badc0ffee' }); - assert.strictEqual(user.emailVerified, false); + assert.false(user.emailVerified); this.authenticateAs(user); @@ -31,10 +31,10 @@ module('Acceptance | Email Confirmation', function (hooks) { assert.dom('[data-test-notification-message="success"]').exists(); let { currentUser } = this.owner.lookup('service:session'); - assert.strictEqual(currentUser.email_verified, true); + assert.true(currentUser.email_verified); user.reload(); - assert.strictEqual(user.emailVerified, true); + assert.true(user.emailVerified); }); test('error case', async function (assert) { diff --git a/tests/mirage/confirm/put-by-id-test.js b/tests/mirage/confirm/put-by-id-test.js index 8c3727eb016..2c2efa71129 100644 --- a/tests/mirage/confirm/put-by-id-test.js +++ b/tests/mirage/confirm/put-by-id-test.js @@ -11,19 +11,19 @@ module('Mirage | PUT /api/v1/confirm/:token', function (hooks) { test('returns `ok: true` for a known token (unauthenticated)', async function (assert) { let user = this.server.create('user', { emailVerificationToken: 'foo' }); - assert.strictEqual(user.emailVerified, false); + assert.false(user.emailVerified); let response = await fetch('/api/v1/confirm/foo', { method: 'PUT' }); assert.equal(response.status, 200); assert.deepEqual(await response.json(), { ok: true }); user.reload(); - assert.strictEqual(user.emailVerified, true); + assert.true(user.emailVerified); }); test('returns `ok: true` for a known token (authenticated)', async function (assert) { let user = this.server.create('user', { emailVerificationToken: 'foo' }); - assert.strictEqual(user.emailVerified, false); + assert.false(user.emailVerified); this.server.create('mirage-session', { user }); @@ -32,7 +32,7 @@ module('Mirage | PUT /api/v1/confirm/:token', function (hooks) { assert.deepEqual(await response.json(), { ok: true }); user.reload(); - assert.strictEqual(user.emailVerified, true); + assert.true(user.emailVerified); }); test('returns an error for unknown tokens', async function (assert) { diff --git a/tests/mirage/users/update-by-id-test.js b/tests/mirage/users/update-by-id-test.js index a09d74e8be9..5f90dd1f7ed 100644 --- a/tests/mirage/users/update-by-id-test.js +++ b/tests/mirage/users/update-by-id-test.js @@ -20,7 +20,7 @@ module('Mirage | PUT /api/v1/users/:id', function (hooks) { user.reload(); assert.strictEqual(user.email, 'new@email.com'); - assert.strictEqual(user.emailVerified, false); + assert.false(user.emailVerified); assert.strictEqual(user.emailVerificationToken, 'secret123'); }); diff --git a/tests/models/user-test.js b/tests/models/user-test.js index e95a3df0290..2625ebdecc7 100644 --- a/tests/models/user-test.js +++ b/tests/models/user-test.js @@ -20,13 +20,13 @@ module('Model | User', function (hooks) { let { currentUser } = await this.owner.lookup('service:session').loadUserTask.perform(); assert.equal(currentUser.email, 'old@email.com'); - assert.equal(currentUser.email_verified, true); - assert.equal(currentUser.email_verification_sent, true); + assert.true(currentUser.email_verified); + assert.true(currentUser.email_verification_sent); await currentUser.changeEmail('new@email.com'); assert.equal(currentUser.email, 'new@email.com'); - assert.equal(currentUser.email_verified, false); - assert.equal(currentUser.email_verification_sent, true); + assert.false(currentUser.email_verified); + assert.true(currentUser.email_verification_sent); }); test('error handling', async function (assert) { From 0a16b74a2ac9a20b6f80a6d68022c76d83092c2f Mon Sep 17 00:00:00 2001 From: Tobias Bieniek Date: Tue, 22 Nov 2022 20:13:46 +0100 Subject: [PATCH 2/5] tests: Use `assert.notOk()` instead of negated `assert.ok()` --- tests/utils/ajax-test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/utils/ajax-test.js b/tests/utils/ajax-test.js index c14f33d6456..a4afd6f2832 100644 --- a/tests/utils/ajax-test.js +++ b/tests/utils/ajax-test.js @@ -111,7 +111,7 @@ module('ajax()', function (hooks) { ]; let { cause } = error; - assert.ok(!(cause instanceof HttpError)); + assert.notOk(cause instanceof HttpError); assert.equal(cause.name, 'SyntaxError'); assert.ok(expectedCauseMessages.includes(cause.message)); return true; @@ -139,7 +139,7 @@ module('ajax()', function (hooks) { assert.true(error.isNetworkError); let { cause } = error; - assert.ok(!(cause instanceof HttpError)); + assert.notOk(cause instanceof HttpError); assert.equal(cause.name, 'TypeError'); assert.equal(cause.message, 'NetworkError when attempting to fetch resource.'); return true; From 1876d7af964343b358b481c40c1c1bb32233894b Mon Sep 17 00:00:00 2001 From: Tobias Bieniek Date: Tue, 22 Nov 2022 20:34:18 +0100 Subject: [PATCH 3/5] Replace `assert.equals()` with `assert.strictEquals()` The same way as we use `===` instead of `==` --- tests/acceptance/404-test.js | 2 +- tests/acceptance/api-token-test.js | 14 ++-- tests/acceptance/crate-dependencies-test.js | 16 ++--- tests/acceptance/crate-navtabs-test.js | 8 +-- tests/acceptance/crate-test.js | 38 +++++------ tests/acceptance/crates-test.js | 10 +-- tests/acceptance/dashboard-test.js | 4 +- tests/acceptance/email-change-test.js | 8 +-- tests/acceptance/email-confirmation-test.js | 6 +- tests/acceptance/front-page-test.js | 4 +- tests/acceptance/invites-test.js | 32 +++++----- tests/acceptance/login-test.js | 17 +++-- tests/acceptance/logout-test.js | 4 +- tests/acceptance/reverse-dependencies-test.js | 12 ++-- tests/acceptance/search-test.js | 16 ++--- tests/acceptance/settings/settings-test.js | 4 +- tests/acceptance/token-invites-test.js | 10 +-- tests/acceptance/versions-test.js | 2 +- tests/adapters/crate-test.js | 4 +- tests/bugs/2329-test.js | 2 +- tests/mirage/categories/get-by-id-test.js | 6 +- tests/mirage/categories/list-test.js | 16 ++--- tests/mirage/category-slugs/list-test.js | 8 +-- tests/mirage/confirm/put-by-id-test.js | 6 +- tests/mirage/crates/downloads-test.js | 6 +- tests/mirage/crates/follow/delete-test.js | 6 +- tests/mirage/crates/follow/get-test.js | 8 +-- tests/mirage/crates/follow/put-test.js | 6 +- tests/mirage/crates/get-by-id-test.js | 10 +-- tests/mirage/crates/list-test.js | 64 +++++++++---------- tests/mirage/crates/owner-team-test.js | 6 +- tests/mirage/crates/owner-user-test.js | 6 +- .../crates/reverse-dependencies-test.js | 20 +++--- tests/mirage/crates/versions/authors-test.js | 8 +-- .../crates/versions/dependencies-test.js | 8 +-- .../mirage/crates/versions/downloads-test.js | 8 +-- tests/mirage/crates/versions/list-test.js | 6 +- tests/mirage/crates/versions/readme-test.js | 16 ++--- tests/mirage/keywords/get-by-id-test.js | 6 +- tests/mirage/keywords/list-test.js | 16 ++--- .../me/crate-owner-invitations/list-test.js | 6 +- tests/mirage/me/get-test.js | 6 +- tests/mirage/me/tokens/create-test.js | 4 +- tests/mirage/me/tokens/delete-by-id-test.js | 6 +- tests/mirage/me/tokens/list-test.js | 6 +- tests/mirage/me/updates/list-test.js | 10 +-- .../crate-owner-invitations/get-test.js | 18 +++--- tests/mirage/private/session/delete-test.js | 4 +- tests/mirage/summary-test.js | 20 +++--- tests/mirage/teams/get-by-id-test.js | 4 +- tests/mirage/users/get-by-id-test.js | 4 +- tests/mirage/users/resend-by-id-test.js | 6 +- tests/mirage/users/update-by-id-test.js | 10 +-- tests/models/user-test.js | 4 +- tests/models/version-test.js | 4 +- tests/routes/category-test.js | 4 +- tests/routes/crate/range-test.js | 18 +++--- tests/routes/crate/version/model-test.js | 12 ++-- tests/routes/keyword-test.js | 4 +- tests/services/redirector-test.js | 2 +- tests/unit/helpers/format-email-test.js | 10 +-- tests/utils/ajax-test.js | 50 +++++++-------- 62 files changed, 334 insertions(+), 327 deletions(-) diff --git a/tests/acceptance/404-test.js b/tests/acceptance/404-test.js index 3dfe251a902..6bff9df1e02 100644 --- a/tests/acceptance/404-test.js +++ b/tests/acceptance/404-test.js @@ -10,7 +10,7 @@ module('Acceptance | 404', function (hooks) { test('/unknown-route shows a 404 page', async function (assert) { await visit('/unknown-route'); - assert.equal(currentURL(), '/unknown-route'); + assert.strictEqual(currentURL(), '/unknown-route'); assert.dom('[data-test-404-page]').exists(); assert.dom('[data-test-title]').hasText('Page not found'); assert.dom('[data-test-go-back]').exists(); diff --git a/tests/acceptance/api-token-test.js b/tests/acceptance/api-token-test.js index 939261662c3..4d2ce924407 100644 --- a/tests/acceptance/api-token-test.js +++ b/tests/acceptance/api-token-test.js @@ -40,7 +40,7 @@ module('Acceptance | api-tokens', function (hooks) { prepare(this); await visit('/settings/tokens'); - assert.equal(currentURL(), '/settings/tokens'); + assert.strictEqual(currentURL(), '/settings/tokens'); assert.dom('[data-test-api-token]').exists({ count: 2 }); let [row1, row2] = findAll('[data-test-api-token]'); @@ -67,11 +67,15 @@ module('Acceptance | api-tokens', function (hooks) { prepare(this); await visit('/settings/tokens'); - assert.equal(currentURL(), '/settings/tokens'); + assert.strictEqual(currentURL(), '/settings/tokens'); assert.dom('[data-test-api-token]').exists({ count: 2 }); await click('[data-test-api-token="1"] [data-test-revoke-token-button]'); - assert.equal(this.server.schema.apiTokens.all().length, 1, 'API token has been deleted from the backend database'); + assert.strictEqual( + this.server.schema.apiTokens.all().length, + 1, + 'API token has been deleted from the backend database', + ); assert.dom('[data-test-api-token]').exists({ count: 1 }); assert.dom('[data-test-api-token="2"]').exists(); @@ -86,7 +90,7 @@ module('Acceptance | api-tokens', function (hooks) { }); await visit('/settings/tokens'); - assert.equal(currentURL(), '/settings/tokens'); + assert.strictEqual(currentURL(), '/settings/tokens'); assert.dom('[data-test-api-token]').exists({ count: 2 }); await click('[data-test-api-token="1"] [data-test-revoke-token-button]'); @@ -100,7 +104,7 @@ module('Acceptance | api-tokens', function (hooks) { prepare(this); await visit('/settings/tokens'); - assert.equal(currentURL(), '/settings/tokens'); + assert.strictEqual(currentURL(), '/settings/tokens'); assert.dom('[data-test-api-token]').exists({ count: 2 }); assert.dom('[data-test-focused-input]').doesNotExist(); assert.dom('[data-test-save-token-button]').doesNotExist(); diff --git a/tests/acceptance/crate-dependencies-test.js b/tests/acceptance/crate-dependencies-test.js index 62cb9ae59ce..9d94624107b 100644 --- a/tests/acceptance/crate-dependencies-test.js +++ b/tests/acceptance/crate-dependencies-test.js @@ -17,8 +17,8 @@ module('Acceptance | crate dependencies page', function (hooks) { this.server.loadFixtures(); await visit('/crates/nanomsg/dependencies'); - assert.equal(currentURL(), '/crates/nanomsg/0.6.1/dependencies'); - assert.equal(getPageTitle(), 'nanomsg - crates.io: Rust Package Registry'); + assert.strictEqual(currentURL(), '/crates/nanomsg/0.6.1/dependencies'); + assert.strictEqual(getPageTitle(), 'nanomsg - crates.io: Rust Package Registry'); assert.dom('[data-test-dependencies] li').exists({ count: 2 }); assert.dom('[data-test-build-dependencies] li').exists({ count: 1 }); @@ -42,7 +42,7 @@ module('Acceptance | crate dependencies page', function (hooks) { test('shows an error page if crate not found', async function (assert) { await visit('/crates/foo/1.0.0/dependencies'); - assert.equal(currentURL(), '/crates/foo/1.0.0/dependencies'); + assert.strictEqual(currentURL(), '/crates/foo/1.0.0/dependencies'); assert.dom('[data-test-404-page]').exists(); assert.dom('[data-test-title]').hasText('foo: Crate not found'); assert.dom('[data-test-go-back]').exists(); @@ -53,7 +53,7 @@ module('Acceptance | crate dependencies page', function (hooks) { this.server.get('/api/v1/crates/:crate_name', {}, 500); await visit('/crates/foo/1.0.0/dependencies'); - assert.equal(currentURL(), '/crates/foo/1.0.0/dependencies'); + assert.strictEqual(currentURL(), '/crates/foo/1.0.0/dependencies'); assert.dom('[data-test-404-page]').exists(); assert.dom('[data-test-title]').hasText('foo: Failed to load crate data'); assert.dom('[data-test-go-back]').doesNotExist(); @@ -65,7 +65,7 @@ module('Acceptance | crate dependencies page', function (hooks) { this.server.create('version', { crate, num: '2.0.0' }); await visit('/crates/foo/1.0.0/dependencies'); - assert.equal(currentURL(), '/crates/foo/1.0.0/dependencies'); + assert.strictEqual(currentURL(), '/crates/foo/1.0.0/dependencies'); assert.dom('[data-test-404-page]').exists(); assert.dom('[data-test-title]').hasText('foo: Version 1.0.0 not found'); assert.dom('[data-test-go-back]').exists(); @@ -85,7 +85,7 @@ module('Acceptance | crate dependencies page', function (hooks) { versions.forEach(record => record.unloadRecord()); await visit('/crates/foo/1.0.0/dependencies'); - assert.equal(currentURL(), '/crates/foo/1.0.0/dependencies'); + assert.strictEqual(currentURL(), '/crates/foo/1.0.0/dependencies'); assert.dom('[data-test-404-page]').exists(); assert.dom('[data-test-title]').hasText('foo: Failed to load version data'); assert.dom('[data-test-go-back]').doesNotExist(); @@ -99,7 +99,7 @@ module('Acceptance | crate dependencies page', function (hooks) { this.server.get('/api/v1/crates/:crate_name/:version_num/dependencies', {}, 500); await visit('/crates/foo/1.0.0/dependencies'); - assert.equal(currentURL(), '/crates/foo/1.0.0/dependencies'); + assert.strictEqual(currentURL(), '/crates/foo/1.0.0/dependencies'); assert.dom('[data-test-404-page]').exists(); assert.dom('[data-test-title]').hasText('foo: Failed to load dependencies'); assert.dom('[data-test-go-back]').doesNotExist(); @@ -121,7 +121,7 @@ module('Acceptance | crate dependencies page', function (hooks) { this.server.get('/api/v1/crates', {}, 500); await visit('/crates/nanomsg/dependencies'); - assert.equal(currentURL(), '/crates/nanomsg/0.6.1/dependencies'); + assert.strictEqual(currentURL(), '/crates/nanomsg/0.6.1/dependencies'); assert.dom('[data-test-dependencies] li').exists({ count: 2 }); diff --git a/tests/acceptance/crate-navtabs-test.js b/tests/acceptance/crate-navtabs-test.js index f1cc89350f9..c1d40cc126b 100644 --- a/tests/acceptance/crate-navtabs-test.js +++ b/tests/acceptance/crate-navtabs-test.js @@ -17,7 +17,7 @@ module('Acceptance | crate navigation tabs', function (hooks) { this.server.create('version', { crate, num: '0.6.1' }); await visit('/crates/nanomsg'); - assert.equal(currentURL(), '/crates/nanomsg'); + assert.strictEqual(currentURL(), '/crates/nanomsg'); assert.dom(TAB_README).hasAttribute('href', '/crates/nanomsg').hasAttribute('data-test-active'); assert.dom(TAB_VERSIONS).hasAttribute('href', '/crates/nanomsg/versions').hasNoAttribute('data-test-active'); @@ -29,7 +29,7 @@ module('Acceptance | crate navigation tabs', function (hooks) { assert.dom(TAB_SETTINGS).doesNotExist(); await click(TAB_VERSIONS); - assert.equal(currentURL(), '/crates/nanomsg/versions'); + assert.strictEqual(currentURL(), '/crates/nanomsg/versions'); assert.dom(TAB_README).hasAttribute('href', '/crates/nanomsg').hasNoAttribute('data-test-active'); assert.dom(TAB_VERSIONS).hasAttribute('href', '/crates/nanomsg/versions').hasAttribute('data-test-active'); @@ -41,7 +41,7 @@ module('Acceptance | crate navigation tabs', function (hooks) { assert.dom(TAB_SETTINGS).doesNotExist(); await click(TAB_DEPS); - assert.equal(currentURL(), '/crates/nanomsg/0.6.1/dependencies'); + assert.strictEqual(currentURL(), '/crates/nanomsg/0.6.1/dependencies'); assert.dom(TAB_README).hasAttribute('href', '/crates/nanomsg/0.6.1').hasNoAttribute('data-test-active'); assert.dom(TAB_VERSIONS).hasAttribute('href', '/crates/nanomsg/versions').hasNoAttribute('data-test-active'); @@ -53,7 +53,7 @@ module('Acceptance | crate navigation tabs', function (hooks) { assert.dom(TAB_SETTINGS).doesNotExist(); await click(TAB_REV_DEPS); - assert.equal(currentURL(), '/crates/nanomsg/reverse_dependencies'); + assert.strictEqual(currentURL(), '/crates/nanomsg/reverse_dependencies'); assert.dom(TAB_README).hasAttribute('href', '/crates/nanomsg').hasNoAttribute('data-test-active'); assert.dom(TAB_VERSIONS).hasAttribute('href', '/crates/nanomsg/versions').hasNoAttribute('data-test-active'); diff --git a/tests/acceptance/crate-test.js b/tests/acceptance/crate-test.js index 95ce7f85d13..912e1213c2f 100644 --- a/tests/acceptance/crate-test.js +++ b/tests/acceptance/crate-test.js @@ -20,8 +20,8 @@ module('Acceptance | crate page', function (hooks) { await visit('/'); await click('[data-test-just-updated] [data-test-crate-link="0"]'); - assert.equal(currentURL(), '/crates/nanomsg'); - assert.equal(getPageTitle(), 'nanomsg - crates.io: Rust Package Registry'); + assert.strictEqual(currentURL(), '/crates/nanomsg'); + assert.strictEqual(getPageTitle(), 'nanomsg - crates.io: Rust Package Registry'); assert.dom('[data-test-heading] [data-test-crate-name]').hasText('nanomsg'); assert.dom('[data-test-heading] [data-test-crate-version]').hasText('v0.6.1'); @@ -34,9 +34,9 @@ module('Acceptance | crate page', function (hooks) { await visit('/crates/nanomsg'); - assert.equal(currentURL(), '/crates/nanomsg'); - assert.equal(currentRouteName(), 'crate.index'); - assert.equal(getPageTitle(), 'nanomsg - crates.io: Rust Package Registry'); + assert.strictEqual(currentURL(), '/crates/nanomsg'); + assert.strictEqual(currentRouteName(), 'crate.index'); + assert.strictEqual(getPageTitle(), 'nanomsg - crates.io: Rust Package Registry'); assert.dom('[data-test-heading] [data-test-crate-name]').hasText('nanomsg'); assert.dom('[data-test-heading] [data-test-crate-version]').hasText('v0.6.1'); @@ -53,9 +53,9 @@ module('Acceptance | crate page', function (hooks) { await visit('/crates/nanomsg/'); - assert.equal(currentURL(), '/crates/nanomsg/'); - assert.equal(currentRouteName(), 'crate.index'); - assert.equal(getPageTitle(), 'nanomsg - crates.io: Rust Package Registry'); + assert.strictEqual(currentURL(), '/crates/nanomsg/'); + assert.strictEqual(currentRouteName(), 'crate.index'); + assert.strictEqual(getPageTitle(), 'nanomsg - crates.io: Rust Package Registry'); assert.dom('[data-test-heading] [data-test-crate-name]').hasText('nanomsg'); assert.dom('[data-test-heading] [data-test-crate-version]').hasText('v0.6.1'); @@ -69,9 +69,9 @@ module('Acceptance | crate page', function (hooks) { await visit('/crates/nanomsg/0.6.0'); - assert.equal(currentURL(), '/crates/nanomsg/0.6.0'); - assert.equal(currentRouteName(), 'crate.version'); - assert.equal(getPageTitle(), 'nanomsg - crates.io: Rust Package Registry'); + assert.strictEqual(currentURL(), '/crates/nanomsg/0.6.0'); + assert.strictEqual(currentRouteName(), 'crate.version'); + assert.strictEqual(getPageTitle(), 'nanomsg - crates.io: Rust Package Registry'); assert.dom('[data-test-heading] [data-test-crate-name]').hasText('nanomsg'); assert.dom('[data-test-heading] [data-test-crate-version]').hasText('v0.6.0'); @@ -83,7 +83,7 @@ module('Acceptance | crate page', function (hooks) { test('unknown crate shows an error message', async function (assert) { await visit('/crates/nanomsg'); - assert.equal(currentURL(), '/crates/nanomsg'); + assert.strictEqual(currentURL(), '/crates/nanomsg'); assert.dom('[data-test-404-page]').exists(); assert.dom('[data-test-title]').hasText('nanomsg: Crate not found'); assert.dom('[data-test-go-back]').exists(); @@ -94,7 +94,7 @@ module('Acceptance | crate page', function (hooks) { this.server.get('/api/v1/crates/:crate_name', {}, 500); await visit('/crates/nanomsg'); - assert.equal(currentURL(), '/crates/nanomsg'); + assert.strictEqual(currentURL(), '/crates/nanomsg'); assert.dom('[data-test-404-page]').exists(); assert.dom('[data-test-title]').hasText('nanomsg: Failed to load crate data'); assert.dom('[data-test-go-back]').doesNotExist(); @@ -108,7 +108,7 @@ module('Acceptance | crate page', function (hooks) { await visit('/crates/nanomsg/0.7.0'); - assert.equal(currentURL(), '/crates/nanomsg/0.7.0'); + assert.strictEqual(currentURL(), '/crates/nanomsg/0.7.0'); assert.dom('[data-test-404-page]').exists(); assert.dom('[data-test-title]').hasText('nanomsg: Version 0.7.0 not found'); assert.dom('[data-test-go-back]').exists(); @@ -124,7 +124,7 @@ module('Acceptance | crate page', function (hooks) { await visit('/'); await click('[data-test-just-updated] [data-test-crate-link="0"]'); - assert.equal(currentURL(), '/crates/nanomsg'); + assert.strictEqual(currentURL(), '/crates/nanomsg'); assert.dom('[data-test-404-page]').exists(); assert.dom('[data-test-title]').hasText('nanomsg: Failed to load version data'); assert.dom('[data-test-go-back]').doesNotExist(); @@ -146,7 +146,7 @@ module('Acceptance | crate page', function (hooks) { await visit('/crates/nanomsg'); await click('[data-test-rev-deps-tab] a'); - assert.equal(currentURL(), '/crates/nanomsg/reverse_dependencies'); + assert.strictEqual(currentURL(), '/crates/nanomsg/reverse_dependencies'); assert.dom('a[href="/crates/unicorn-rpc"]').hasText('unicorn-rpc'); }); @@ -156,7 +156,7 @@ module('Acceptance | crate page', function (hooks) { await visit('/crates/nanomsg'); await click('[data-test-owners] [data-test-owner-link="blabaere"]'); - assert.equal(currentURL(), '/users/blabaere'); + assert.strictEqual(currentURL(), '/users/blabaere'); assert.dom('[data-test-heading] [data-test-username]').hasText('blabaere'); }); @@ -166,7 +166,7 @@ module('Acceptance | crate page', function (hooks) { await visit('/crates/nanomsg'); await click('[data-test-owners] [data-test-owner-link="github:org:thehydroimpulse"]'); - assert.equal(currentURL(), '/teams/github:org:thehydroimpulse'); + assert.strictEqual(currentURL(), '/teams/github:org:thehydroimpulse'); assert.dom('[data-test-heading] [data-test-team-name]').hasText('thehydroimpulseteam'); }); @@ -248,6 +248,6 @@ module('Acceptance | crate page', function (hooks) { await visit('/crates/nanomsg'); await click('[data-test-settings-tab] a'); - assert.equal(currentURL(), '/crates/nanomsg/settings'); + assert.strictEqual(currentURL(), '/crates/nanomsg/settings'); }); }); diff --git a/tests/acceptance/crates-test.js b/tests/acceptance/crates-test.js index 8ebd55614b8..7ae4758e7b1 100644 --- a/tests/acceptance/crates-test.js +++ b/tests/acceptance/crates-test.js @@ -21,8 +21,8 @@ module('Acceptance | crates page', function (hooks) { await visit('/'); await click('[data-test-all-crates-link]'); - assert.equal(currentURL(), '/crates'); - assert.equal(getPageTitle(), 'Crates - crates.io: Rust Package Registry'); + assert.strictEqual(currentURL(), '/crates'); + assert.strictEqual(getPageTitle(), 'Crates - crates.io: Rust Package Registry'); await percySnapshot(assert); await a11yAudit(axeConfig); @@ -34,8 +34,8 @@ module('Acceptance | crates page', function (hooks) { await visit('/crates'); await click('[data-test-all-crates-link]'); - assert.equal(currentURL(), '/crates'); - assert.equal(getPageTitle(), 'Crates - crates.io: Rust Package Registry'); + assert.strictEqual(currentURL(), '/crates'); + assert.strictEqual(getPageTitle(), 'Crates - crates.io: Rust Package Registry'); }); test('listing crates', async function (assert) { @@ -61,7 +61,7 @@ module('Acceptance | crates page', function (hooks) { await visit('/crates'); await click('[data-test-pagination-next]'); - assert.equal(currentURL(), '/crates?page=2'); + assert.strictEqual(currentURL(), '/crates?page=2'); assert.dom('[data-test-crates-nav] [data-test-current-rows]').hasText(`${page_start}-${total}`); assert.dom('[data-test-crates-nav] [data-test-total-rows]').hasText(`${total}`); }); diff --git a/tests/acceptance/dashboard-test.js b/tests/acceptance/dashboard-test.js index 45eefd84242..8b3f628527a 100644 --- a/tests/acceptance/dashboard-test.js +++ b/tests/acceptance/dashboard-test.js @@ -12,7 +12,7 @@ module('Acceptance | Dashboard', function (hooks) { test('shows "page requires authentication" error when not logged in', async function (assert) { await visit('/dashboard'); - assert.equal(currentURL(), '/dashboard'); + assert.strictEqual(currentURL(), '/dashboard'); assert.dom('[data-test-title]').hasText('This page requires authentication'); assert.dom('[data-test-login]').exists(); }); @@ -55,7 +55,7 @@ module('Acceptance | Dashboard', function (hooks) { this.server.get(`/api/v1/users/${user.id}/stats`, { total_downloads: 3892 }); await visit('/dashboard'); - assert.equal(currentURL(), '/dashboard'); + assert.strictEqual(currentURL(), '/dashboard'); await percySnapshot(assert); }); }); diff --git a/tests/acceptance/email-change-test.js b/tests/acceptance/email-change-test.js index a7bf2949bb8..60431801f16 100644 --- a/tests/acceptance/email-change-test.js +++ b/tests/acceptance/email-change-test.js @@ -14,7 +14,7 @@ module('Acceptance | Email Change', function (hooks) { this.authenticateAs(user); await visit('/settings/profile'); - assert.equal(currentURL(), '/settings/profile'); + assert.strictEqual(currentURL(), '/settings/profile'); assert.dom('[data-test-email-input]').exists(); assert.dom('[data-test-email-input] [data-test-no-email]').doesNotExist(); assert.dom('[data-test-email-input] [data-test-email-address]').includesText('old@email.com'); @@ -55,7 +55,7 @@ module('Acceptance | Email Change', function (hooks) { this.authenticateAs(user); await visit('/settings/profile'); - assert.equal(currentURL(), '/settings/profile'); + assert.strictEqual(currentURL(), '/settings/profile'); assert.dom('[data-test-email-input]').exists(); assert.dom('[data-test-email-input] [data-test-no-email]').exists(); assert.dom('[data-test-email-input] [data-test-email-address]').hasText(''); @@ -139,7 +139,7 @@ module('Acceptance | Email Change', function (hooks) { this.authenticateAs(user); await visit('/settings/profile'); - assert.equal(currentURL(), '/settings/profile'); + assert.strictEqual(currentURL(), '/settings/profile'); assert.dom('[data-test-email-input]').exists(); assert.dom('[data-test-email-input] [data-test-email-address]').includesText('john@doe.com'); assert.dom('[data-test-email-input] [data-test-verified]').doesNotExist(); @@ -159,7 +159,7 @@ module('Acceptance | Email Change', function (hooks) { this.server.put('/api/v1/users/:user_id/resend', {}, 500); await visit('/settings/profile'); - assert.equal(currentURL(), '/settings/profile'); + assert.strictEqual(currentURL(), '/settings/profile'); assert.dom('[data-test-email-input]').exists(); assert.dom('[data-test-email-input] [data-test-email-address]').includesText('john@doe.com'); assert.dom('[data-test-email-input] [data-test-verified]').doesNotExist(); diff --git a/tests/acceptance/email-confirmation-test.js b/tests/acceptance/email-confirmation-test.js index 4014e03e0bd..874f279c4a7 100644 --- a/tests/acceptance/email-confirmation-test.js +++ b/tests/acceptance/email-confirmation-test.js @@ -13,7 +13,7 @@ module('Acceptance | Email Confirmation', function (hooks) { assert.false(user.emailVerified); await visit('/confirm/badc0ffee'); - assert.equal(currentURL(), '/'); + assert.strictEqual(currentURL(), '/'); assert.dom('[data-test-notification-message="success"]').exists(); user.reload(); @@ -27,7 +27,7 @@ module('Acceptance | Email Confirmation', function (hooks) { this.authenticateAs(user); await visit('/confirm/badc0ffee'); - assert.equal(currentURL(), '/'); + assert.strictEqual(currentURL(), '/'); assert.dom('[data-test-notification-message="success"]').exists(); let { currentUser } = this.owner.lookup('service:session'); @@ -39,7 +39,7 @@ module('Acceptance | Email Confirmation', function (hooks) { test('error case', async function (assert) { await visit('/confirm/badc0ffee'); - assert.equal(currentURL(), '/'); + assert.strictEqual(currentURL(), '/'); assert.dom('[data-test-notification-message]').hasText('Unknown error in email confirmation'); }); }); diff --git a/tests/acceptance/front-page-test.js b/tests/acceptance/front-page-test.js index 95d14339ff1..a67c7a8b117 100644 --- a/tests/acceptance/front-page-test.js +++ b/tests/acceptance/front-page-test.js @@ -22,8 +22,8 @@ module('Acceptance | front page', function (hooks) { await visit('/'); - assert.equal(currentURL(), '/'); - assert.equal(getPageTitle(), 'crates.io: Rust Package Registry'); + assert.strictEqual(currentURL(), '/'); + assert.strictEqual(getPageTitle(), 'crates.io: Rust Package Registry'); assert.dom('[data-test-install-cargo-link]').exists(); assert.dom('[data-test-all-crates-link]').exists(); diff --git a/tests/acceptance/invites-test.js b/tests/acceptance/invites-test.js index ed41fefba6c..e68118edbba 100644 --- a/tests/acceptance/invites-test.js +++ b/tests/acceptance/invites-test.js @@ -42,7 +42,7 @@ module('Acceptance | /me/pending-invites', function (hooks) { test('shows "page requires authentication" error when not logged in', async function (assert) { await visit('/me/pending-invites'); - assert.equal(currentURL(), '/me/pending-invites'); + assert.strictEqual(currentURL(), '/me/pending-invites'); assert.dom('[data-test-title]').hasText('This page requires authentication'); assert.dom('[data-test-login]').exists(); }); @@ -51,7 +51,7 @@ module('Acceptance | /me/pending-invites', function (hooks) { prepare(this); await visit('/me/pending-invites'); - assert.equal(currentURL(), '/me/pending-invites'); + assert.strictEqual(currentURL(), '/me/pending-invites'); assert.dom('[data-test-invite]').exists({ count: 2 }); assert.dom('[data-test-invite="nanomsg"]').exists(); assert.dom('[data-test-invite="nanomsg"] [data-test-date]').hasText('11 months ago'); @@ -76,7 +76,7 @@ module('Acceptance | /me/pending-invites', function (hooks) { this.server.schema.crateOwnerInvitations.all().destroy(); await visit('/me/pending-invites'); - assert.equal(currentURL(), '/me/pending-invites'); + assert.strictEqual(currentURL(), '/me/pending-invites'); assert.dom('[data-test-invite]').doesNotExist(); assert.dom('[data-test-empty-state]').exists(); }); @@ -85,11 +85,11 @@ module('Acceptance | /me/pending-invites', function (hooks) { let { nanomsg, user } = prepare(this); let { crateOwnerInvitations, crateOwnerships } = this.server.schema; - assert.equal(crateOwnerInvitations.where({ crateId: nanomsg.id, inviteeId: user.id }).length, 1); - assert.equal(crateOwnerships.where({ crateId: nanomsg.id, userId: user.id }).length, 0); + assert.strictEqual(crateOwnerInvitations.where({ crateId: nanomsg.id, inviteeId: user.id }).length, 1); + assert.strictEqual(crateOwnerships.where({ crateId: nanomsg.id, userId: user.id }).length, 0); await visit('/me/pending-invites'); - assert.equal(currentURL(), '/me/pending-invites'); + assert.strictEqual(currentURL(), '/me/pending-invites'); await click('[data-test-invite="nanomsg"] [data-test-decline-button]'); assert.dom('[data-test-error-message]').doesNotExist(); @@ -100,8 +100,8 @@ module('Acceptance | /me/pending-invites', function (hooks) { assert.dom('[data-test-invite="nanomsg"] [data-test-crate-link]').doesNotExist(); assert.dom('[data-test-invite="nanomsg"] [data-test-inviter-link]').doesNotExist(); - assert.equal(crateOwnerInvitations.where({ crateId: nanomsg.id, inviteeId: user.id }).length, 0); - assert.equal(crateOwnerships.where({ crateId: nanomsg.id, userId: user.id }).length, 0); + assert.strictEqual(crateOwnerInvitations.where({ crateId: nanomsg.id, inviteeId: user.id }).length, 0); + assert.strictEqual(crateOwnerships.where({ crateId: nanomsg.id, userId: user.id }).length, 0); }); test('error message is shown if decline request fails', async function (assert) { @@ -110,7 +110,7 @@ module('Acceptance | /me/pending-invites', function (hooks) { this.server.put('/api/v1/me/crate_owner_invitations/:crate_id', () => new Response(500)); await visit('/me/pending-invites'); - assert.equal(currentURL(), '/me/pending-invites'); + assert.strictEqual(currentURL(), '/me/pending-invites'); await click('[data-test-invite="nanomsg"] [data-test-decline-button]'); assert.dom('[data-test-notification-message="error"]').containsText('Error in declining invite'); @@ -122,11 +122,11 @@ module('Acceptance | /me/pending-invites', function (hooks) { let { nanomsg, user } = prepare(this); let { crateOwnerInvitations, crateOwnerships } = this.server.schema; - assert.equal(crateOwnerInvitations.where({ crateId: nanomsg.id, inviteeId: user.id }).length, 1); - assert.equal(crateOwnerships.where({ crateId: nanomsg.id, userId: user.id }).length, 0); + assert.strictEqual(crateOwnerInvitations.where({ crateId: nanomsg.id, inviteeId: user.id }).length, 1); + assert.strictEqual(crateOwnerships.where({ crateId: nanomsg.id, userId: user.id }).length, 0); await visit('/me/pending-invites'); - assert.equal(currentURL(), '/me/pending-invites'); + assert.strictEqual(currentURL(), '/me/pending-invites'); await click('[data-test-invite="nanomsg"] [data-test-accept-button]'); assert.dom('[data-test-error-message]').doesNotExist(); @@ -139,8 +139,8 @@ module('Acceptance | /me/pending-invites', function (hooks) { await percySnapshot(assert); - assert.equal(crateOwnerInvitations.where({ crateId: nanomsg.id, inviteeId: user.id }).length, 0); - assert.equal(crateOwnerships.where({ crateId: nanomsg.id, userId: user.id }).length, 1); + assert.strictEqual(crateOwnerInvitations.where({ crateId: nanomsg.id, inviteeId: user.id }).length, 0); + assert.strictEqual(crateOwnerships.where({ crateId: nanomsg.id, userId: user.id }).length, 1); }); test('error message is shown if accept request fails', async function (assert) { @@ -149,7 +149,7 @@ module('Acceptance | /me/pending-invites', function (hooks) { this.server.put('/api/v1/me/crate_owner_invitations/:crate_id', () => new Response(500)); await visit('/me/pending-invites'); - assert.equal(currentURL(), '/me/pending-invites'); + assert.strictEqual(currentURL(), '/me/pending-invites'); await click('[data-test-invite="nanomsg"] [data-test-accept-button]'); assert.dom('[data-test-notification-message="error"]').hasText('Error in accepting invite'); @@ -166,7 +166,7 @@ module('Acceptance | /me/pending-invites', function (hooks) { this.server.put('/api/v1/me/crate_owner_invitations/:crate_id', payload, 410); await visit('/me/pending-invites'); - assert.equal(currentURL(), '/me/pending-invites'); + assert.strictEqual(currentURL(), '/me/pending-invites'); await click('[data-test-invite="nanomsg"] [data-test-accept-button]'); assert.dom('[data-test-notification-message="error"]').hasText('Error in accepting invite: ' + errorMessage); diff --git a/tests/acceptance/login-test.js b/tests/acceptance/login-test.js index 01b92c63260..0d35f2ce9bf 100644 --- a/tests/acceptance/login-test.js +++ b/tests/acceptance/login-test.js @@ -16,9 +16,12 @@ module('Acceptance | Login', function (hooks) { let deferred = defer(); window.open = (url, target, features) => { - assert.equal(url, ''); - assert.equal(target, '_blank'); - assert.equal(features, 'width=1000,height=450,toolbar=0,scrollbars=1,status=1,resizable=1,location=1,menuBar=0'); + assert.strictEqual(url, ''); + assert.strictEqual(target, '_blank'); + assert.strictEqual( + features, + 'width=1000,height=450,toolbar=0,scrollbars=1,status=1,resizable=1,location=1,menuBar=0', + ); deferred.resolve(); return { document: { write() {}, close() {} }, close() {} }; }; @@ -49,10 +52,10 @@ module('Acceptance | Login', function (hooks) { })); await visit('/'); - assert.equal(currentURL(), '/'); + assert.strictEqual(currentURL(), '/'); await click('[data-test-login-button]'); - assert.equal(currentURL(), '/'); + assert.strictEqual(currentURL(), '/'); // wait for `window.open()` to be called await deferred.promise; @@ -81,10 +84,10 @@ module('Acceptance | Login', function (hooks) { this.server.get('/api/private/session/authorize', payload, 403); await visit('/'); - assert.equal(currentURL(), '/'); + assert.strictEqual(currentURL(), '/'); await click('[data-test-login-button]'); - assert.equal(currentURL(), '/'); + assert.strictEqual(currentURL(), '/'); // wait for `window.open()` to be called await deferred.promise; diff --git a/tests/acceptance/logout-test.js b/tests/acceptance/logout-test.js index 0c604c7ddc2..19e575ada5d 100644 --- a/tests/acceptance/logout-test.js +++ b/tests/acceptance/logout-test.js @@ -15,12 +15,12 @@ module('Acceptance | Logout', function (hooks) { this.authenticateAs(user); await visit('/crates'); - assert.equal(currentURL(), '/crates'); + assert.strictEqual(currentURL(), '/crates'); assert.dom('[data-test-user-menu] [data-test-toggle]').hasText('John Doe'); await click('[data-test-user-menu] [data-test-toggle]'); await click('[data-test-user-menu] [data-test-logout-button]'); - assert.equal(window.location.pathname, '/'); + assert.strictEqual(window.location.pathname, '/'); }); }); diff --git a/tests/acceptance/reverse-dependencies-test.js b/tests/acceptance/reverse-dependencies-test.js index 3ad67c8d75e..1c20042198f 100644 --- a/tests/acceptance/reverse-dependencies-test.js +++ b/tests/acceptance/reverse-dependencies-test.js @@ -28,7 +28,7 @@ module('Acceptance | /crates/:crate_id/reverse_dependencies', function (hooks) { let { foo, bar, baz } = prepare(this); await visit(`/crates/${foo.name}/reverse_dependencies`); - assert.equal(currentURL(), `/crates/${foo.name}/reverse_dependencies`); + assert.strictEqual(currentURL(), `/crates/${foo.name}/reverse_dependencies`); assert.dom('[data-test-row]').exists({ count: 2 }); assert.dom('[data-test-row="0"] [data-test-crate-name]').hasText(bar.name); assert.dom('[data-test-row="0"] [data-test-description]').hasText(bar.description); @@ -46,19 +46,19 @@ module('Acceptance | /crates/:crate_id/reverse_dependencies', function (hooks) { } await visit(`/crates/${foo.name}/reverse_dependencies`); - assert.equal(currentURL(), `/crates/${foo.name}/reverse_dependencies`); + assert.strictEqual(currentURL(), `/crates/${foo.name}/reverse_dependencies`); assert.dom('[data-test-row]').exists({ count: 10 }); assert.dom('[data-test-current-rows]').hasText('1-10'); assert.dom('[data-test-total-rows]').hasText('22'); await click('[data-test-pagination-next]'); - assert.equal(currentURL(), `/crates/${foo.name}/reverse_dependencies?page=2`); + assert.strictEqual(currentURL(), `/crates/${foo.name}/reverse_dependencies?page=2`); assert.dom('[data-test-row]').exists({ count: 10 }); assert.dom('[data-test-current-rows]').hasText('11-20'); assert.dom('[data-test-total-rows]').hasText('22'); await click('[data-test-pagination-next]'); - assert.equal(currentURL(), `/crates/${foo.name}/reverse_dependencies?page=3`); + assert.strictEqual(currentURL(), `/crates/${foo.name}/reverse_dependencies?page=3`); assert.dom('[data-test-row]').exists({ count: 2 }); assert.dom('[data-test-current-rows]').hasText('21-22'); assert.dom('[data-test-total-rows]').hasText('22'); @@ -70,7 +70,7 @@ module('Acceptance | /crates/:crate_id/reverse_dependencies', function (hooks) { this.server.get('/api/v1/crates/:crate_id/reverse_dependencies', {}, 500); await visit(`/crates/${foo.name}/reverse_dependencies`); - assert.equal(currentURL(), '/'); + assert.strictEqual(currentURL(), '/'); assert .dom('[data-test-notification-message="error"]') .hasText('Could not load reverse dependencies for the "foo" crate'); @@ -83,7 +83,7 @@ module('Acceptance | /crates/:crate_id/reverse_dependencies', function (hooks) { this.server.get('/api/v1/crates/:crate_id/reverse_dependencies', payload, 400); await visit(`/crates/${foo.name}/reverse_dependencies`); - assert.equal(currentURL(), '/'); + assert.strictEqual(currentURL(), '/'); assert .dom('[data-test-notification-message="error"]') .hasText('Could not load reverse dependencies for the "foo" crate: cannot request more than 100 items'); diff --git a/tests/acceptance/search-test.js b/tests/acceptance/search-test.js index 3405c2db257..660fdca6c04 100644 --- a/tests/acceptance/search-test.js +++ b/tests/acceptance/search-test.js @@ -23,8 +23,8 @@ module('Acceptance | search', function (hooks) { await fillIn('[data-test-search-input]', 'rust'); await triggerEvent('[data-test-search-form]', 'submit'); - assert.equal(currentURL(), '/search?q=rust'); - assert.equal(getPageTitle(), "Search Results for 'rust' - crates.io: Rust Package Registry"); + assert.strictEqual(currentURL(), '/search?q=rust'); + assert.strictEqual(getPageTitle(), "Search Results for 'rust' - crates.io: Rust Package Registry"); assert.dom('[data-test-header]').hasText("Search Results for 'rust'"); assert.dom('[data-test-search-nav]').hasText('Displaying 1-7 of 7 total results'); @@ -49,8 +49,8 @@ module('Acceptance | search', function (hooks) { await visit('/search?q=rust'); - assert.equal(currentURL(), '/search?q=rust'); - assert.equal(getPageTitle(), "Search Results for 'rust' - crates.io: Rust Package Registry"); + assert.strictEqual(currentURL(), '/search?q=rust'); + assert.strictEqual(getPageTitle(), "Search Results for 'rust' - crates.io: Rust Package Registry"); assert.dom('[data-test-search-input]').hasValue('rust'); assert.dom('[data-test-header]').hasText("Search Results for 'rust'"); @@ -62,12 +62,12 @@ module('Acceptance | search', function (hooks) { await visit('/search?q=rust'); - assert.equal(currentURL(), '/search?q=rust'); + assert.strictEqual(currentURL(), '/search?q=rust'); assert.dom('[data-test-search-input]').hasValue('rust'); await visit('/'); - assert.equal(currentURL(), '/'); + assert.strictEqual(currentURL(), '/'); assert.dom('[data-test-search-input]').hasValue(''); }); @@ -235,8 +235,8 @@ module('Acceptance | search', function (hooks) { await visit('/search'); - assert.equal(currentURL(), '/search'); - assert.equal(getPageTitle(), 'Search Results - crates.io: Rust Package Registry'); + assert.strictEqual(currentURL(), '/search'); + assert.strictEqual(getPageTitle(), 'Search Results - crates.io: Rust Package Registry'); assert.dom('[data-test-header]').hasText('Search Results'); assert.dom('[data-test-search-nav]').hasText('Displaying 1-10 of 23 total results'); diff --git a/tests/acceptance/settings/settings-test.js b/tests/acceptance/settings/settings-test.js index 2b681dd37f8..02769cdf784 100644 --- a/tests/acceptance/settings/settings-test.js +++ b/tests/acceptance/settings/settings-test.js @@ -35,7 +35,7 @@ module('Acceptance | Settings', function (hooks) { prepare(this); await visit('/crates/nanomsg/settings'); - assert.equal(currentURL(), '/crates/nanomsg/settings'); + assert.strictEqual(currentURL(), '/crates/nanomsg/settings'); assert.dom('[data-test-owners] [data-test-owner-team]').exists({ count: 2 }); assert.dom('[data-test-owners] [data-test-owner-user]').exists({ count: 2 }); @@ -52,6 +52,6 @@ module('Acceptance | Settings', function (hooks) { prepare(this); await visit('/crates/nanomsg/owners'); - assert.equal(currentURL(), '/crates/nanomsg/settings'); + assert.strictEqual(currentURL(), '/crates/nanomsg/settings'); }); }); diff --git a/tests/acceptance/token-invites-test.js b/tests/acceptance/token-invites-test.js index 04c8379189a..665a56cf18a 100644 --- a/tests/acceptance/token-invites-test.js +++ b/tests/acceptance/token-invites-test.js @@ -12,21 +12,21 @@ module('Acceptance | /accept-invite/:token', function (hooks) { test('visiting to /accept-invite shows 404 page', async function (assert) { await visit('/accept-invite'); - assert.equal(currentURL(), '/accept-invite'); + assert.strictEqual(currentURL(), '/accept-invite'); assert.dom('[data-test-404-page]').exists(); assert.dom('[data-test-title]').hasText('Page not found'); }); test('visiting to /accept-invite/ shows 404 page', async function (assert) { await visit('/accept-invite/'); - assert.equal(currentURL(), '/accept-invite/'); + assert.strictEqual(currentURL(), '/accept-invite/'); assert.dom('[data-test-404-page]').exists(); assert.dom('[data-test-title]').hasText('Page not found'); }); test('shows error for unknown token', async function (assert) { await visit('/accept-invite/unknown'); - assert.equal(currentURL(), '/accept-invite/unknown'); + assert.strictEqual(currentURL(), '/accept-invite/unknown'); assert.dom('[data-test-error-message]').hasText('You may want to visit crates.io/me/pending-invites to try again.'); }); @@ -37,7 +37,7 @@ module('Acceptance | /accept-invite/:token', function (hooks) { this.server.put('/api/v1/me/crate_owner_invitations/accept/:token', payload, 410); await visit('/accept-invite/secret123'); - assert.equal(currentURL(), '/accept-invite/secret123'); + assert.strictEqual(currentURL(), '/accept-invite/secret123'); assert.dom('[data-test-error-message]').hasText(errorMessage); }); @@ -50,7 +50,7 @@ module('Acceptance | /accept-invite/:token', function (hooks) { let invite = this.server.create('crate-owner-invitation', { crate, invitee, inviter }); await visit(`/accept-invite/${invite.token}`); - assert.equal(currentURL(), `/accept-invite/${invite.token}`); + assert.strictEqual(currentURL(), `/accept-invite/${invite.token}`); assert .dom('[data-test-success-message]') .hasText( diff --git a/tests/acceptance/versions-test.js b/tests/acceptance/versions-test.js index b33a856c48e..876f7f19d6a 100644 --- a/tests/acceptance/versions-test.js +++ b/tests/acceptance/versions-test.js @@ -14,7 +14,7 @@ module('Acceptance | crate versions page', function (hooks) { this.server.create('version', { crate, num: '0.2.1', created_at: '2020-01-01' }); await visit('/crates/nanomsg/versions'); - assert.equal(currentURL(), '/crates/nanomsg/versions'); + assert.strictEqual(currentURL(), '/crates/nanomsg/versions'); let versions = findAll('[data-test-version]').map(it => it.dataset.testVersion); assert.deepEqual(versions, ['0.2.1', '0.3.0', '0.2.0', '0.1.0']); diff --git a/tests/adapters/crate-test.js b/tests/adapters/crate-test.js index e8a599e31b0..1000540b29b 100644 --- a/tests/adapters/crate-test.js +++ b/tests/adapters/crate-test.js @@ -21,7 +21,7 @@ module('Adapter | crate', function (hooks) { let store = this.owner.lookup('service:store'); let [foo, bar] = await Promise.all([store.findRecord('crate', 'foo'), store.findRecord('crate', 'bar')]); - assert.equal(foo?.name, 'foo'); - assert.equal(bar?.name, 'bar'); + assert.strictEqual(foo?.name, 'foo'); + assert.strictEqual(bar?.name, 'bar'); }); }); diff --git a/tests/bugs/2329-test.js b/tests/bugs/2329-test.js index 28c8539f2aa..e62b04977b5 100644 --- a/tests/bugs/2329-test.js +++ b/tests/bugs/2329-test.js @@ -57,7 +57,7 @@ module('Bug #2329', function (hooks) { await click('[data-test-user-menu]'); await click('[data-test-me-link]'); await visit('/settings/email-notifications'); - assert.equal(currentURL(), '/settings/email-notifications'); + assert.strictEqual(currentURL(), '/settings/email-notifications'); // 7. Observe that there are no crates listed under "Email Notification Preferences". // Observe that no request was sent to the /api/v1/me endpoint to obtain this data. diff --git a/tests/mirage/categories/get-by-id-test.js b/tests/mirage/categories/get-by-id-test.js index 959fb1eaf75..04f4dfcbac9 100644 --- a/tests/mirage/categories/get-by-id-test.js +++ b/tests/mirage/categories/get-by-id-test.js @@ -11,7 +11,7 @@ module('Mirage | GET /api/v1/categories/:id', function (hooks) { test('returns 404 for unknown categories', async function (assert) { let response = await fetch('/api/v1/categories/foo'); - assert.equal(response.status, 404); + assert.strictEqual(response.status, 404); assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] }); }); @@ -22,7 +22,7 @@ module('Mirage | GET /api/v1/categories/:id', function (hooks) { }); let response = await fetch('/api/v1/categories/no-std'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { category: { id: 'no-std', @@ -42,7 +42,7 @@ module('Mirage | GET /api/v1/categories/:id', function (hooks) { this.server.createList('crate', 3, { categoryIds: ['not-cli'] }); let response = await fetch('/api/v1/categories/cli'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { category: { category: 'cli', diff --git a/tests/mirage/categories/list-test.js b/tests/mirage/categories/list-test.js index b87d3907267..d19a6bf057c 100644 --- a/tests/mirage/categories/list-test.js +++ b/tests/mirage/categories/list-test.js @@ -11,7 +11,7 @@ module('Mirage | GET /api/v1/categories', function (hooks) { test('empty case', async function (assert) { let response = await fetch('/api/v1/categories'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { categories: [], meta: { @@ -28,7 +28,7 @@ module('Mirage | GET /api/v1/categories', function (hooks) { this.server.createList('category', 2); let response = await fetch('/api/v1/categories'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { categories: [ { @@ -66,11 +66,11 @@ module('Mirage | GET /api/v1/categories', function (hooks) { this.server.createList('category', 25); let response = await fetch('/api/v1/categories'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let responsePayload = await response.json(); - assert.equal(responsePayload.categories.length, 10); - assert.equal(responsePayload.meta.total, 25); + assert.strictEqual(responsePayload.categories.length, 10); + assert.strictEqual(responsePayload.meta.total, 25); }); test('supports `page` and `per_page` parameters', async function (assert) { @@ -79,14 +79,14 @@ module('Mirage | GET /api/v1/categories', function (hooks) { }); let response = await fetch('/api/v1/categories?page=2&per_page=5'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let responsePayload = await response.json(); - assert.equal(responsePayload.categories.length, 5); + assert.strictEqual(responsePayload.categories.length, 5); assert.deepEqual( responsePayload.categories.map(it => it.id), ['cat-06', 'cat-07', 'cat-08', 'cat-09', 'cat-10'], ); - assert.equal(responsePayload.meta.total, 25); + assert.strictEqual(responsePayload.meta.total, 25); }); }); diff --git a/tests/mirage/category-slugs/list-test.js b/tests/mirage/category-slugs/list-test.js index cd76c34e2da..573ecb105cc 100644 --- a/tests/mirage/category-slugs/list-test.js +++ b/tests/mirage/category-slugs/list-test.js @@ -11,7 +11,7 @@ module('Mirage | GET /api/v1/category_slugs', function (hooks) { test('empty case', async function (assert) { let response = await fetch('/api/v1/category_slugs'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { category_slugs: [], }); @@ -25,7 +25,7 @@ module('Mirage | GET /api/v1/category_slugs', function (hooks) { this.server.createList('category', 2); let response = await fetch('/api/v1/category_slugs'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { category_slugs: [ { @@ -51,7 +51,7 @@ module('Mirage | GET /api/v1/category_slugs', function (hooks) { this.server.createList('category', 25); let response = await fetch('/api/v1/category_slugs'); - assert.equal(response.status, 200); - assert.equal((await response.json()).category_slugs.length, 25); + assert.strictEqual(response.status, 200); + assert.strictEqual((await response.json()).category_slugs.length, 25); }); }); diff --git a/tests/mirage/confirm/put-by-id-test.js b/tests/mirage/confirm/put-by-id-test.js index 2c2efa71129..543b6cd0dad 100644 --- a/tests/mirage/confirm/put-by-id-test.js +++ b/tests/mirage/confirm/put-by-id-test.js @@ -14,7 +14,7 @@ module('Mirage | PUT /api/v1/confirm/:token', function (hooks) { assert.false(user.emailVerified); let response = await fetch('/api/v1/confirm/foo', { method: 'PUT' }); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { ok: true }); user.reload(); @@ -28,7 +28,7 @@ module('Mirage | PUT /api/v1/confirm/:token', function (hooks) { this.server.create('mirage-session', { user }); let response = await fetch('/api/v1/confirm/foo', { method: 'PUT' }); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { ok: true }); user.reload(); @@ -37,7 +37,7 @@ module('Mirage | PUT /api/v1/confirm/:token', function (hooks) { test('returns an error for unknown tokens', async function (assert) { let response = await fetch('/api/v1/confirm/unknown', { method: 'PUT' }); - assert.equal(response.status, 400); + assert.strictEqual(response.status, 400); assert.deepEqual(await response.json(), { errors: [{ detail: 'Email belonging to token not found.' }], }); diff --git a/tests/mirage/crates/downloads-test.js b/tests/mirage/crates/downloads-test.js index 75de1660853..be9f46ef23e 100644 --- a/tests/mirage/crates/downloads-test.js +++ b/tests/mirage/crates/downloads-test.js @@ -11,7 +11,7 @@ module('Mirage | GET /api/v1/crates/:id/downloads', function (hooks) { test('returns 404 for unknown crates', async function (assert) { let response = await fetch('/api/v1/crates/foo/downloads'); - assert.equal(response.status, 404); + assert.strictEqual(response.status, 404); assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] }); }); @@ -19,7 +19,7 @@ module('Mirage | GET /api/v1/crates/:id/downloads', function (hooks) { this.server.create('crate', { name: 'rand' }); let response = await fetch('/api/v1/crates/rand/downloads'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { version_downloads: [], meta: { @@ -36,7 +36,7 @@ module('Mirage | GET /api/v1/crates/:id/downloads', function (hooks) { this.server.create('version-download', { version: versions[1], date: '2020-01-15' }); let response = await fetch('/api/v1/crates/rand/downloads'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { version_downloads: [ { diff --git a/tests/mirage/crates/follow/delete-test.js b/tests/mirage/crates/follow/delete-test.js index de4054bb98f..13e7dc02bc4 100644 --- a/tests/mirage/crates/follow/delete-test.js +++ b/tests/mirage/crates/follow/delete-test.js @@ -11,7 +11,7 @@ module('Mirage | DELETE /api/v1/crates/:crateId/follow', function (hooks) { test('returns 403 if unauthenticated', async function (assert) { let response = await fetch('/api/v1/crates/foo/follow', { method: 'DELETE' }); - assert.equal(response.status, 403); + assert.strictEqual(response.status, 403); assert.deepEqual(await response.json(), { errors: [{ detail: 'must be logged in to perform that action' }], }); @@ -22,7 +22,7 @@ module('Mirage | DELETE /api/v1/crates/:crateId/follow', function (hooks) { this.authenticateAs(user); let response = await fetch('/api/v1/crates/foo/follow', { method: 'DELETE' }); - assert.equal(response.status, 404); + assert.strictEqual(response.status, 404); assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] }); }); @@ -35,7 +35,7 @@ module('Mirage | DELETE /api/v1/crates/:crateId/follow', function (hooks) { assert.deepEqual(user.followedCrateIds, [crate.id]); let response = await fetch('/api/v1/crates/rand/follow', { method: 'DELETE' }); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { ok: true }); user.reload(); diff --git a/tests/mirage/crates/follow/get-test.js b/tests/mirage/crates/follow/get-test.js index 921ffe7e306..c0b4cb15a27 100644 --- a/tests/mirage/crates/follow/get-test.js +++ b/tests/mirage/crates/follow/get-test.js @@ -11,7 +11,7 @@ module('Mirage | GET /api/v1/crates/:crateId/following', function (hooks) { test('returns 403 if unauthenticated', async function (assert) { let response = await fetch('/api/v1/crates/foo/following'); - assert.equal(response.status, 403); + assert.strictEqual(response.status, 403); assert.deepEqual(await response.json(), { errors: [{ detail: 'must be logged in to perform that action' }], }); @@ -22,7 +22,7 @@ module('Mirage | GET /api/v1/crates/:crateId/following', function (hooks) { this.authenticateAs(user); let response = await fetch('/api/v1/crates/foo/following'); - assert.equal(response.status, 404); + assert.strictEqual(response.status, 404); assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] }); }); @@ -33,7 +33,7 @@ module('Mirage | GET /api/v1/crates/:crateId/following', function (hooks) { this.authenticateAs(user); let response = await fetch('/api/v1/crates/rand/following'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { following: true }); }); @@ -44,7 +44,7 @@ module('Mirage | GET /api/v1/crates/:crateId/following', function (hooks) { this.authenticateAs(user); let response = await fetch('/api/v1/crates/rand/following'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { following: false }); }); }); diff --git a/tests/mirage/crates/follow/put-test.js b/tests/mirage/crates/follow/put-test.js index b677fb19af3..f13af61b067 100644 --- a/tests/mirage/crates/follow/put-test.js +++ b/tests/mirage/crates/follow/put-test.js @@ -11,7 +11,7 @@ module('Mirage | PUT /api/v1/crates/:crateId/follow', function (hooks) { test('returns 403 if unauthenticated', async function (assert) { let response = await fetch('/api/v1/crates/foo/follow', { method: 'PUT' }); - assert.equal(response.status, 403); + assert.strictEqual(response.status, 403); assert.deepEqual(await response.json(), { errors: [{ detail: 'must be logged in to perform that action' }], }); @@ -22,7 +22,7 @@ module('Mirage | PUT /api/v1/crates/:crateId/follow', function (hooks) { this.authenticateAs(user); let response = await fetch('/api/v1/crates/foo/follow', { method: 'PUT' }); - assert.equal(response.status, 404); + assert.strictEqual(response.status, 404); assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] }); }); @@ -35,7 +35,7 @@ module('Mirage | PUT /api/v1/crates/:crateId/follow', function (hooks) { assert.deepEqual(user.followedCrateIds, []); let response = await fetch('/api/v1/crates/rand/follow', { method: 'PUT' }); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { ok: true }); user.reload(); diff --git a/tests/mirage/crates/get-by-id-test.js b/tests/mirage/crates/get-by-id-test.js index cd7808d8892..efd095b7fac 100644 --- a/tests/mirage/crates/get-by-id-test.js +++ b/tests/mirage/crates/get-by-id-test.js @@ -11,7 +11,7 @@ module('Mirage | GET /api/v1/crates/:id', function (hooks) { test('returns 404 for unknown crates', async function (assert) { let response = await fetch('/api/v1/crates/foo'); - assert.equal(response.status, 404); + assert.strictEqual(response.status, 404); assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] }); }); @@ -20,7 +20,7 @@ module('Mirage | GET /api/v1/crates/:id', function (hooks) { this.server.create('version', { crate, num: '1.0.0-beta.1' }); let response = await fetch('/api/v1/crates/rand'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { categories: [], crate: { @@ -79,7 +79,7 @@ module('Mirage | GET /api/v1/crates/:id', function (hooks) { this.server.create('version', { crate, num: '1.2.0' }); let response = await fetch('/api/v1/crates/rand'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let responsePayload = await response.json(); assert.deepEqual(responsePayload.crate.versions, ['1', '2', '3']); @@ -148,7 +148,7 @@ module('Mirage | GET /api/v1/crates/:id', function (hooks) { this.server.create('version', { crate }); let response = await fetch('/api/v1/crates/rand'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let responsePayload = await response.json(); assert.deepEqual(responsePayload.crate.categories, ['no-std']); @@ -171,7 +171,7 @@ module('Mirage | GET /api/v1/crates/:id', function (hooks) { this.server.create('version', { crate }); let response = await fetch('/api/v1/crates/rand'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let responsePayload = await response.json(); assert.deepEqual(responsePayload.crate.keywords, ['no-std']); diff --git a/tests/mirage/crates/list-test.js b/tests/mirage/crates/list-test.js index 513fb894719..6c1e7ec7bde 100644 --- a/tests/mirage/crates/list-test.js +++ b/tests/mirage/crates/list-test.js @@ -11,7 +11,7 @@ module('Mirage | GET /api/v1/crates', function (hooks) { test('empty case', async function (assert) { let response = await fetch('/api/v1/crates'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { crates: [], meta: { @@ -36,7 +36,7 @@ module('Mirage | GET /api/v1/crates', function (hooks) { }); let response = await fetch('/api/v1/crates'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { crates: [ { @@ -76,11 +76,11 @@ module('Mirage | GET /api/v1/crates', function (hooks) { this.server.createList('version', crates.length, { crate: i => crates[i] }); let response = await fetch('/api/v1/crates'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let responsePayload = await response.json(); - assert.equal(responsePayload.crates.length, 10); - assert.equal(responsePayload.meta.total, 25); + assert.strictEqual(responsePayload.crates.length, 10); + assert.strictEqual(responsePayload.meta.total, 25); }); test('supports `page` and `per_page` parameters', async function (assert) { @@ -90,15 +90,15 @@ module('Mirage | GET /api/v1/crates', function (hooks) { this.server.createList('version', crates.length, { crate: i => crates[i] }); let response = await fetch('/api/v1/crates?page=2&per_page=5'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let responsePayload = await response.json(); - assert.equal(responsePayload.crates.length, 5); + assert.strictEqual(responsePayload.crates.length, 5); assert.deepEqual( responsePayload.crates.map(it => it.id), ['crate-06', 'crate-07', 'crate-08', 'crate-09', 'crate-10'], ); - assert.equal(responsePayload.meta.total, 25); + assert.strictEqual(responsePayload.meta.total, 25); }); test('supports a `letter` parameter', async function (assert) { @@ -110,15 +110,15 @@ module('Mirage | GET /api/v1/crates', function (hooks) { this.server.create('version', { crate: baz }); let response = await fetch('/api/v1/crates?letter=b'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let responsePayload = await response.json(); - assert.equal(responsePayload.crates.length, 2); + assert.strictEqual(responsePayload.crates.length, 2); assert.deepEqual( responsePayload.crates.map(it => it.id), ['bar', 'BAZ'], ); - assert.equal(responsePayload.meta.total, 2); + assert.strictEqual(responsePayload.meta.total, 2); }); test('supports a `q` parameter', async function (assert) { @@ -130,15 +130,15 @@ module('Mirage | GET /api/v1/crates', function (hooks) { this.server.create('version', { crate: crate3 }); let response = await fetch('/api/v1/crates?q=123'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let responsePayload = await response.json(); - assert.equal(responsePayload.crates.length, 2); + assert.strictEqual(responsePayload.crates.length, 2); assert.deepEqual( responsePayload.crates.map(it => it.id), ['123456', '00123'], ); - assert.equal(responsePayload.meta.total, 2); + assert.strictEqual(responsePayload.meta.total, 2); }); test('supports a `user_id` parameter', async function (assert) { @@ -155,12 +155,12 @@ module('Mirage | GET /api/v1/crates', function (hooks) { this.server.create('version', { crate: baz }); let response = await fetch(`/api/v1/crates?user_id=${user1.id}`); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let responsePayload = await response.json(); - assert.equal(responsePayload.crates.length, 1); - assert.equal(responsePayload.crates[0].id, 'bar'); - assert.equal(responsePayload.meta.total, 1); + assert.strictEqual(responsePayload.crates.length, 1); + assert.strictEqual(responsePayload.crates[0].id, 'bar'); + assert.strictEqual(responsePayload.meta.total, 1); }); test('supports a `team_id` parameter', async function (assert) { @@ -177,12 +177,12 @@ module('Mirage | GET /api/v1/crates', function (hooks) { this.server.create('version', { crate: baz }); let response = await fetch(`/api/v1/crates?team_id=${team1.id}`); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let responsePayload = await response.json(); - assert.equal(responsePayload.crates.length, 1); - assert.equal(responsePayload.crates[0].id, 'bar'); - assert.equal(responsePayload.meta.total, 1); + assert.strictEqual(responsePayload.crates.length, 1); + assert.strictEqual(responsePayload.crates[0].id, 'bar'); + assert.strictEqual(responsePayload.meta.total, 1); }); test('supports a `following` parameter', async function (assert) { @@ -195,12 +195,12 @@ module('Mirage | GET /api/v1/crates', function (hooks) { this.authenticateAs(user); let response = await fetch(`/api/v1/crates?following=1`); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let responsePayload = await response.json(); - assert.equal(responsePayload.crates.length, 1); - assert.equal(responsePayload.crates[0].id, 'bar'); - assert.equal(responsePayload.meta.total, 1); + assert.strictEqual(responsePayload.crates.length, 1); + assert.strictEqual(responsePayload.crates[0].id, 'bar'); + assert.strictEqual(responsePayload.meta.total, 1); }); test('supports multiple `ids[]` parameters', async function (assert) { @@ -214,13 +214,13 @@ module('Mirage | GET /api/v1/crates', function (hooks) { this.server.create('version', { crate: other }); let response = await fetch(`/api/v1/crates?ids[]=foo&ids[]=bar&ids[]=baz&ids[]=baz&ids[]=unknown`); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let responsePayload = await response.json(); - assert.equal(responsePayload.crates.length, 3); - assert.equal(responsePayload.crates[0].id, 'foo'); - assert.equal(responsePayload.crates[1].id, 'bar'); - assert.equal(responsePayload.crates[2].id, 'baz'); - assert.equal(responsePayload.meta.total, 3); + assert.strictEqual(responsePayload.crates.length, 3); + assert.strictEqual(responsePayload.crates[0].id, 'foo'); + assert.strictEqual(responsePayload.crates[1].id, 'bar'); + assert.strictEqual(responsePayload.crates[2].id, 'baz'); + assert.strictEqual(responsePayload.meta.total, 3); }); }); diff --git a/tests/mirage/crates/owner-team-test.js b/tests/mirage/crates/owner-team-test.js index 6df05c4f479..25e9a8e10fe 100644 --- a/tests/mirage/crates/owner-team-test.js +++ b/tests/mirage/crates/owner-team-test.js @@ -11,7 +11,7 @@ module('Mirage | GET /api/v1/crates/:id/owner_team', function (hooks) { test('returns 404 for unknown crates', async function (assert) { let response = await fetch('/api/v1/crates/foo/owner_team'); - assert.equal(response.status, 404); + assert.strictEqual(response.status, 404); assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] }); }); @@ -19,7 +19,7 @@ module('Mirage | GET /api/v1/crates/:id/owner_team', function (hooks) { this.server.create('crate', { name: 'rand' }); let response = await fetch('/api/v1/crates/rand/owner_team'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { teams: [], }); @@ -31,7 +31,7 @@ module('Mirage | GET /api/v1/crates/:id/owner_team', function (hooks) { this.server.create('crate-ownership', { crate, team }); let response = await fetch('/api/v1/crates/rand/owner_team'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { teams: [ { diff --git a/tests/mirage/crates/owner-user-test.js b/tests/mirage/crates/owner-user-test.js index 44d434cc367..43d3b4af95a 100644 --- a/tests/mirage/crates/owner-user-test.js +++ b/tests/mirage/crates/owner-user-test.js @@ -11,7 +11,7 @@ module('Mirage | GET /api/v1/crates/:id/owner_user', function (hooks) { test('returns 404 for unknown crates', async function (assert) { let response = await fetch('/api/v1/crates/foo/owner_user'); - assert.equal(response.status, 404); + assert.strictEqual(response.status, 404); assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] }); }); @@ -19,7 +19,7 @@ module('Mirage | GET /api/v1/crates/:id/owner_user', function (hooks) { this.server.create('crate', { name: 'rand' }); let response = await fetch('/api/v1/crates/rand/owner_user'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { users: [], }); @@ -31,7 +31,7 @@ module('Mirage | GET /api/v1/crates/:id/owner_user', function (hooks) { this.server.create('crate-ownership', { crate, user }); let response = await fetch('/api/v1/crates/rand/owner_user'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { users: [ { diff --git a/tests/mirage/crates/reverse-dependencies-test.js b/tests/mirage/crates/reverse-dependencies-test.js index 42e8aff2e54..9a3909de4b6 100644 --- a/tests/mirage/crates/reverse-dependencies-test.js +++ b/tests/mirage/crates/reverse-dependencies-test.js @@ -11,7 +11,7 @@ module('Mirage | GET /api/v1/crates/:id/reverse_dependencies', function (hooks) test('returns 404 for unknown crates', async function (assert) { let response = await fetch('/api/v1/crates/foo/reverse_dependencies'); - assert.equal(response.status, 404); + assert.strictEqual(response.status, 404); assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] }); }); @@ -19,7 +19,7 @@ module('Mirage | GET /api/v1/crates/:id/reverse_dependencies', function (hooks) this.server.create('crate', { name: 'rand' }); let response = await fetch('/api/v1/crates/rand/reverse_dependencies'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { dependencies: [], versions: [], @@ -47,7 +47,7 @@ module('Mirage | GET /api/v1/crates/:id/reverse_dependencies', function (hooks) }); let response = await fetch('/api/v1/crates/foo/reverse_dependencies'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { dependencies: [ { @@ -129,12 +129,12 @@ module('Mirage | GET /api/v1/crates/:id/reverse_dependencies', function (hooks) }); let response = await fetch('/api/v1/crates/foo/reverse_dependencies'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let responsePayload = await response.json(); - assert.equal(responsePayload.dependencies.length, 10); - assert.equal(responsePayload.versions.length, 10); - assert.equal(responsePayload.meta.total, 25); + assert.strictEqual(responsePayload.dependencies.length, 10); + assert.strictEqual(responsePayload.versions.length, 10); + assert.strictEqual(responsePayload.meta.total, 25); }); test('supports `page` and `per_page` parameters', async function (assert) { @@ -152,15 +152,15 @@ module('Mirage | GET /api/v1/crates/:id/reverse_dependencies', function (hooks) }); let response = await fetch('/api/v1/crates/foo/reverse_dependencies?page=2&per_page=5'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let responsePayload = await response.json(); - assert.equal(responsePayload.dependencies.length, 5); + assert.strictEqual(responsePayload.dependencies.length, 5); assert.deepEqual( responsePayload.versions.map(it => it.crate), // offset by one because we created the `foo` crate first ['crate-07', 'crate-08', 'crate-09', 'crate-10', 'crate-11'], ); - assert.equal(responsePayload.meta.total, 25); + assert.strictEqual(responsePayload.meta.total, 25); }); }); diff --git a/tests/mirage/crates/versions/authors-test.js b/tests/mirage/crates/versions/authors-test.js index f01f72ce514..c9f1f3fba81 100644 --- a/tests/mirage/crates/versions/authors-test.js +++ b/tests/mirage/crates/versions/authors-test.js @@ -11,7 +11,7 @@ module('Mirage | GET /api/v1/crates/:id/:version/authors', function (hooks) { test('returns 404 for unknown crates', async function (assert) { let response = await fetch('/api/v1/crates/foo/1.0.0/authors'); - assert.equal(response.status, 404); + assert.strictEqual(response.status, 404); assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] }); }); @@ -21,7 +21,7 @@ module('Mirage | GET /api/v1/crates/:id/:version/authors', function (hooks) { let response = await fetch('/api/v1/crates/rand/1.0.0/authors'); // we should probably return 404 for this, but the production API // currently doesn't do this either - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { errors: [{ detail: 'crate `rand` does not have a version `1.0.0`' }] }); }); @@ -30,7 +30,7 @@ module('Mirage | GET /api/v1/crates/:id/:version/authors', function (hooks) { this.server.create('version', { crate, num: '1.0.0' }); let response = await fetch('/api/v1/crates/rand/1.0.0/authors'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { meta: { names: [], @@ -44,7 +44,7 @@ module('Mirage | GET /api/v1/crates/:id/:version/authors', function (hooks) { this.server.create('version', { crate, num: '1.0.0' }); let response = await fetch('/api/v1/crates/rand/1.0.0/authors'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { meta: { names: [], diff --git a/tests/mirage/crates/versions/dependencies-test.js b/tests/mirage/crates/versions/dependencies-test.js index 7f4f4f6cc0b..83a03cc69d4 100644 --- a/tests/mirage/crates/versions/dependencies-test.js +++ b/tests/mirage/crates/versions/dependencies-test.js @@ -11,7 +11,7 @@ module('Mirage | GET /api/v1/crates/:id/:version/dependencies', function (hooks) test('returns 404 for unknown crates', async function (assert) { let response = await fetch('/api/v1/crates/foo/1.0.0/dependencies'); - assert.equal(response.status, 404); + assert.strictEqual(response.status, 404); assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] }); }); @@ -21,7 +21,7 @@ module('Mirage | GET /api/v1/crates/:id/:version/dependencies', function (hooks) let response = await fetch('/api/v1/crates/rand/1.0.0/dependencies'); // we should probably return 404 for this, but the production API // currently doesn't do this either - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { errors: [{ detail: 'crate `rand` does not have a version `1.0.0`' }] }); }); @@ -30,7 +30,7 @@ module('Mirage | GET /api/v1/crates/:id/:version/dependencies', function (hooks) this.server.create('version', { crate, num: '1.0.0' }); let response = await fetch('/api/v1/crates/rand/1.0.0/dependencies'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { dependencies: [], }); @@ -48,7 +48,7 @@ module('Mirage | GET /api/v1/crates/:id/:version/dependencies', function (hooks) this.server.create('dependency', { crate: baz, version }); let response = await fetch('/api/v1/crates/rand/1.0.0/dependencies'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { dependencies: [ { diff --git a/tests/mirage/crates/versions/downloads-test.js b/tests/mirage/crates/versions/downloads-test.js index 71961352c3f..09f464905bc 100644 --- a/tests/mirage/crates/versions/downloads-test.js +++ b/tests/mirage/crates/versions/downloads-test.js @@ -11,7 +11,7 @@ module('Mirage | GET /api/v1/crates/:id/:version/downloads', function (hooks) { test('returns 404 for unknown crates', async function (assert) { let response = await fetch('/api/v1/crates/foo/1.0.0/downloads'); - assert.equal(response.status, 404); + assert.strictEqual(response.status, 404); assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] }); }); @@ -21,7 +21,7 @@ module('Mirage | GET /api/v1/crates/:id/:version/downloads', function (hooks) { let response = await fetch('/api/v1/crates/rand/1.0.0/downloads'); // we should probably return 404 for this, but the production API // currently doesn't do this either - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { errors: [{ detail: 'crate `rand` does not have a version `1.0.0`' }] }); }); @@ -30,7 +30,7 @@ module('Mirage | GET /api/v1/crates/:id/:version/downloads', function (hooks) { this.server.create('version', { crate, num: '1.0.0' }); let response = await fetch('/api/v1/crates/rand/1.0.0/downloads'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { version_downloads: [], }); @@ -44,7 +44,7 @@ module('Mirage | GET /api/v1/crates/:id/:version/downloads', function (hooks) { this.server.create('version-download', { version, date: '2020-01-15' }); let response = await fetch('/api/v1/crates/rand/1.0.0/downloads'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { version_downloads: [ { diff --git a/tests/mirage/crates/versions/list-test.js b/tests/mirage/crates/versions/list-test.js index 72c823a2ea8..f1b6388205b 100644 --- a/tests/mirage/crates/versions/list-test.js +++ b/tests/mirage/crates/versions/list-test.js @@ -11,7 +11,7 @@ module('Mirage | GET /api/v1/crates/:id/versions', function (hooks) { test('returns 404 for unknown crates', async function (assert) { let response = await fetch('/api/v1/crates/foo/versions'); - assert.equal(response.status, 404); + assert.strictEqual(response.status, 404); assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] }); }); @@ -19,7 +19,7 @@ module('Mirage | GET /api/v1/crates/:id/versions', function (hooks) { this.server.create('crate', { name: 'rand' }); let response = await fetch('/api/v1/crates/rand/versions'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { versions: [], }); @@ -33,7 +33,7 @@ module('Mirage | GET /api/v1/crates/:id/versions', function (hooks) { this.server.create('version', { crate, num: '1.2.0' }); let response = await fetch('/api/v1/crates/rand/versions'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { versions: [ { diff --git a/tests/mirage/crates/versions/readme-test.js b/tests/mirage/crates/versions/readme-test.js index 457ced8d1f6..606e71a6dc8 100644 --- a/tests/mirage/crates/versions/readme-test.js +++ b/tests/mirage/crates/versions/readme-test.js @@ -11,16 +11,16 @@ module('Mirage | GET /api/v1/crates/:id/:version/readme', function (hooks) { test('returns 404 for unknown crates', async function (assert) { let response = await fetch('/api/v1/crates/foo/1.0.0/readme'); - assert.equal(response.status, 404); - assert.equal(await response.text(), ''); + assert.strictEqual(response.status, 404); + assert.strictEqual(await response.text(), ''); }); test('returns 404 for unknown versions', async function (assert) { this.server.create('crate', { name: 'rand' }); let response = await fetch('/api/v1/crates/rand/1.0.0/readme'); - assert.equal(response.status, 404); - assert.equal(await response.text(), ''); + assert.strictEqual(response.status, 404); + assert.strictEqual(await response.text(), ''); }); test('returns 404 for versions without README', async function (assert) { @@ -28,8 +28,8 @@ module('Mirage | GET /api/v1/crates/:id/:version/readme', function (hooks) { this.server.create('version', { crate, num: '1.0.0' }); let response = await fetch('/api/v1/crates/rand/1.0.0/readme'); - assert.equal(response.status, 404); - assert.equal(await response.text(), ''); + assert.strictEqual(response.status, 404); + assert.strictEqual(await response.text(), ''); }); test('returns the README as raw HTML', async function (assert) { @@ -39,7 +39,7 @@ module('Mirage | GET /api/v1/crates/:id/:version/readme', function (hooks) { this.server.create('version', { crate, num: '1.0.0', readme: readme }); let response = await fetch('/api/v1/crates/rand/1.0.0/readme'); - assert.equal(response.status, 200); - assert.equal(await response.text(), readme); + assert.strictEqual(response.status, 200); + assert.strictEqual(await response.text(), readme); }); }); diff --git a/tests/mirage/keywords/get-by-id-test.js b/tests/mirage/keywords/get-by-id-test.js index 4971499f6a8..751cc873dc5 100644 --- a/tests/mirage/keywords/get-by-id-test.js +++ b/tests/mirage/keywords/get-by-id-test.js @@ -11,7 +11,7 @@ module('Mirage | GET /api/v1/keywords/:id', function (hooks) { test('returns 404 for unknown keywords', async function (assert) { let response = await fetch('/api/v1/keywords/foo'); - assert.equal(response.status, 404); + assert.strictEqual(response.status, 404); assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] }); }); @@ -19,7 +19,7 @@ module('Mirage | GET /api/v1/keywords/:id', function (hooks) { this.server.create('keyword', { keyword: 'cli' }); let response = await fetch('/api/v1/keywords/cli'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { keyword: { id: 'cli', @@ -36,7 +36,7 @@ module('Mirage | GET /api/v1/keywords/:id', function (hooks) { this.server.createList('crate', 3, { keywordIds: ['not-cli'] }); let response = await fetch('/api/v1/keywords/cli'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { keyword: { id: 'cli', diff --git a/tests/mirage/keywords/list-test.js b/tests/mirage/keywords/list-test.js index b4ac4905074..6e63c55a853 100644 --- a/tests/mirage/keywords/list-test.js +++ b/tests/mirage/keywords/list-test.js @@ -11,7 +11,7 @@ module('Mirage | GET /api/v1/keywords', function (hooks) { test('empty case', async function (assert) { let response = await fetch('/api/v1/keywords'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { keywords: [], meta: { @@ -25,7 +25,7 @@ module('Mirage | GET /api/v1/keywords', function (hooks) { this.server.createList('keyword', 2); let response = await fetch('/api/v1/keywords'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { keywords: [ { @@ -54,11 +54,11 @@ module('Mirage | GET /api/v1/keywords', function (hooks) { this.server.createList('keyword', 25); let response = await fetch('/api/v1/keywords'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let responsePayload = await response.json(); - assert.equal(responsePayload.keywords.length, 10); - assert.equal(responsePayload.meta.total, 25); + assert.strictEqual(responsePayload.keywords.length, 10); + assert.strictEqual(responsePayload.meta.total, 25); }); test('supports `page` and `per_page` parameters', async function (assert) { @@ -67,14 +67,14 @@ module('Mirage | GET /api/v1/keywords', function (hooks) { }); let response = await fetch('/api/v1/keywords?page=2&per_page=5'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let responsePayload = await response.json(); - assert.equal(responsePayload.keywords.length, 5); + assert.strictEqual(responsePayload.keywords.length, 5); assert.deepEqual( responsePayload.keywords.map(it => it.id), ['k06', 'k07', 'k08', 'k09', 'k10'], ); - assert.equal(responsePayload.meta.total, 25); + assert.strictEqual(responsePayload.meta.total, 25); }); }); diff --git a/tests/mirage/me/crate-owner-invitations/list-test.js b/tests/mirage/me/crate-owner-invitations/list-test.js index 6e4116819f2..8ae83a10c8d 100644 --- a/tests/mirage/me/crate-owner-invitations/list-test.js +++ b/tests/mirage/me/crate-owner-invitations/list-test.js @@ -14,7 +14,7 @@ module('Mirage | GET /api/v1/me/crate_owner_invitations', function (hooks) { this.server.create('mirage-session', { user }); let response = await fetch('/api/v1/me/crate_owner_invitations'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { crate_owner_invitations: [] }); }); @@ -45,7 +45,7 @@ module('Mirage | GET /api/v1/me/crate_owner_invitations', function (hooks) { }); let response = await fetch('/api/v1/me/crate_owner_invitations'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { crate_owner_invitations: [ { @@ -93,7 +93,7 @@ module('Mirage | GET /api/v1/me/crate_owner_invitations', function (hooks) { test('returns an error if unauthenticated', async function (assert) { let response = await fetch('/api/v1/me/crate_owner_invitations'); - assert.equal(response.status, 403); + assert.strictEqual(response.status, 403); assert.deepEqual(await response.json(), { errors: [{ detail: 'must be logged in to perform that action' }], }); diff --git a/tests/mirage/me/get-test.js b/tests/mirage/me/get-test.js index 3188f013864..3574e8a8488 100644 --- a/tests/mirage/me/get-test.js +++ b/tests/mirage/me/get-test.js @@ -14,7 +14,7 @@ module('Mirage | GET /api/v1/me', function (hooks) { this.server.create('mirage-session', { user }); let response = await fetch('/api/v1/me'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { user: { id: 1, @@ -40,7 +40,7 @@ module('Mirage | GET /api/v1/me', function (hooks) { this.server.create('crate-ownership', { crate: crate3, user }); let response = await fetch('/api/v1/me'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let responsePayload = await response.json(); assert.deepEqual(responsePayload.owned_crates, [ @@ -53,7 +53,7 @@ module('Mirage | GET /api/v1/me', function (hooks) { this.server.create('user'); let response = await fetch('/api/v1/me'); - assert.equal(response.status, 403); + assert.strictEqual(response.status, 403); assert.deepEqual(await response.json(), { errors: [{ detail: 'must be logged in to perform that action' }], }); diff --git a/tests/mirage/me/tokens/create-test.js b/tests/mirage/me/tokens/create-test.js index 56255c30b5a..3d2c5971360 100644 --- a/tests/mirage/me/tokens/create-test.js +++ b/tests/mirage/me/tokens/create-test.js @@ -17,7 +17,7 @@ module('Mirage | PUT /api/v1/me/tokens', function (hooks) { let body = JSON.stringify({ api_token: { name: 'foooo' } }); let response = await fetch('/api/v1/me/tokens', { method: 'PUT', body }); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let token = this.server.schema.apiTokens.all().models[0]; assert.ok(token); @@ -37,7 +37,7 @@ module('Mirage | PUT /api/v1/me/tokens', function (hooks) { test('returns an error if unauthenticated', async function (assert) { let body = JSON.stringify({ api_token: {} }); let response = await fetch('/api/v1/me/tokens', { method: 'PUT', body }); - assert.equal(response.status, 403); + assert.strictEqual(response.status, 403); assert.deepEqual(await response.json(), { errors: [{ detail: 'must be logged in to perform that action' }], }); diff --git a/tests/mirage/me/tokens/delete-by-id-test.js b/tests/mirage/me/tokens/delete-by-id-test.js index 1231bd94b01..d6d61209404 100644 --- a/tests/mirage/me/tokens/delete-by-id-test.js +++ b/tests/mirage/me/tokens/delete-by-id-test.js @@ -16,11 +16,11 @@ module('Mirage | DELETE /api/v1/me/tokens/:tokenId', function (hooks) { let token = this.server.create('api-token', { user }); let response = await fetch(`/api/v1/me/tokens/${token.id}`, { method: 'DELETE' }); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), {}); let tokens = this.server.schema.apiTokens.all().models; - assert.equal(tokens.length, 0); + assert.strictEqual(tokens.length, 0); }); test('returns an error if unauthenticated', async function (assert) { @@ -28,7 +28,7 @@ module('Mirage | DELETE /api/v1/me/tokens/:tokenId', function (hooks) { let token = this.server.create('api-token', { user }); let response = await fetch(`/api/v1/me/tokens/${token.id}`, { method: 'DELETE' }); - assert.equal(response.status, 403); + assert.strictEqual(response.status, 403); assert.deepEqual(await response.json(), { errors: [{ detail: 'must be logged in to perform that action' }], }); diff --git a/tests/mirage/me/tokens/list-test.js b/tests/mirage/me/tokens/list-test.js index 4355cea07d6..fc0b7c656d0 100644 --- a/tests/mirage/me/tokens/list-test.js +++ b/tests/mirage/me/tokens/list-test.js @@ -18,7 +18,7 @@ module('Mirage | GET /api/v1/me/tokens', function (hooks) { this.server.create('api-token', { user, createdAt: '2017-11-19T14:59:22Z' }); let response = await fetch('/api/v1/me/tokens'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { api_tokens: [ { @@ -48,13 +48,13 @@ module('Mirage | GET /api/v1/me/tokens', function (hooks) { this.server.create('mirage-session', { user }); let response = await fetch('/api/v1/me/tokens'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { api_tokens: [] }); }); test('returns an error if unauthenticated', async function (assert) { let response = await fetch('/api/v1/me/tokens'); - assert.equal(response.status, 403); + assert.strictEqual(response.status, 403); assert.deepEqual(await response.json(), { errors: [{ detail: 'must be logged in to perform that action' }], }); diff --git a/tests/mirage/me/updates/list-test.js b/tests/mirage/me/updates/list-test.js index 236602ddd5c..c1c75bf1e8f 100644 --- a/tests/mirage/me/updates/list-test.js +++ b/tests/mirage/me/updates/list-test.js @@ -11,7 +11,7 @@ module('Mirage | GET /api/v1/me/updates', function (hooks) { test('returns 403 for unauthenticated user', async function (assert) { let response = await fetch('/api/v1/me/updates'); - assert.equal(response.status, 403); + assert.strictEqual(response.status, 403); assert.deepEqual(await response.json(), { errors: [{ detail: 'must be logged in to perform that action' }], }); @@ -28,7 +28,7 @@ module('Mirage | GET /api/v1/me/updates', function (hooks) { this.authenticateAs(user); let response = await fetch('/api/v1/me/updates'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { versions: [ { @@ -61,7 +61,7 @@ module('Mirage | GET /api/v1/me/updates', function (hooks) { this.authenticateAs(user); let response = await fetch('/api/v1/me/updates'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { versions: [], meta: { more: false }, @@ -76,10 +76,10 @@ module('Mirage | GET /api/v1/me/updates', function (hooks) { this.authenticateAs(user); let response = await fetch('/api/v1/me/updates?page=2'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let responsePayload = await response.json(); - assert.equal(responsePayload.versions.length, 10); + assert.strictEqual(responsePayload.versions.length, 10); assert.deepEqual( responsePayload.versions.map(it => it.id), ['15', '14', '13', '12', '11', '10', '9', '8', '7', '6'], diff --git a/tests/mirage/private/crate-owner-invitations/get-test.js b/tests/mirage/private/crate-owner-invitations/get-test.js index 6bb61154e5b..71b004f6ace 100644 --- a/tests/mirage/private/crate-owner-invitations/get-test.js +++ b/tests/mirage/private/crate-owner-invitations/get-test.js @@ -36,7 +36,7 @@ module('Mirage | GET /api/private/crate_owner_invitations', function (hooks) { }); let response = await fetch(`/api/private/crate_owner_invitations?invitee_id=${user.id}`); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { crate_owner_invitations: [ { @@ -90,7 +90,7 @@ module('Mirage | GET /api/private/crate_owner_invitations', function (hooks) { this.server.create('mirage-session', { user }); let response = await fetch(`/api/private/crate_owner_invitations?invitee_id=${user.id}`); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { crate_owner_invitations: [], users: [], @@ -113,13 +113,13 @@ module('Mirage | GET /api/private/crate_owner_invitations', function (hooks) { } let response = await fetch(`/api/private/crate_owner_invitations?invitee_id=${user.id}`); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let responseJSON = await response.json(); assert.strictEqual(responseJSON['crate_owner_invitations'].length, 10); assert.ok(responseJSON.meta['next_page']); response = await fetch(`/api/private/crate_owner_invitations${responseJSON.meta['next_page']}`); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); responseJSON = await response.json(); assert.strictEqual(responseJSON['crate_owner_invitations'].length, 5); assert.strictEqual(responseJSON.meta['next_page'], null); @@ -152,7 +152,7 @@ module('Mirage | GET /api/private/crate_owner_invitations', function (hooks) { }); let response = await fetch(`/api/private/crate_owner_invitations?crate_name=ember-rs`); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { crate_owner_invitations: [ { @@ -188,7 +188,7 @@ module('Mirage | GET /api/private/crate_owner_invitations', function (hooks) { test('returns 403 if unauthenticated', async function (assert) { let response = await fetch(`/api/private/crate_owner_invitations?invitee_id=42`); - assert.equal(response.status, 403); + assert.strictEqual(response.status, 403); assert.deepEqual(await response.json(), { errors: [{ detail: 'must be logged in to perform that action' }], }); @@ -199,7 +199,7 @@ module('Mirage | GET /api/private/crate_owner_invitations', function (hooks) { this.server.create('mirage-session', { user }); let response = await fetch(`/api/private/crate_owner_invitations`); - assert.equal(response.status, 400); + assert.strictEqual(response.status, 400); assert.deepEqual(await response.json(), { errors: [{ detail: 'missing or invalid filter' }], }); @@ -210,7 +210,7 @@ module('Mirage | GET /api/private/crate_owner_invitations', function (hooks) { this.server.create('mirage-session', { user }); let response = await fetch(`/api/private/crate_owner_invitations?crate_name=foo`); - assert.equal(response.status, 404); + assert.strictEqual(response.status, 404); assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }], }); @@ -221,7 +221,7 @@ module('Mirage | GET /api/private/crate_owner_invitations', function (hooks) { this.server.create('mirage-session', { user }); let response = await fetch(`/api/private/crate_owner_invitations?invitee_id=${user.id + 1}`); - assert.equal(response.status, 403); + assert.strictEqual(response.status, 403); assert.deepEqual(await response.json(), { errors: [{ detail: 'must be logged in to perform that action' }], }); diff --git a/tests/mirage/private/session/delete-test.js b/tests/mirage/private/session/delete-test.js index 5b31df9f241..84e2cddf83d 100644 --- a/tests/mirage/private/session/delete-test.js +++ b/tests/mirage/private/session/delete-test.js @@ -14,7 +14,7 @@ module('Mirage | DELETE /api/private/session', function (hooks) { this.server.create('mirage-session', { user }); let response = await fetch('/api/private/session', { method: 'DELETE' }); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { ok: true }); assert.notOk(this.server.schema.mirageSessions.first()); @@ -22,7 +22,7 @@ module('Mirage | DELETE /api/private/session', function (hooks) { test('returns 200 when unauthenticated', async function (assert) { let response = await fetch('/api/private/session', { method: 'DELETE' }); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { ok: true }); assert.notOk(this.server.schema.mirageSessions.first()); diff --git a/tests/mirage/summary-test.js b/tests/mirage/summary-test.js index 5c5ad0e944d..f527c8df81a 100644 --- a/tests/mirage/summary-test.js +++ b/tests/mirage/summary-test.js @@ -12,7 +12,7 @@ module('Mirage | GET /api/v1/summary', function (hooks) { test('empty case', async function (assert) { let response = await fetch('/api/v1/summary'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { just_updated: [], most_downloaded: [], @@ -32,11 +32,11 @@ module('Mirage | GET /api/v1/summary', function (hooks) { this.server.createList('version', crates.length, { crate: i => crates[i] }); let response = await fetch('/api/v1/summary'); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); let responsePayload = await response.json(); - assert.equal(responsePayload.just_updated.length, 10); + assert.strictEqual(responsePayload.just_updated.length, 10); assert.deepEqual(responsePayload.just_updated[0], { id: 'crate-0', badges: [], @@ -63,7 +63,7 @@ module('Mirage | GET /api/v1/summary', function (hooks) { versions: null, }); - assert.equal(responsePayload.most_downloaded.length, 10); + assert.strictEqual(responsePayload.most_downloaded.length, 10); assert.deepEqual(responsePayload.most_downloaded[0], { id: 'crate-4', badges: [], @@ -90,7 +90,7 @@ module('Mirage | GET /api/v1/summary', function (hooks) { versions: null, }); - assert.equal(responsePayload.most_recently_downloaded.length, 10); + assert.strictEqual(responsePayload.most_recently_downloaded.length, 10); assert.deepEqual(responsePayload.most_recently_downloaded[0], { id: 'crate-0', badges: [], @@ -117,7 +117,7 @@ module('Mirage | GET /api/v1/summary', function (hooks) { versions: null, }); - assert.equal(responsePayload.new_crates.length, 10); + assert.strictEqual(responsePayload.new_crates.length, 10); assert.deepEqual(responsePayload.new_crates[0], { id: 'crate-0', badges: [], @@ -144,10 +144,10 @@ module('Mirage | GET /api/v1/summary', function (hooks) { versions: null, }); - assert.equal(responsePayload.num_crates, 20); - assert.equal(responsePayload.num_downloads, 1_419_675); + assert.strictEqual(responsePayload.num_crates, 20); + assert.strictEqual(responsePayload.num_downloads, 1_419_675); - assert.equal(responsePayload.popular_categories.length, 10); + assert.strictEqual(responsePayload.popular_categories.length, 10); assert.deepEqual(responsePayload.popular_categories[0], { id: 'category-0', category: 'Category 0', @@ -157,7 +157,7 @@ module('Mirage | GET /api/v1/summary', function (hooks) { slug: 'category-0', }); - assert.equal(responsePayload.popular_keywords.length, 10); + assert.strictEqual(responsePayload.popular_keywords.length, 10); assert.deepEqual(responsePayload.popular_keywords[0], { id: 'keyword-1', crates_cnt: 0, diff --git a/tests/mirage/teams/get-by-id-test.js b/tests/mirage/teams/get-by-id-test.js index 89ec9d277bb..85dcd0c98fe 100644 --- a/tests/mirage/teams/get-by-id-test.js +++ b/tests/mirage/teams/get-by-id-test.js @@ -11,7 +11,7 @@ module('Mirage | GET /api/v1/teams/:id', function (hooks) { test('returns 404 for unknown teams', async function (assert) { let response = await fetch('/api/v1/teams/foo'); - assert.equal(response.status, 404); + assert.strictEqual(response.status, 404); assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] }); }); @@ -19,7 +19,7 @@ module('Mirage | GET /api/v1/teams/:id', function (hooks) { let team = this.server.create('team', { name: 'maintainers' }); let response = await fetch(`/api/v1/teams/${team.login}`); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { team: { id: 1, diff --git a/tests/mirage/users/get-by-id-test.js b/tests/mirage/users/get-by-id-test.js index e75e243e46d..7164d291f06 100644 --- a/tests/mirage/users/get-by-id-test.js +++ b/tests/mirage/users/get-by-id-test.js @@ -11,7 +11,7 @@ module('Mirage | GET /api/v1/users/:id', function (hooks) { test('returns 404 for unknown users', async function (assert) { let response = await fetch('/api/v1/users/foo'); - assert.equal(response.status, 404); + assert.strictEqual(response.status, 404); assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] }); }); @@ -19,7 +19,7 @@ module('Mirage | GET /api/v1/users/:id', function (hooks) { let user = this.server.create('user', { name: 'John Doe' }); let response = await fetch(`/api/v1/users/${user.login}`); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { user: { id: 1, diff --git a/tests/mirage/users/resend-by-id-test.js b/tests/mirage/users/resend-by-id-test.js index e60c5c53ce4..7e0111196be 100644 --- a/tests/mirage/users/resend-by-id-test.js +++ b/tests/mirage/users/resend-by-id-test.js @@ -14,7 +14,7 @@ module('Mirage | PUT /api/v1/users/:id/resend', function (hooks) { this.server.create('mirage-session', { user }); let response = await fetch(`/api/v1/users/${user.id}/resend`, { method: 'PUT' }); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { ok: true }); }); @@ -22,7 +22,7 @@ module('Mirage | PUT /api/v1/users/:id/resend', function (hooks) { let user = this.server.create('user'); let response = await fetch(`/api/v1/users/${user.id}/resend`, { method: 'PUT' }); - assert.equal(response.status, 403); + assert.strictEqual(response.status, 403); assert.deepEqual(await response.json(), { errors: [{ detail: 'must be logged in to perform that action' }] }); }); @@ -31,7 +31,7 @@ module('Mirage | PUT /api/v1/users/:id/resend', function (hooks) { this.server.create('mirage-session', { user }); let response = await fetch(`/api/v1/users/wrong-id/resend`, { method: 'PUT' }); - assert.equal(response.status, 400); + assert.strictEqual(response.status, 400); assert.deepEqual(await response.json(), { errors: [{ detail: 'current user does not match requested user' }] }); }); }); diff --git a/tests/mirage/users/update-by-id-test.js b/tests/mirage/users/update-by-id-test.js index 5f90dd1f7ed..7ac4632580b 100644 --- a/tests/mirage/users/update-by-id-test.js +++ b/tests/mirage/users/update-by-id-test.js @@ -15,7 +15,7 @@ module('Mirage | PUT /api/v1/users/:id', function (hooks) { let body = JSON.stringify({ user: { email: 'new@email.com' } }); let response = await fetch(`/api/v1/users/${user.id}`, { method: 'PUT', body }); - assert.equal(response.status, 200); + assert.strictEqual(response.status, 200); assert.deepEqual(await response.json(), { ok: true }); user.reload(); @@ -29,7 +29,7 @@ module('Mirage | PUT /api/v1/users/:id', function (hooks) { let body = JSON.stringify({ user: { email: 'new@email.com' } }); let response = await fetch(`/api/v1/users/${user.id}`, { method: 'PUT', body }); - assert.equal(response.status, 403); + assert.strictEqual(response.status, 403); assert.deepEqual(await response.json(), { errors: [{ detail: 'must be logged in to perform that action' }] }); user.reload(); @@ -42,7 +42,7 @@ module('Mirage | PUT /api/v1/users/:id', function (hooks) { let body = JSON.stringify({ user: { email: 'new@email.com' } }); let response = await fetch(`/api/v1/users/wrong-id`, { method: 'PUT', body }); - assert.equal(response.status, 400); + assert.strictEqual(response.status, 400); assert.deepEqual(await response.json(), { errors: [{ detail: 'current user does not match requested user' }] }); user.reload(); @@ -55,7 +55,7 @@ module('Mirage | PUT /api/v1/users/:id', function (hooks) { let body = JSON.stringify({}); let response = await fetch(`/api/v1/users/${user.id}`, { method: 'PUT', body }); - assert.equal(response.status, 400); + assert.strictEqual(response.status, 400); assert.deepEqual(await response.json(), { errors: [{ detail: 'invalid json request' }] }); user.reload(); @@ -68,7 +68,7 @@ module('Mirage | PUT /api/v1/users/:id', function (hooks) { let body = JSON.stringify({ user: { email: '' } }); let response = await fetch(`/api/v1/users/${user.id}`, { method: 'PUT', body }); - assert.equal(response.status, 400); + assert.strictEqual(response.status, 400); assert.deepEqual(await response.json(), { errors: [{ detail: 'empty email rejected' }] }); user.reload(); diff --git a/tests/models/user-test.js b/tests/models/user-test.js index 2625ebdecc7..d3ca551cfb7 100644 --- a/tests/models/user-test.js +++ b/tests/models/user-test.js @@ -19,12 +19,12 @@ module('Model | User', function (hooks) { this.authenticateAs(user); let { currentUser } = await this.owner.lookup('service:session').loadUserTask.perform(); - assert.equal(currentUser.email, 'old@email.com'); + assert.strictEqual(currentUser.email, 'old@email.com'); assert.true(currentUser.email_verified); assert.true(currentUser.email_verification_sent); await currentUser.changeEmail('new@email.com'); - assert.equal(currentUser.email, 'new@email.com'); + assert.strictEqual(currentUser.email, 'new@email.com'); assert.false(currentUser.email_verified); assert.true(currentUser.email_verification_sent); }); diff --git a/tests/models/version-test.js b/tests/models/version-test.js index f42ce132630..0e1079977b1 100644 --- a/tests/models/version-test.js +++ b/tests/models/version-test.js @@ -270,9 +270,9 @@ module('Model | Version', function (hooks) { let crateRecord = await this.store.findRecord('crate', crate.name); assert.ok(crateRecord); let versions = (await crateRecord.versions).toArray(); - assert.equal(versions.length, 1); + assert.strictEqual(versions.length, 1); let version = versions[0]; assert.ok(version.published_by); - assert.equal(version.published_by.name, 'JD'); + assert.strictEqual(version.published_by.name, 'JD'); }); }); diff --git a/tests/routes/category-test.js b/tests/routes/category-test.js index 446fda83736..81bc9fbd42e 100644 --- a/tests/routes/category-test.js +++ b/tests/routes/category-test.js @@ -10,7 +10,7 @@ module('Route | category', function (hooks) { test("shows an error message if the category can't be found", async function (assert) { await visit('/categories/foo'); - assert.equal(currentURL(), '/categories/foo'); + assert.strictEqual(currentURL(), '/categories/foo'); assert.dom('[data-test-404-page]').exists(); assert.dom('[data-test-title]').hasText('foo: Category not found'); assert.dom('[data-test-go-back]').exists(); @@ -21,7 +21,7 @@ module('Route | category', function (hooks) { this.server.get('/api/v1/categories/:categoryId', {}, 500); await visit('/categories/foo'); - assert.equal(currentURL(), '/categories/foo'); + assert.strictEqual(currentURL(), '/categories/foo'); assert.dom('[data-test-404-page]').exists(); assert.dom('[data-test-title]').hasText('foo: Failed to load category data'); assert.dom('[data-test-go-back]').doesNotExist(); diff --git a/tests/routes/crate/range-test.js b/tests/routes/crate/range-test.js index e4eaa08e54b..078dcf7a9be 100644 --- a/tests/routes/crate/range-test.js +++ b/tests/routes/crate/range-test.js @@ -16,7 +16,7 @@ module('Route | crate.range', function (hooks) { this.server.create('version', { crate, num: '1.2.3' }); await visit('/crates/foo/range/^1.1.0'); - assert.equal(currentURL(), `/crates/foo/1.2.3`); + assert.strictEqual(currentURL(), `/crates/foo/1.2.3`); assert.dom('[data-test-crate-name]').hasText('foo'); assert.dom('[data-test-crate-version]').hasText('v1.2.3'); assert.dom('[data-test-notification-message]').doesNotExist(); @@ -30,7 +30,7 @@ module('Route | crate.range', function (hooks) { this.server.create('version', { crate, num: '1.2.0' }); await visit('/crates/foo/range/~1.1.0'); - assert.equal(currentURL(), `/crates/foo/1.1.1`); + assert.strictEqual(currentURL(), `/crates/foo/1.1.1`); assert.dom('[data-test-crate-name]').hasText('foo'); assert.dom('[data-test-crate-version]').hasText('v1.1.1'); assert.dom('[data-test-notification-message]').doesNotExist(); @@ -44,7 +44,7 @@ module('Route | crate.range', function (hooks) { this.server.create('version', { crate, num: '1.2.6' }); await visit('/crates/foo/range/>=1.3.0, <1.4.0'); - assert.equal(currentURL(), `/crates/foo/1.3.4`); + assert.strictEqual(currentURL(), `/crates/foo/1.3.4`); assert.dom('[data-test-crate-name]').hasText('foo'); assert.dom('[data-test-crate-version]').hasText('v1.3.4'); assert.dom('[data-test-notification-message]').doesNotExist(); @@ -58,7 +58,7 @@ module('Route | crate.range', function (hooks) { this.server.create('version', { crate, num: '1.2.0', yanked: true }); await visit('/crates/foo/range/^1.0.0'); - assert.equal(currentURL(), `/crates/foo/1.1.1`); + assert.strictEqual(currentURL(), `/crates/foo/1.1.1`); assert.dom('[data-test-crate-name]').hasText('foo'); assert.dom('[data-test-crate-version]').hasText('v1.1.1'); assert.dom('[data-test-notification-message]').doesNotExist(); @@ -72,7 +72,7 @@ module('Route | crate.range', function (hooks) { this.server.create('version', { crate, num: '2.0.0' }); await visit('/crates/foo/range/^1.0.0'); - assert.equal(currentURL(), `/crates/foo/1.1.1`); + assert.strictEqual(currentURL(), `/crates/foo/1.1.1`); assert.dom('[data-test-crate-name]').hasText('foo'); assert.dom('[data-test-crate-version]').hasText('v1.1.1'); assert.dom('[data-test-notification-message]').doesNotExist(); @@ -80,7 +80,7 @@ module('Route | crate.range', function (hooks) { test('shows an error page if crate not found', async function (assert) { await visit('/crates/foo/range/^3'); - assert.equal(currentURL(), '/crates/foo/range/%5E3'); + assert.strictEqual(currentURL(), '/crates/foo/range/%5E3'); assert.dom('[data-test-404-page]').exists(); assert.dom('[data-test-title]').hasText('foo: Crate not found'); assert.dom('[data-test-go-back]').exists(); @@ -91,7 +91,7 @@ module('Route | crate.range', function (hooks) { this.server.get('/api/v1/crates/:crate_name', {}, 500); await visit('/crates/foo/range/^3'); - assert.equal(currentURL(), '/crates/foo/range/%5E3'); + assert.strictEqual(currentURL(), '/crates/foo/range/%5E3'); assert.dom('[data-test-404-page]').exists(); assert.dom('[data-test-title]').hasText('foo: Failed to load crate data'); assert.dom('[data-test-go-back]').doesNotExist(); @@ -106,7 +106,7 @@ module('Route | crate.range', function (hooks) { this.server.create('version', { crate, num: '2.0.0' }); await visit('/crates/foo/range/^3'); - assert.equal(currentURL(), '/crates/foo/range/%5E3'); + assert.strictEqual(currentURL(), '/crates/foo/range/%5E3'); assert.dom('[data-test-404-page]').exists(); assert.dom('[data-test-title]').hasText('foo: No matching version found for ^3'); assert.dom('[data-test-go-back]').exists(); @@ -126,7 +126,7 @@ module('Route | crate.range', function (hooks) { versions.forEach(record => record.unloadRecord()); await visit('/crates/foo/range/^3'); - assert.equal(currentURL(), '/crates/foo/range/%5E3'); + assert.strictEqual(currentURL(), '/crates/foo/range/%5E3'); assert.dom('[data-test-404-page]').exists(); assert.dom('[data-test-title]').hasText('foo: Failed to load version data'); assert.dom('[data-test-go-back]').doesNotExist(); diff --git a/tests/routes/crate/version/model-test.js b/tests/routes/crate/version/model-test.js index 0293a29fec6..11f244d6929 100644 --- a/tests/routes/crate/version/model-test.js +++ b/tests/routes/crate/version/model-test.js @@ -16,7 +16,7 @@ module('Route | crate.version | model() hook', function (hooks) { this.server.create('version', { crate, num: '2.0.0-beta.1' }); await visit('/crates/foo/1.2.3'); - assert.equal(currentURL(), `/crates/foo/1.2.3`); + assert.strictEqual(currentURL(), `/crates/foo/1.2.3`); assert.dom('[data-test-crate-name]').hasText('foo'); assert.dom('[data-test-crate-version]').hasText('v1.2.3'); assert.dom('[data-test-notification-message]').doesNotExist(); @@ -29,7 +29,7 @@ module('Route | crate.version | model() hook', function (hooks) { this.server.create('version', { crate, num: '2.0.0-beta.1' }); await visit('/crates/foo/2.0.0'); - assert.equal(currentURL(), `/crates/foo/2.0.0`); + assert.strictEqual(currentURL(), `/crates/foo/2.0.0`); assert.dom('[data-test-404-page]').exists(); assert.dom('[data-test-title]').hasText('foo: Version 2.0.0 not found'); assert.dom('[data-test-go-back]').exists(); @@ -46,7 +46,7 @@ module('Route | crate.version | model() hook', function (hooks) { this.server.create('version', { crate, num: '2.0.0' }); await visit('/crates/foo'); - assert.equal(currentURL(), `/crates/foo`); + assert.strictEqual(currentURL(), `/crates/foo`); assert.dom('[data-test-crate-name]').hasText('foo'); assert.dom('[data-test-crate-version]').hasText('v2.0.0'); assert.dom('[data-test-notification-message]').doesNotExist(); @@ -59,7 +59,7 @@ module('Route | crate.version | model() hook', function (hooks) { this.server.create('version', { crate, num: '2.0.0-beta.1' }); await visit('/crates/foo'); - assert.equal(currentURL(), `/crates/foo`); + assert.strictEqual(currentURL(), `/crates/foo`); assert.dom('[data-test-crate-name]').hasText('foo'); assert.dom('[data-test-crate-version]').hasText('v1.0.0'); assert.dom('[data-test-notification-message]').doesNotExist(); @@ -74,7 +74,7 @@ module('Route | crate.version | model() hook', function (hooks) { this.server.create('version', { crate, num: '2.0.0', yanked: true }); await visit('/crates/foo'); - assert.equal(currentURL(), `/crates/foo`); + assert.strictEqual(currentURL(), `/crates/foo`); assert.dom('[data-test-crate-name]').hasText('foo'); assert.dom('[data-test-crate-version]').hasText('v2.0.0-beta.2'); assert.dom('[data-test-notification-message]').doesNotExist(); @@ -87,7 +87,7 @@ module('Route | crate.version | model() hook', function (hooks) { this.server.create('version', { crate, num: '2.0.0-beta.1', yanked: true }); await visit('/crates/foo'); - assert.equal(currentURL(), `/crates/foo`); + assert.strictEqual(currentURL(), `/crates/foo`); assert.dom('[data-test-crate-name]').hasText('foo'); assert.dom('[data-test-crate-version]').hasText('v2.0.0-beta.1'); assert.dom('[data-test-notification-message]').doesNotExist(); diff --git a/tests/routes/keyword-test.js b/tests/routes/keyword-test.js index 8271d34f4d4..f797b1f2e29 100644 --- a/tests/routes/keyword-test.js +++ b/tests/routes/keyword-test.js @@ -10,7 +10,7 @@ module('Route | keyword', function (hooks) { test('shows an empty list if the keyword does not exist on the server', async function (assert) { await visit('/keywords/foo'); - assert.equal(currentURL(), '/keywords/foo'); + assert.strictEqual(currentURL(), '/keywords/foo'); assert.dom('[data-test-crate-row]').doesNotExist(); }); @@ -18,7 +18,7 @@ module('Route | keyword', function (hooks) { this.server.get('/api/v1/crates', {}, 500); await visit('/keywords/foo'); - assert.equal(currentURL(), '/keywords/foo'); + assert.strictEqual(currentURL(), '/keywords/foo'); assert.dom('[data-test-404-page]').exists(); assert.dom('[data-test-title]').hasText('foo: Failed to load crates'); assert.dom('[data-test-go-back]').doesNotExist(); diff --git a/tests/services/redirector-test.js b/tests/services/redirector-test.js index 4fc905ff60f..ca45c04acca 100644 --- a/tests/services/redirector-test.js +++ b/tests/services/redirector-test.js @@ -16,6 +16,6 @@ module('Service | Redirector', function (hooks) { let redirector = this.owner.lookup('service:redirector'); redirector.redirectTo(URL); - assert.equal(window.location.href, URL); + assert.strictEqual(window.location.href, URL); }); }); diff --git a/tests/unit/helpers/format-email-test.js b/tests/unit/helpers/format-email-test.js index 3f67cab0666..07eaff0b095 100644 --- a/tests/unit/helpers/format-email-test.js +++ b/tests/unit/helpers/format-email-test.js @@ -5,13 +5,13 @@ import { formatEmail } from '../../../helpers/format-email'; module('Unit | Helper | format-email', function () { // Replace this with your real tests. test('it works', function (assert) { - assert.equal(formatEmail('foo'), 'foo'); - assert.equal(formatEmail('foo ').toString(), `foo`); - assert.equal( + assert.strictEqual(formatEmail('foo').toString(), 'foo'); + assert.strictEqual(formatEmail('foo ').toString(), `foo`); + assert.strictEqual( formatEmail(' ').toString(), ``, ); - assert.equal(formatEmail('').toString(), ''); - assert.equal(formatEmail('test Date: Tue, 22 Nov 2022 20:34:33 +0100 Subject: [PATCH 4/5] tests/reverse-dependencies: Fix duplicated test name --- tests/acceptance/reverse-dependencies-test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/acceptance/reverse-dependencies-test.js b/tests/acceptance/reverse-dependencies-test.js index 1c20042198f..5f20b8d2a20 100644 --- a/tests/acceptance/reverse-dependencies-test.js +++ b/tests/acceptance/reverse-dependencies-test.js @@ -64,7 +64,7 @@ module('Acceptance | /crates/:crate_id/reverse_dependencies', function (hooks) { assert.dom('[data-test-total-rows]').hasText('22'); }); - test('shows an error if the server is broken', async function (assert) { + test('shows a generic error if the server is broken', async function (assert) { let { foo } = prepare(this); this.server.get('/api/v1/crates/:crate_id/reverse_dependencies', {}, 500); @@ -76,7 +76,7 @@ module('Acceptance | /crates/:crate_id/reverse_dependencies', function (hooks) { .hasText('Could not load reverse dependencies for the "foo" crate'); }); - test('shows an error if the server is broken', async function (assert) { + test('shows a detailed error if available', async function (assert) { let { foo } = prepare(this); let payload = { errors: [{ detail: 'cannot request more than 100 items' }] }; From 40f175d1bf67b58725fc0e3f8d89fba4d73adb01 Mon Sep 17 00:00:00 2001 From: Tobias Bieniek Date: Tue, 22 Nov 2022 20:34:45 +0100 Subject: [PATCH 5/5] eslint: Add `qunit` plugin --- .eslintrc.js | 4 ++++ package.json | 1 + pnpm-lock.yaml | 12 ++++++++++++ 3 files changed, 17 insertions(+) diff --git a/.eslintrc.js b/.eslintrc.js index b57fb91b9fd..fe33b5b8cd3 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -13,6 +13,7 @@ module.exports = { extends: [ 'eslint:recommended', 'plugin:ember/recommended', + 'plugin:qunit/recommended', 'plugin:qunit-dom/recommended', 'plugin:unicorn/recommended', 'plugin:prettier/recommended', @@ -37,6 +38,9 @@ module.exports = { 'ember-concurrency/no-perform-without-catch': 'warn', 'ember-concurrency/require-task-name-suffix': 'error', + // disabled because of false positives in `assert.rejects()` calls + 'qunit/require-expect': 'off', + 'unicorn/explicit-length-check': ['error', { 'non-zero': 'not-equal' }], // disabled because of false positives related to `EmberArray` 'unicorn/no-array-for-each': 'off', diff --git a/package.json b/package.json index 1d93d1a97e9..6564079428e 100644 --- a/package.json +++ b/package.json @@ -118,6 +118,7 @@ "eslint-plugin-ember-concurrency": "0.5.1", "eslint-plugin-import-helpers": "1.3.1", "eslint-plugin-prettier": "4.2.1", + "eslint-plugin-qunit": "7.3.3", "eslint-plugin-qunit-dom": "0.2.0", "eslint-plugin-unicorn": "45.0.0", "loader.js": "4.7.0", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index eb96f7e25bc..8f4ab432afd 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -80,6 +80,7 @@ specifiers: eslint-plugin-ember-concurrency: 0.5.1 eslint-plugin-import-helpers: 1.3.1 eslint-plugin-prettier: 4.2.1 + eslint-plugin-qunit: 7.3.3 eslint-plugin-qunit-dom: 0.2.0 eslint-plugin-unicorn: 45.0.0 fastboot-app-server: 3.3.2 @@ -184,6 +185,7 @@ devDependencies: eslint-plugin-ember-concurrency: 0.5.1_eslint@8.28.0 eslint-plugin-import-helpers: 1.3.1_eslint@8.28.0 eslint-plugin-prettier: 4.2.1_pgxuib4rd7wiymfktharf5ydt4 + eslint-plugin-qunit: 7.3.3_eslint@8.28.0 eslint-plugin-qunit-dom: 0.2.0_eslint@8.28.0 eslint-plugin-unicorn: 45.0.0_eslint@8.28.0 loader.js: 4.7.0 @@ -8507,6 +8509,16 @@ packages: eslint: 8.28.0 dev: true + /eslint-plugin-qunit/7.3.3_eslint@8.28.0: + resolution: {integrity: sha512-rSOb4mLnvuQyKCj2kydnIim+e2c4IGjMkINuIPZxJQu0nqFxrQj6y24EXhD0NvTUeaawOaWtnjHOyvI2aQjwdA==} + engines: {node: 12.x || 14.x || >=16.0.0} + dependencies: + eslint-utils: 3.0.0_eslint@8.28.0 + requireindex: 1.2.0 + transitivePeerDependencies: + - eslint + dev: true + /eslint-plugin-unicorn/45.0.0_eslint@8.28.0: resolution: {integrity: sha512-iP8cMRxXKHonKioOhnCoCcqVhoqhAp6rB+nsoLjXFDxTHz3btWMAp8xwzjHA0B1K6YV/U/Yvqn1bUXZt8sJPuQ==} engines: {node: '>=14.18'}