From aaefb7864cd3f409665b4b4ee2865b9d932298b7 Mon Sep 17 00:00:00 2001 From: Renovate Bot Date: Fri, 22 Jan 2021 19:27:44 +0000 Subject: [PATCH 1/2] Update dependency eslint-plugin-unicorn to v27 --- package.json | 2 +- yarn.lock | 32 +++++++++----------------------- 2 files changed, 10 insertions(+), 24 deletions(-) diff --git a/package.json b/package.json index c07cb59c137..aa4becfc37f 100644 --- a/package.json +++ b/package.json @@ -112,7 +112,7 @@ "eslint-plugin-ember-concurrency": "0.3.1", "eslint-plugin-import-helpers": "1.1.0", "eslint-plugin-prettier": "3.3.1", - "eslint-plugin-unicorn": "26.0.1", + "eslint-plugin-unicorn": "27.0.0", "loader.js": "4.7.0", "normalize.css": "8.0.1", "nyc": "15.1.0", diff --git a/yarn.lock b/yarn.lock index b5e8957d5fc..f4f7f228172 100644 --- a/yarn.lock +++ b/yarn.lock @@ -7361,14 +7361,6 @@ escodegen@^1.14.1: optionalDependencies: source-map "~0.6.1" -eslint-ast-utils@^1.1.0: - version "1.1.0" - resolved "https://registry.yarnpkg.com/eslint-ast-utils/-/eslint-ast-utils-1.1.0.tgz#3d58ba557801cfb1c941d68131ee9f8c34bd1586" - integrity sha512-otzzTim2/1+lVrlH19EfQQJEhVJSu0zOb9ygb3iapN6UlyaDtyRq4b5U1FuW0v1lRa9Fp/GJyHkSwm6NqABgCA== - dependencies: - lodash.get "^4.4.2" - lodash.zip "^4.2.0" - eslint-config-prettier@7.2.0: version "7.2.0" resolved "https://registry.yarnpkg.com/eslint-config-prettier/-/eslint-config-prettier-7.2.0.tgz#f4a4bd2832e810e8cc7c1411ec85b3e85c0c53f9" @@ -7403,21 +7395,20 @@ eslint-plugin-prettier@3.3.1: dependencies: prettier-linter-helpers "^1.0.0" -eslint-plugin-unicorn@26.0.1: - version "26.0.1" - resolved "https://registry.yarnpkg.com/eslint-plugin-unicorn/-/eslint-plugin-unicorn-26.0.1.tgz#65f476bb7624beb417066259dc14c7ebb21eb6fc" - integrity sha512-SWgF9sIVY74zqkkSN2dclSCqRfocWSUGD0haC0NX2oRfmdp9p8dQvJYkYSQePaCyssPUE/pqpsIEEZNTh8crUA== +eslint-plugin-unicorn@27.0.0: + version "27.0.0" + resolved "https://registry.yarnpkg.com/eslint-plugin-unicorn/-/eslint-plugin-unicorn-27.0.0.tgz#d12436409e399ab75c826bbb17b202846a276e5a" + integrity sha512-uUvlueTa4SpkvLjbkqx08JbB0tY6XxOAa8vlfwbTzITfVNy3go3QzPCus49fO5M/mfooOuraIDVkaqan/pLAHg== dependencies: ci-info "^2.0.0" clean-regexp "^1.0.0" - eslint-ast-utils "^1.1.0" eslint-template-visitor "^2.2.2" eslint-utils "^2.1.0" import-modules "^2.1.0" lodash "^4.17.20" pluralize "^8.0.0" read-pkg-up "^7.0.1" - regexp-tree "^0.1.21" + regexp-tree "^0.1.22" reserved-words "^0.1.2" safe-regex "^2.1.1" semver "^7.3.4" @@ -10317,11 +10308,6 @@ lodash.values@^4.3.0: resolved "https://registry.yarnpkg.com/lodash.values/-/lodash.values-4.3.0.tgz#a3a6c2b0ebecc5c2cba1c17e6e620fe81b53d347" integrity sha1-o6bCsOvsxcLLocF+bmIP6BtT00c= -lodash.zip@^4.2.0: - version "4.2.0" - resolved "https://registry.yarnpkg.com/lodash.zip/-/lodash.zip-4.2.0.tgz#ec6662e4896408ed4ab6c542a3990b72cc080020" - integrity sha1-7GZi5IlkCO1KtsVCo5kLcswIACA= - lodash@^4.17.10, lodash@^4.17.11, lodash@^4.17.12, lodash@^4.17.13, lodash@^4.17.14, lodash@^4.17.15, lodash@^4.17.19, lodash@^4.17.20, lodash@^4.17.4, lodash@^4.5.1: version "4.17.20" resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.20.tgz#b44a9b6297bcb698f1c51a3545a2b3b368d59c52" @@ -12586,10 +12572,10 @@ regex-not@^1.0.0, regex-not@^1.0.2: extend-shallow "^3.0.2" safe-regex "^1.1.0" -regexp-tree@^0.1.21, regexp-tree@~0.1.1: - version "0.1.21" - resolved "https://registry.yarnpkg.com/regexp-tree/-/regexp-tree-0.1.21.tgz#55e2246b7f7d36f1b461490942fa780299c400d7" - integrity sha512-kUUXjX4AnqnR8KRTCrayAo9PzYMRKmVoGgaz2tBuz0MF3g1ZbGebmtW0yFHfFK9CmBjQKeYIgoL22pFLBJY7sw== +regexp-tree@^0.1.22, regexp-tree@~0.1.1: + version "0.1.23" + resolved "https://registry.yarnpkg.com/regexp-tree/-/regexp-tree-0.1.23.tgz#8a8ce1cc5e971acef62213a7ecdb1f6e18a1f1b2" + integrity sha512-+7HWfb4Bvu8Rs2eQTUIpX9I/PlQkYOuTNbRpKLJlQpSgwSkzFYh+pUj0gtvglnOZLKB6YgnIgRuJ2/IlpL48qw== regexpp@^3.1.0: version "3.1.0" From a9d767cc11faac4491e39e4ba894336b47682979 Mon Sep 17 00:00:00 2001 From: Tobias Bieniek Date: Tue, 26 Jan 2021 01:16:40 +0100 Subject: [PATCH 2/2] ESLint: Disable `unicorn/no-array-for-each` rule --- .eslintrc.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.eslintrc.js b/.eslintrc.js index 4149f397084..b06480c6027 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -39,6 +39,8 @@ module.exports = { 'ember-concurrency/require-task-name-suffix': 'error', 'unicorn/explicit-length-check': ['error', { 'non-zero': 'not-equal' }], + // disabled because of false positives related to `EmberArray` + 'unicorn/no-array-for-each': 'off', // disabled because we need `null` since JSON has no `undefined` 'unicorn/no-null': 'off', // disabled because this rule conflicts with prettier