From b51cf947a35475ad3990a0ee8789358291329f71 Mon Sep 17 00:00:00 2001
From: Tobias Bieniek <tobias.bieniek@gmail.com>
Date: Sun, 22 Dec 2019 00:03:34 +0100
Subject: [PATCH] ESLint: Enable disabled rules

... and instead only disable specific cases using `eslint-disable-next-line` comments
---
 .eslintrc.js                         | 3 ---
 app/components/badge-maintenance.js  | 1 +
 app/controllers/crate/version.js     | 1 +
 app/mixins/authenticated-route.js    | 1 +
 app/mixins/pagination.js             | 1 +
 app/mixins/rl-dropdown-component.js  | 2 ++
 app/routes/crate/version.js          | 1 +
 tests/unit/mixins/pagination-test.js | 1 +
 8 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/.eslintrc.js b/.eslintrc.js
index adc0d8ff90b..c1905e1fb49 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -11,9 +11,6 @@ module.exports = {
   },
   rules: {
     'prettier/prettier': 'error',
-    'ember/no-observers': 'warn',
-    'ember/no-new-mixins': 'warn',
-    'ember/require-return-from-computed': 'warn',
   },
   overrides: [
     // node files
diff --git a/app/components/badge-maintenance.js b/app/components/badge-maintenance.js
index 327b0bd769b..61895e1ce04 100644
--- a/app/components/badge-maintenance.js
+++ b/app/components/badge-maintenance.js
@@ -12,6 +12,7 @@ export default Component.extend({
     return this.get('badge.attributes.status') === 'none' || !this.get('badge.attributes.status');
   }),
   status: alias('badge.attributes.status'),
+  // eslint-disable-next-line ember/require-return-from-computed
   color: computed('badge', function() {
     switch (this.get('badge.attributes.status')) {
       case 'actively-developed':
diff --git a/app/controllers/crate/version.js b/app/controllers/crate/version.js
index 1f71a8baf4a..ba66dd3b515 100644
--- a/app/controllers/crate/version.js
+++ b/app/controllers/crate/version.js
@@ -173,6 +173,7 @@ export default Controller.extend({
     },
   },
 
+  // eslint-disable-next-line ember/no-observers
   report: observer('crate.readme', function() {
     if (typeof document === 'undefined') {
       return;
diff --git a/app/mixins/authenticated-route.js b/app/mixins/authenticated-route.js
index d599c648495..7576c99bc49 100644
--- a/app/mixins/authenticated-route.js
+++ b/app/mixins/authenticated-route.js
@@ -1,6 +1,7 @@
 import Mixin from '@ember/object/mixin';
 import { inject as service } from '@ember/service';
 
+// eslint-disable-next-line ember/no-new-mixins
 export default Mixin.create({
   flashMessages: service(),
   session: service(),
diff --git a/app/mixins/pagination.js b/app/mixins/pagination.js
index 70706b51421..1b656ea35a1 100644
--- a/app/mixins/pagination.js
+++ b/app/mixins/pagination.js
@@ -4,6 +4,7 @@ import { computed } from '@ember/object';
 
 const VIEWABLE_PAGES = 9;
 
+// eslint-disable-next-line ember/no-new-mixins
 export default Mixin.create({
   // Gives page numbers to the surrounding 9 pages.
   pages: computed('currentPage', 'availablePages', function() {
diff --git a/app/mixins/rl-dropdown-component.js b/app/mixins/rl-dropdown-component.js
index 6008d7f6d40..63889ec1760 100644
--- a/app/mixins/rl-dropdown-component.js
+++ b/app/mixins/rl-dropdown-component.js
@@ -4,6 +4,7 @@ import { on } from '@ember/object/evented';
 import { bind, later } from '@ember/runloop';
 import $ from 'jquery';
 
+// eslint-disable-next-line ember/no-new-mixins
 export default Mixin.create({
   init() {
     this._super(...arguments);
@@ -49,6 +50,7 @@ export default Mixin.create({
 
   manageClosingEvents: on(
     'didInsertElement',
+    // eslint-disable-next-line ember/no-observers
     observer('dropdownExpanded', function() {
       let namespace = this.closingEventNamespace;
       let clickEventName = `click.${namespace}`;
diff --git a/app/routes/crate/version.js b/app/routes/crate/version.js
index b8c0dff079b..b52c1a4d9c6 100644
--- a/app/routes/crate/version.js
+++ b/app/routes/crate/version.js
@@ -11,6 +11,7 @@ export default Route.extend({
 
   flashMessages: service(),
 
+  // eslint-disable-next-line ember/no-observers
   refreshAfterLogin: observer('session.isLoggedIn', function() {
     this.refresh();
   }),
diff --git a/tests/unit/mixins/pagination-test.js b/tests/unit/mixins/pagination-test.js
index 498db19d341..e172efbc63a 100644
--- a/tests/unit/mixins/pagination-test.js
+++ b/tests/unit/mixins/pagination-test.js
@@ -6,6 +6,7 @@ import PaginationMixin from '../../../mixins/pagination';
 module('Unit | Mixin | pagination', function() {
   // Replace this with your real tests.
   test('it works', function(assert) {
+    // eslint-disable-next-line ember/no-new-mixins
     let PaginationObject = EmberObject.extend(PaginationMixin);
     let subject = PaginationObject.create();
     assert.ok(subject);