Skip to content

Commit ff949b0

Browse files
nipunn1313Turbo87
authored andcommitted
admin::render_readmes: Simplify find_file_by_path() parameters
1 parent 15f75ca commit ff949b0

File tree

1 file changed

+8
-26
lines changed

1 file changed

+8
-26
lines changed

src/admin/render_readmes.rs

Lines changed: 8 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -199,15 +199,15 @@ fn get_readme(
199199

200200
let manifest: Manifest = {
201201
let path = format!("{}/Cargo.toml", pkg_name);
202-
let contents = find_file_by_path(&mut entries, Path::new(&path), version, krate_name);
202+
let contents = find_file_by_path(&mut entries, Path::new(&path), &pkg_name);
203203
toml::from_str(&contents)
204204
.unwrap_or_else(|_| panic!("[{}] Syntax error in manifest file", pkg_name))
205205
};
206206

207207
let rendered = {
208208
let readme_path = manifest.package.readme.as_ref()?;
209209
let path = format!("{}/{}", pkg_name, readme_path);
210-
let contents = find_file_by_path(&mut entries, Path::new(&path), version, krate_name);
210+
let contents = find_file_by_path(&mut entries, Path::new(&path), &pkg_name);
211211
text_to_html(
212212
&contents,
213213
readme_path,
@@ -232,8 +232,7 @@ fn get_readme(
232232
fn find_file_by_path<R: Read>(
233233
entries: &mut tar::Entries<'_, R>,
234234
path: &Path,
235-
version: &Version,
236-
krate_name: &str,
235+
pkg_name: &str,
237236
) -> String {
238237
let mut file = entries
239238
.find(|entry| match *entry {
@@ -246,28 +245,11 @@ fn find_file_by_path<R: Read>(
246245
filepath == path
247246
}
248247
})
249-
.unwrap_or_else(|| {
250-
panic!(
251-
"[{}-{}] couldn't open file: {}",
252-
krate_name,
253-
version.num,
254-
path.display()
255-
)
256-
})
257-
.unwrap_or_else(|_| {
258-
panic!(
259-
"[{}-{}] file is not present: {}",
260-
krate_name,
261-
version.num,
262-
path.display()
263-
)
264-
});
248+
.unwrap_or_else(|| panic!("[{}] couldn't open file: {}", pkg_name, path.display()))
249+
.unwrap_or_else(|_| panic!("[{}] file is not present: {}", pkg_name, path.display()));
250+
265251
let mut contents = String::new();
266-
file.read_to_string(&mut contents).unwrap_or_else(|_| {
267-
panic!(
268-
"[{}-{}] Couldn't read file contents",
269-
krate_name, version.num
270-
)
271-
});
252+
file.read_to_string(&mut contents)
253+
.unwrap_or_else(|_| panic!("[{}] Couldn't read file contents", pkg_name));
272254
contents
273255
}

0 commit comments

Comments
 (0)