Skip to content

Commit ef9daee

Browse files
committed
Redirect /owners to /settings
Fix test
1 parent e5171ce commit ef9daee

File tree

7 files changed

+20
-6
lines changed

7 files changed

+20
-6
lines changed

app/controllers/crate/owners.js renamed to app/controllers/crate/settings.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { inject as service } from '@ember/service';
33

44
import { task } from 'ember-concurrency';
55

6-
export default class CrateOwnersController extends Controller {
6+
export default class CrateSettingsController extends Controller {
77
@service notifications;
88

99
crate = null;

app/router.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ Router.map(function () {
2020
this.route('reverse-dependencies', { path: 'reverse_dependencies' });
2121

2222
this.route('owners');
23+
this.route('settings');
2324

2425
// Well-known routes
2526
this.route('docs');

app/routes/crate/owners.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
11
import Route from '@ember/routing/route';
2+
import { inject as service } from '@ember/service';
23

34
export default class OwnersRoute extends Route {
4-
setupController(controller) {
5-
super.setupController(...arguments);
5+
@service notifications;
6+
@service redirector;
7+
8+
redirect() {
69
let crate = this.modelFor('crate');
7-
controller.set('crate', crate);
10+
11+
this.transitionTo('crate.settings', crate);
812
}
913
}

app/routes/crate/settings.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
import Route from '@ember/routing/route';
2+
3+
export default class SettingsRoute extends Route {
4+
setupController(controller) {
5+
super.setupController(...arguments);
6+
let crate = this.modelFor('crate');
7+
controller.set('crate', crate);
8+
}
9+
}

app/templates/crate/owners.hbs renamed to app/templates/crate/settings.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{{page-title 'Manage Crate Owners'}}
1+
{{page-title 'Manage Crate Settings'}}
22

33
<CrateHeader @crate={{this.crate}} />
44

tests/acceptance/crate-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,6 @@ module('Acceptance | crate page', function (hooks) {
210210
await visit('/crates/nanomsg');
211211
await click('[data-test-settings-tab] a');
212212

213-
assert.equal(currentURL(), '/crates/nanomsg/owners');
213+
assert.equal(currentURL(), '/crates/nanomsg/settings');
214214
});
215215
});

0 commit comments

Comments
 (0)