mirage: Collapse nested test modules

Author: Turbo87

tests/mirage/categories/get-by-id-test.js

@@ -5,61 +5,59 @@ import fetch from 'fetch';
 import { setupTest } from '../../helpers';
 import setupMirage from '../../helpers/setup-mirage';
 
-module('Mirage | Categories', function (hooks) {
+module('Mirage | GET /api/v1/categories/:id', function (hooks) {
   setupTest(hooks);
   setupMirage(hooks);
 
-  module('GET /api/v1/categories/:id', function () {
-    test('returns 404 for unknown categories', async function (assert) {
-      let response = await fetch('/api/v1/categories/foo');
-      assert.equal(response.status, 404);
+  test('returns 404 for unknown categories', async function (assert) {
+    let response = await fetch('/api/v1/categories/foo');
+    assert.equal(response.status, 404);
 
-      let responsePayload = await response.json();
-      assert.deepEqual(responsePayload, { errors: [{ detail: 'Not Found' }] });
+    let responsePayload = await response.json();
+    assert.deepEqual(responsePayload, { errors: [{ detail: 'Not Found' }] });
+  });
+
+  test('returns a category object for known categories', async function (assert) {
+    this.server.create('category', {
+      category: 'no-std',
+      description: 'Crates that are able to function without the Rust standard library.',
     });
 
-    test('returns a category object for known categories', async function (assert) {
-      this.server.create('category', {
+    let response = await fetch('/api/v1/categories/no-std');
+    assert.equal(response.status, 200);
+
+    let responsePayload = await response.json();
+    assert.deepEqual(responsePayload, {
+      category: {
+        id: 'no-std',
         category: 'no-std',
+        crates_cnt: 0,
+        created_at: '2010-06-16T21:30:45Z',
         description: 'Crates that are able to function without the Rust standard library.',
-      });
-
-      let response = await fetch('/api/v1/categories/no-std');
-      assert.equal(response.status, 200);
-
-      let responsePayload = await response.json();
-      assert.deepEqual(responsePayload, {
-        category: {
-          id: 'no-std',
-          category: 'no-std',
-          crates_cnt: 0,
-          created_at: '2010-06-16T21:30:45Z',
-          description: 'Crates that are able to function without the Rust standard library.',
-          slug: 'no-std',
-        },
-      });
+        slug: 'no-std',
+      },
     });
+  });
 
-    test('calculates `crates_cnt` correctly', async function (assert) {
-      this.server.create('category', { category: 'cli' });
-      this.server.createList('crate', 7, { categoryIds: ['cli'] });
-      this.server.create('category', { category: 'not-cli' });
-      this.server.createList('crate', 3, { categoryIds: ['not-cli'] });
-
-      let response = await fetch('/api/v1/categories/cli');
-      assert.equal(response.status, 200);
-
-      let responsePayload = await response.json();
-      assert.deepEqual(responsePayload, {
-        category: {
-          category: 'cli',
-          crates_cnt: 7,
-          created_at: '2010-06-16T21:30:45Z',
-          description: 'This is the description for the category called "cli"',
-          id: 'cli',
-          slug: 'cli',
-        },
-      });
+  test('calculates `crates_cnt` correctly', async function (assert) {
+    this.server.create('category', { category: 'cli' });
+    this.server.createList('crate', 7, { categoryIds: ['cli'] });
+    this.server.create('category', { category: 'not-cli' });
+    this.server.createList('crate', 3, { categoryIds: ['not-cli'] });
+
+    let response = await fetch('/api/v1/categories/cli');
+    assert.equal(response.status, 200);
+
+    let responsePayload = await response.json();
+    assert.deepEqual(responsePayload, {
+      category: {
+        category: 'cli',
+        crates_cnt: 7,
+        created_at: '2010-06-16T21:30:45Z',
+        description: 'This is the description for the category called "cli"',
+        id: 'cli',
+        slug: 'cli',
+      },
     });
   });
 });

tests/mirage/categories/list-test.js

@@ -5,94 +5,92 @@ import fetch from 'fetch';
 import { setupTest } from '../../helpers';
 import setupMirage from '../../helpers/setup-mirage';
 
-module('Mirage | Categories', function (hooks) {
+module('Mirage | GET /api/v1/categories', function (hooks) {
   setupTest(hooks);
   setupMirage(hooks);
 
-  module('GET /api/v1/categories', function () {
-    test('empty case', async function (assert) {
-      let response = await fetch('/api/v1/categories');
-      assert.equal(response.status, 200);
+  test('empty case', async function (assert) {
+    let response = await fetch('/api/v1/categories');
+    assert.equal(response.status, 200);
 
-      let responsePayload = await response.json();
-      assert.deepEqual(responsePayload, {
-        categories: [],
-        meta: {
-          total: 0,
-        },
-      });
+    let responsePayload = await response.json();
+    assert.deepEqual(responsePayload, {
+      categories: [],
+      meta: {
+        total: 0,
+      },
     });
+  });
 
-    test('returns a paginated categories list', async function (assert) {
-      this.server.create('category', {
-        category: 'no-std',
-        description: 'Crates that are able to function without the Rust standard library.',
-      });
-      this.server.createList('category', 2);
+  test('returns a paginated categories list', async function (assert) {
+    this.server.create('category', {
+      category: 'no-std',
+      description: 'Crates that are able to function without the Rust standard library.',
+    });
+    this.server.createList('category', 2);
 
-      let response = await fetch('/api/v1/categories');
-      assert.equal(response.status, 200);
+    let response = await fetch('/api/v1/categories');
+    assert.equal(response.status, 200);
 
-      let responsePayload = await response.json();
-      assert.deepEqual(responsePayload, {
-        categories: [
-          {
-            id: 'category-1',
-            category: 'Category 1',
-            crates_cnt: 0,
-            created_at: '2010-06-16T21:30:45Z',
-            description: 'This is the description for the category called "Category 1"',
-            slug: 'category-1',
-          },
-          {
-            id: 'category-2',
-            category: 'Category 2',
-            crates_cnt: 0,
-            created_at: '2010-06-16T21:30:45Z',
-            description: 'This is the description for the category called "Category 2"',
-            slug: 'category-2',
-          },
-          {
-            id: 'no-std',
-            category: 'no-std',
-            crates_cnt: 0,
-            created_at: '2010-06-16T21:30:45Z',
-            description: 'Crates that are able to function without the Rust standard library.',
-            slug: 'no-std',
-          },
-        ],
-        meta: {
-          total: 3,
+    let responsePayload = await response.json();
+    assert.deepEqual(responsePayload, {
+      categories: [
+        {
+          id: 'category-1',
+          category: 'Category 1',
+          crates_cnt: 0,
+          created_at: '2010-06-16T21:30:45Z',
+          description: 'This is the description for the category called "Category 1"',
+          slug: 'category-1',
+        },
+        {
+          id: 'category-2',
+          category: 'Category 2',
+          crates_cnt: 0,
+          created_at: '2010-06-16T21:30:45Z',
+          description: 'This is the description for the category called "Category 2"',
+          slug: 'category-2',
+        },
+        {
+          id: 'no-std',
+          category: 'no-std',
+          crates_cnt: 0,
+          created_at: '2010-06-16T21:30:45Z',
+          description: 'Crates that are able to function without the Rust standard library.',
+          slug: 'no-std',
         },
-      });
+      ],
+      meta: {
+        total: 3,
+      },
     });
+  });
 
-    test('never returns more than 10 results', async function (assert) {
-      this.server.createList('category', 25);
+  test('never returns more than 10 results', async function (assert) {
+    this.server.createList('category', 25);
 
-      let response = await fetch('/api/v1/categories');
-      assert.equal(response.status, 200);
+    let response = await fetch('/api/v1/categories');
+    assert.equal(response.status, 200);
 
-      let responsePayload = await response.json();
-      assert.equal(responsePayload.categories.length, 10);
-      assert.equal(responsePayload.meta.total, 25);
-    });
+    let responsePayload = await response.json();
+    assert.equal(responsePayload.categories.length, 10);
+    assert.equal(responsePayload.meta.total, 25);
+  });
 
-    test('supports `page` and `per_page` parameters', async function (assert) {
-      this.server.createList('category', 25, {
-        category: i => `cat-${String(i + 1).padStart(2, '0')}`,
-      });
+  test('supports `page` and `per_page` parameters', async function (assert) {
+    this.server.createList('category', 25, {
+      category: i => `cat-${String(i + 1).padStart(2, '0')}`,
+    });
 
-      let response = await fetch('/api/v1/categories?page=2&per_page=5');
-      assert.equal(response.status, 200);
+    let response = await fetch('/api/v1/categories?page=2&per_page=5');
+    assert.equal(response.status, 200);
 
-      let responsePayload = await response.json();
-      assert.equal(responsePayload.categories.length, 5);
-      assert.deepEqual(
-        responsePayload.categories.map(it => it.id),
-        ['cat-06', 'cat-07', 'cat-08', 'cat-09', 'cat-10'],
-      );
-      assert.equal(responsePayload.meta.total, 25);
-    });
+    let responsePayload = await response.json();
+    assert.equal(responsePayload.categories.length, 5);
+    assert.deepEqual(
+      responsePayload.categories.map(it => it.id),
+      ['cat-06', 'cat-07', 'cat-08', 'cat-09', 'cat-10'],
+    );
+    assert.equal(responsePayload.meta.total, 25);
   });
 });

tests/mirage/category-slugs/list-test.js

@@ -5,61 +5,59 @@ import fetch from 'fetch';
 import { setupTest } from '../../helpers';
 import setupMirage from '../../helpers/setup-mirage';
 
-module('Mirage | Categories', function (hooks) {
+module('Mirage | GET /api/v1/category_slugs', function (hooks) {
   setupTest(hooks);
   setupMirage(hooks);
 
-  module('GET /api/v1/category_slugs', function () {
-    test('empty case', async function (assert) {
-      let response = await fetch('/api/v1/category_slugs');
-      assert.equal(response.status, 200);
+  test('empty case', async function (assert) {
+    let response = await fetch('/api/v1/category_slugs');
+    assert.equal(response.status, 200);
 
-      let responsePayload = await response.json();
-      assert.deepEqual(responsePayload, {
-        category_slugs: [],
-      });
+    let responsePayload = await response.json();
+    assert.deepEqual(responsePayload, {
+      category_slugs: [],
     });
+  });
 
-    test('returns a category slugs list', async function (assert) {
-      this.server.create('category', {
-        category: 'no-std',
-        description: 'Crates that are able to function without the Rust standard library.',
-      });
-      this.server.createList('category', 2);
-
-      let response = await fetch('/api/v1/category_slugs');
-      assert.equal(response.status, 200);
-
-      let responsePayload = await response.json();
-      assert.deepEqual(responsePayload, {
-        category_slugs: [
-          {
-            description: 'This is the description for the category called "Category 1"',
-            id: 'category-1',
-            slug: 'category-1',
-          },
-          {
-            description: 'This is the description for the category called "Category 2"',
-            id: 'category-2',
-            slug: 'category-2',
-          },
-          {
-            description: 'Crates that are able to function without the Rust standard library.',
-            id: 'no-std',
-            slug: 'no-std',
-          },
-        ],
-      });
+  test('returns a category slugs list', async function (assert) {
+    this.server.create('category', {
+      category: 'no-std',
+      description: 'Crates that are able to function without the Rust standard library.',
     });
+    this.server.createList('category', 2);
+
+    let response = await fetch('/api/v1/category_slugs');
+    assert.equal(response.status, 200);
+
+    let responsePayload = await response.json();
+    assert.deepEqual(responsePayload, {
+      category_slugs: [
+        {
+          description: 'This is the description for the category called "Category 1"',
+          id: 'category-1',
+          slug: 'category-1',
+        },
+        {
+          description: 'This is the description for the category called "Category 2"',
+          id: 'category-2',
+          slug: 'category-2',
+        },
+        {
+          description: 'Crates that are able to function without the Rust standard library.',
+          id: 'no-std',
+          slug: 'no-std',
+        },
+      ],
+    });
+  });
 
-    test('has no pagination', async function (assert) {
-      this.server.createList('category', 25);
+  test('has no pagination', async function (assert) {
+    this.server.createList('category', 25);
 
-      let response = await fetch('/api/v1/category_slugs');
-      assert.equal(response.status, 200);
+    let response = await fetch('/api/v1/category_slugs');
+    assert.equal(response.status, 200);
 
-      let responsePayload = await response.json();
-      assert.equal(responsePayload.category_slugs.length, 25);
-    });
+    let responsePayload = await response.json();
+    assert.equal(responsePayload.category_slugs.length, 25);
   });
 });