Fix tidy warnings and add some tests

Author: alexcrichton

app/helpers/format-email.js

@@ -4,16 +4,20 @@ var escape = Ember.Handlebars.Utils.escapeExpression;
 
 function formatEmail(email) {
   var formatted = email.match(/^(.*?)\s*(?:<(.*)>)?$/);
-  var email = "";
+  var ret = "";
 
-  email += escape(formatted[1]);
+  ret += escape(formatted[1]);
 
   if (formatted[2]) {
-    email = "<a href='mailto:" + escape(formatted[2]) + "'>" + email + "</a>";
+    ret = "<a href='mailto:" + escape(formatted[2]) + "'>" + ret + "</a>";
   }
 
-  console.log(email);
-  return email.htmlSafe();
+  return ret.htmlSafe();
 }
 
+
+export {
+    formatEmail
+};
+
 export default Ember.Handlebars.makeBoundHelper(formatEmail);

tests/unit/helpers/format-email-test.js

@@ -0,0 +1,17 @@
+import {
+  formatEmail
+} from 'cargo/helpers/format-email';
+
+module('FormatEmailHelper');
+
+// Replace this with your real tests.
+test('it works', function(assert) {
+    assert.equal(formatEmail('foo'), 'foo');
+    assert.equal(formatEmail('foo <foo@bar.com>').toString(),
+                 "<a href='mailto:foo@bar.com'>foo</a>");
+    assert.equal(formatEmail('<script></script> <foo@bar.com>').toString(),
+                 "<a href='mailto:script&gt;&lt;/script&gt; &lt;foo@bar.com'></a>");
+    assert.equal(formatEmail('').toString(), '');
+    assert.equal(formatEmail('test <foo').toString(), 'test &lt;foo');
+});
+