Auto merge of #4294 - Turbo87:clone-trait, r=Turbo87

bors · bors · commit b03ebf3eb24e · 2021-12-19T14:09:22.000Z
models/version: Remove unnecessary `Clone` trait bound

There is no need for this trait bound since we only use the iterator once.
diff --git a/src/models/version.rs b/src/models/version.rs
@@ -59,7 +59,7 @@ impl TopVersions {
     /// highest version (in semver order) for a collection of date/version pairs.
     pub fn from_date_version_pairs<T>(pairs: T) -> Self
     where
-        T: Clone + IntoIterator<Item = (NaiveDateTime, String)>,
+        T: IntoIterator<Item = (NaiveDateTime, String)>,
     {
         // filter out versions that we can't parse
         let pairs: Vec<(NaiveDateTime, semver::Version)> = pairs

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ impl TopVersions {`
`59`	`59`	`/// highest version (in semver order) for a collection of date/version pairs.`
`60`	`60`	`pub fn from_date_version_pairs<T>(pairs: T) -> Self`
`61`	`61`	`where`
`62`		`- T: Clone + IntoIterator<Item = (NaiveDateTime, String)>,`
	`62`	`+ T: IntoIterator<Item = (NaiveDateTime, String)>,`
`63`	`63`	`{`
`64`	`64`	`// filter out versions that we can't parse`
`65`	`65`	`let pairs: Vec<(NaiveDateTime, semver::Version)> = pairs`