Merge pull request #5044 from Turbo87/lazy

Replace `lazy_static` with `once_cell`

Author: Turbo87

Cargo.lock

@@ -89,7 +89,7 @@ cargo-registry-index = { path = "cargo-registry-index", features = ["testing"] }
 claim = { git = "https://github.com/Turbo87/rust-claim.git", rev = "23892a3" }
 conduit-test = "=0.10.0"
 hyper-tls = "=0.5.0"
-lazy_static = "=1.4.0"
+once_cell = "=1.13.0"
 tokio = "=1.20.1"
 tower-service = "=0.3.2"
 

Cargo.toml

@@ -5,8 +5,6 @@ extern crate claim;
 #[macro_use]
 extern crate diesel;
 #[macro_use]
-extern crate lazy_static;
-#[macro_use]
 extern crate serde;
 #[macro_use]
 extern crate serde_json;

src/tests/all.rs

@@ -2,22 +2,22 @@ use cargo_registry::views::krate_publish as u;
 use std::{collections::HashMap, io::Read};
 
 use flate2::{write::GzEncoder, Compression};
+use once_cell::sync::Lazy;
 
 use super::DependencyBuilder;
 
-lazy_static! {
-    // The bytes of an empty tarball is not an empty vector of bytes because of tarball headers.
-    // Unless files are added to a PublishBuilder, the `.crate` tarball that gets uploaded
-    // will be empty, so precompute the empty tarball bytes to use as a default.
-    static ref EMPTY_TARBALL_BYTES: Vec<u8> = {
-        let mut empty_tarball = vec![];
-        {
-            let mut ar =
-                tar::Builder::new(GzEncoder::new(&mut empty_tarball, Compression::default()));
-            assert_ok!(ar.finish());
-        }
-        empty_tarball
-    };
+// The bytes of an empty tarball is not an empty vector of bytes because of tarball headers.
+// Unless files are added to a PublishBuilder, the `.crate` tarball that gets uploaded
+// will be empty, so precompute the empty tarball bytes to use as a default.
+static EMPTY_TARBALL_BYTES: Lazy<Vec<u8>> = Lazy::new(generate_empty_tarball);
+
+fn generate_empty_tarball() -> Vec<u8> {
+    let mut empty_tarball = vec![];
+    {
+        let mut ar = tar::Builder::new(GzEncoder::new(&mut empty_tarball, Compression::default()));
+        assert_ok!(ar.finish());
+    }
+    empty_tarball
 }
 
 /// A builder for constructing a crate for the purposes of testing publishing. If you only need