Drop database connections to avoid reentrancy in tests

This fixes the remaining tests but it may be desirable to refactor
things to reuse an existing connection rather than drop and obtain a
new one.

Author: jtgeibel

src/controllers/github/secret_scanning.rs

@@ -182,6 +182,8 @@ fn alert_revoke_token(
         .set(api_tokens::revoked.eq(true))
         .execute(&*conn)?;
 
+    drop(conn);
+
     warn!(
         token_id = %token.id, user_id = %token.user_id,
         "Active API token received and revoked (true positive)",

src/controllers/krate/publish.rs

@@ -72,6 +72,8 @@ pub fn publish(req: &mut ConduitRequest) -> EndpointResult {
         .first::<Crate>(&*conn)
         .optional()?;
 
+    drop(conn);
+
     let endpoint_scope = match existing_crate {
         Some(_) => EndpointScope::PublishUpdate,
         None => EndpointScope::PublishNew,
@@ -85,6 +87,7 @@ pub fn publish(req: &mut ConduitRequest) -> EndpointResult {
     let api_token_id = auth.api_token_id();
     let user = auth.user();
 
+    let conn = app.primary_database.get()?;
     let verified_email_address = user.verified_email(&conn)?;
     let verified_email_address = verified_email_address.ok_or_else(|| {
         cargo_err(&format!(