tarball/manifest: Explicitly check that version field exists

Author: Turbo87

crates/crates_io_tarball/src/manifest.rs

@@ -24,11 +24,17 @@ pub fn validate_manifest(manifest: &Manifest) -> Result<(), Error> {
 }
 
 pub fn validate_package(package: &Package) -> Result<(), Error> {
+    // Check that the `version` field exists in the package table.
+    let version = package
+        .version
+        .as_ref()
+        .ok_or(Error::Other("missing field `version`".to_string()))?;
+
     // These checks ensure that package field workspace inheritance has been
     // normalized by cargo before publishing.
     if package.edition.is_inherited()
         || package.rust_version.is_inherited()
-        || package.version.is_inherited()
+        || version.is_inherited()
         || package.authors.is_inherited()
         || package.description.is_inherited()
         || package.homepage.is_inherited()

src/tests/krate/publish/snapshots/all__krate__publish__manifest__invalid_manifest_missing_version.snap

@@ -1,11 +1,11 @@
 ---
 source: src/tests/krate/publish/manifest.rs
-expression: response.into_json()
+expression: response.json()
 ---
 {
   "errors": [
     {
-      "detail": "failed to parse `Cargo.toml` manifest file\n\nTOML parse error at line 1, column 1\n  |\n1 | [package]\n  | ^^^^^^^^^\nmissing field `version`\n"
+      "detail": "failed to parse `Cargo.toml` manifest file\n\nmissing field `version`"
     }
   ]
 }