Auto merge of #1933 - jtgeibel:ok-true, r=carols10cents

Convert more endpoints to `ok_true()`

Author: bors

src/controllers/user/me.rs

@@ -165,11 +165,7 @@ pub fn update_user(req: &mut dyn Request) -> AppResult<Response> {
         Ok(())
     })?;
 
-    #[derive(Serialize)]
-    struct R {
-        ok: bool,
-    }
-    Ok(req.json(&R { ok: true }))
+    ok_true()
 }
 
 /// Handles the `PUT /confirm/:email_token` route
@@ -187,11 +183,7 @@ pub fn confirm_user_email(req: &mut dyn Request) -> AppResult<Response> {
         return Err(bad_request("Email belonging to token not found."));
     }
 
-    #[derive(Serialize)]
-    struct R {
-        ok: bool,
-    }
-    Ok(req.json(&R { ok: true }))
+    ok_true()
 }
 
 /// Handles `PUT /user/:user_id/resend` route
@@ -218,11 +210,7 @@ pub fn regenerate_token_and_send(req: &mut dyn Request) -> AppResult<Response> {
             .map_err(|_| bad_request("Error in sending email"))
     })?;
 
-    #[derive(Serialize)]
-    struct R {
-        ok: bool,
-    }
-    Ok(req.json(&R { ok: true }))
+    ok_true()
 }
 
 /// Handles `PUT /me/email_notifications` route
@@ -275,9 +263,5 @@ pub fn update_email_notifications(req: &mut dyn Request) -> AppResult<Response>
         .set(email_notifications.eq(excluded(email_notifications)))
         .execute(&*conn)?;
 
-    #[derive(Serialize)]
-    struct R {
-        ok: bool,
-    }
-    Ok(req.json(&R { ok: true }))
+    ok_true()
 }

src/controllers/version/yank.rs

@@ -48,9 +48,5 @@ fn modify_yank(req: &mut dyn Request, yanked: bool) -> AppResult<Response> {
         .enqueue(&conn)
         .map_err(|e| AppError::from_std_error(e))?;
 
-    #[derive(Serialize)]
-    struct R {
-        ok: bool,
-    }
-    Ok(req.json(&R { ok: true }))
+    ok_true()
 }