Remove unnecessary derefs (#5070)

Author: Turbo87

src/boot/categories.rs

@@ -105,11 +105,11 @@ pub fn sync_with_connection(toml_str: &str, conn: &PgConnection) -> Result<()> {
                 description.eq(excluded(description)),
             ))
             .returning(slug)
-            .get_results(&*conn)?;
+            .get_results(conn)?;
 
         diesel::delete(categories)
             .filter(slug.ne(all(slugs)))
-            .execute(&*conn)?;
+            .execute(conn)?;
         Ok(())
     })
 }

src/controllers/krate/publish.rs

@@ -328,7 +328,7 @@ pub fn add_dependencies(
 
             // Match only identical names to ensure the index always references the original crate name
             let krate:Crate = Crate::by_exact_name(&dep.name)
-                .first(&*conn)
+                .first(conn)
                 .map_err(|_| cargo_err(&format_args!("no known crate named `{}`", &*dep.name)))?;
 
             if let Ok(version_req) = semver::VersionReq::parse(&dep.version_req.0) {

src/controllers/version/downloads.rs

@@ -107,7 +107,7 @@ pub fn download(req: &mut dyn RequestExt) -> EndpointResult {
         .app()
         .config
         .uploader()
-        .crate_location(&crate_name, &*version);
+        .crate_location(&crate_name, version);
 
     if req.wants_json() {
         Ok(req.json(&json!({ "url": redirect_url })))

src/models/crate_owner_invitation.rs

@@ -84,13 +84,13 @@ impl CrateOwnerInvitation {
     pub fn find_by_id(user_id: i32, crate_id: i32, conn: &PgConnection) -> AppResult<Self> {
         Ok(crate_owner_invitations::table
             .find((user_id, crate_id))
-            .first::<Self>(&*conn)?)
+            .first::<Self>(conn)?)
     }
 
     pub fn find_by_token(token: &str, conn: &PgConnection) -> AppResult<Self> {
         Ok(crate_owner_invitations::table
             .filter(crate_owner_invitations::token.eq(token))
-            .first::<Self>(&*conn)?)
+            .first::<Self>(conn)?)
     }
 
     pub fn accept(self, conn: &PgConnection, config: &config::Server) -> AppResult<()> {

src/models/keyword.rs

@@ -27,7 +27,7 @@ impl Keyword {
     pub fn find_by_keyword(conn: &PgConnection, name: &str) -> QueryResult<Keyword> {
         keywords::table
             .filter(keywords::keyword.eq(lower(name)))
-            .first(&*conn)
+            .first(conn)
     }
 
     pub fn find_or_create_all(conn: &PgConnection, names: &[&str]) -> QueryResult<Vec<Keyword>> {

src/models/user.rs

@@ -166,15 +166,15 @@ impl User {
         Email::belonging_to(self)
             .select(emails::email)
             .filter(emails::verified.eq(true))
-            .first(&*conn)
+            .first(conn)
             .optional()
     }
 
     /// Queries for the email belonging to a particular user
     pub fn email(&self, conn: &PgConnection) -> AppResult<Option<String>> {
         Ok(Email::belonging_to(self)
             .select(emails::email)
-            .first(&*conn)
+            .first(conn)
             .optional()?)
     }
 }

src/tests/krate/publish.rs

@@ -34,7 +34,7 @@ fn uploading_new_version_touches_crate() {
     app.db(|conn| {
         diesel::update(crates::table)
             .set(crates::updated_at.eq(crates::updated_at - 1.hour()))
-            .execute(&*conn)
+            .execute(conn)
             .unwrap();
     });
 

src/tests/krate/search.rs

@@ -336,19 +336,19 @@ fn exact_match_on_queries_with_sort() {
         // Set the updated at column for each crate
         update(&krate1)
             .set(crates::updated_at.eq(now - 3.weeks()))
-            .execute(&*conn)
+            .execute(conn)
             .unwrap();
         update(&krate2)
             .set(crates::updated_at.eq(now - 5.days()))
-            .execute(&*conn)
+            .execute(conn)
             .unwrap();
         update(&krate3)
             .set(crates::updated_at.eq(now - 10.seconds()))
-            .execute(&*conn)
+            .execute(conn)
             .unwrap();
         update(&krate4)
             .set(crates::updated_at.eq(now))
-            .execute(&*conn)
+            .execute(conn)
             .unwrap();
     });
 

src/tests/krate/summary.rs

@@ -77,7 +77,7 @@ fn summary_new_crates() {
         // set total_downloads global value for `num_downloads` prop
         update(metadata::table)
             .set(metadata::total_downloads.eq(6000))
-            .execute(&*conn)
+            .execute(conn)
             .unwrap();
     });
 

src/tests/user.rs

@@ -437,7 +437,7 @@ fn github_with_email_does_not_overwrite_email() {
     let original_email: String = app.db(|conn| {
         Email::belonging_to(model)
             .select(emails::email)
-            .first(&*conn)
+            .first(conn)
             .unwrap()
     });
 
@@ -573,7 +573,7 @@ fn test_confirm_user_email() {
     let email_token: String = app.db(|conn| {
         Email::belonging_to(user_model)
             .select(emails::token)
-            .first(&*conn)
+            .first(conn)
             .unwrap()
     });
 
@@ -747,7 +747,7 @@ fn test_update_email_notifications_not_owned() {
             crate_owners::table
                 .select(crate_owners::email_notifications)
                 .filter(crate_owners::crate_id.eq(not_my_crate.id))
-                .first(&*conn)
+                .first(conn)
         })
         .unwrap();
 

src/worker/readmes.rs

@@ -32,7 +32,7 @@ pub fn render_and_upload_readme(
             .find(version_id)
             .inner_join(crates::table)
             .select((crates::name, versions::num))
-            .first(&*conn)?;
+            .first(conn)?;
         env.uploader
             .upload_readme(env.http_client(), &crate_name, &vers, rendered)?;
         Ok(())