Skip to content

Commit 2988a76

Browse files
committed
Auto merge of #3855 - Turbo87:tracing, r=pietroalbini
Revert "sentry: Enable `tracing` feature" This reverts commit 43ac758. Using `tracing_subscriber::fmt::layer()` disabled the `RUST_LOG` based env filter. But if we add the filter to the registry it basically disables the breadcrumb tracing for Sentry. https://docs.rs/tracing-subscriber/0.2.20/tracing_subscriber/layer/trait.Layer.html#filtering-with-layers has more information on this. Until we find a way to filter what the `fmt` subscriber prints without disabling the breadcrumbs for Sentry we should probably not use their `tracing` integration.
2 parents a53bc81 + 26534c8 commit 2988a76

File tree

3 files changed

+2
-18
lines changed

3 files changed

+2
-18
lines changed

Cargo.lock

Lines changed: 0 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ rand = "0.8"
7474
reqwest = { version = "0.11", features = ["blocking", "gzip", "json"] }
7575
scheduled-thread-pool = "0.2.0"
7676
semver = { version = "1.0.3", features = ["serde"] }
77-
sentry = { version = "0.23.0", features = ["tracing"] }
77+
sentry = "0.23.0"
7878
serde = { version = "1.0.0", features = ["derive"] }
7979
serde_json = "1.0.0"
8080
sha2 = "0.9"

src/bin/server.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ use sentry::{ClientOptions, IntoDsn};
1111
use std::io::Write;
1212
use tokio::io::AsyncWriteExt;
1313
use tokio::signal::unix::{signal, SignalKind};
14-
use tracing_subscriber::prelude::*;
1514

1615
const CORE_THREADS: usize = 4;
1716

@@ -34,10 +33,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
3433
});
3534

3635
// Initialize logging
37-
tracing_subscriber::registry()
38-
.with(tracing_subscriber::fmt::layer())
39-
.with(sentry::integrations::tracing::layer())
40-
.init();
36+
tracing_subscriber::fmt::init();
4137

4238
let config = cargo_registry::config::Server::default();
4339
let env = config.env();

0 commit comments

Comments
 (0)