Auto merge of #3359 - rust-lang:renovate/ember-template-lint-3.x, r=Turbo87

Update dependency ember-template-lint to v3

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ember-template-lint](https://togithub.com/ember-template-lint/ember-template-lint) | [`2.21.0` -> `3.1.0`](https://renovatebot.com/diffs/npm/ember-template-lint/2.21.0/3.1.0) | [![age](https://badges.renovateapi.com/packages/npm/ember-template-lint/3.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/ember-template-lint/3.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/ember-template-lint/3.1.0/compatibility-slim/2.21.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/ember-template-lint/3.1.0/confidence-slim/2.21.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>ember-template-lint/ember-template-lint</summary>

### [`v3.1.0`](https://togithub.com/ember-template-lint/ember-template-lint/blob/master/CHANGELOG.md#v310-2021-03-07)

[Compare Source](https://togithub.com/ember-template-lint/ember-template-lint/compare/v3.0.1...v3.1.0)

##### 🚀 Enhancement

-   [#&#8203;1340](https://togithub.com/ember-template-lint/ember-template-lint/pull/1340) Add `--format` option to allow loading custom formatters ([`@&#8203;gabrielcsapo](https://togithub.com/gabrielcsapo))`

##### 🐛 Bug Fix

-   [#&#8203;1822](https://togithub.com/ember-template-lint/ember-template-lint/pull/1822) Prevent `no-duplicate-landmark-elements` false positive for non-landmark roles ([`@&#8203;rwjblue](https://togithub.com/rwjblue))`

##### 📝 Documentation

-   [#&#8203;1816](https://togithub.com/ember-template-lint/ember-template-lint/pull/1816) docs: for disabling todos decay days ([`@&#8203;timiyay](https://togithub.com/timiyay))`

##### Committers: 3

-   Gabriel Csapo ([`@&#8203;gabrielcsapo](https://togithub.com/gabrielcsapo))`
-   Robert Jackson ([`@&#8203;rwjblue](https://togithub.com/rwjblue))`
-   [`@&#8203;timiyay](https://togithub.com/timiyay)`

### [`v3.0.1`](https://togithub.com/ember-template-lint/ember-template-lint/blob/master/CHANGELOG.md#v301-2021-03-03)

[Compare Source](https://togithub.com/ember-template-lint/ember-template-lint/compare/v3.0.0...v3.0.1)

##### 🐛 Bug Fix

-   [#&#8203;1807](https://togithub.com/ember-template-lint/ember-template-lint/pull/1807) Remove `deprecated-each-syntax` from `recommended` config ([`@&#8203;rwjblue](https://togithub.com/rwjblue))`
-   [#&#8203;1806](https://togithub.com/ember-template-lint/ember-template-lint/pull/1806) Ensure `no-bare-strings` check's `placeholder` attribute for `<Input />` and `<Textarea />` ([`@&#8203;lifeart](https://togithub.com/lifeart))`
-   [#&#8203;1805](https://togithub.com/ember-template-lint/ember-template-lint/pull/1805) Ensure `no-unknown-arguments-for-builtin-components` allows ``@query`` only `<LinkTo>`'s ([`@&#8203;lifeart](https://togithub.com/lifeart))`

##### Committers: 3

-   Alex Kanunnikov ([`@&#8203;lifeart](https://togithub.com/lifeart))`
-   Bryan Mishkin ([`@&#8203;bmish](https://togithub.com/bmish))`
-   Robert Jackson ([`@&#8203;rwjblue](https://togithub.com/rwjblue))`

### [`v3.0.0`](https://togithub.com/ember-template-lint/ember-template-lint/blob/master/CHANGELOG.md#v300-2021-03-02)

[Compare Source](https://togithub.com/ember-template-lint/ember-template-lint/compare/v2.21.0...v3.0.0)

##### Highlights

-   🚀 Added new todo feature. Allows for 'stashing' lint violations away to be fixed at a later date. [Read more in our docs!](https://togithub.com/ember-template-lint/ember-template-lint/blob/master/docs/todos.md)
-   💥 JavaScript API Changes
    -   Allow rules to have async `visitor` functions
    -   Change the internal linter class's `.verify`/`.verifyAndFix` methods to be asynchronous
-   💥 Changes to configuration (adding more rules)
    -   Promoted "octane" config to be "recommended"
    -   Added the following to `recommended`
        -   `builtin-component-arguments`
        -   `deprecated-each-syntax`
        -   `deprecated-inline-view-helper`
        -   `no-accesskey-attribute`
        -   `no-action`
        -   `no-arguments-for-html-elements`
        -   `no-aria-hidden-body`
        -   `no-block-params-for-html-elements`
        -   `no-down-event-binding`
        -   `no-duplicate-id`
        -   `no-duplicate-landmark-elements`
        -   `no-forbidden-elements`
        -   `no-heading-inside-button`
        -   `no-invalid-block-param-definition`
        -   `no-invalid-link-title`
        -   `no-link-to-positional-params`
        -   `no-nested-landmark`
        -   `no-nested-splattributes`
        -   `no-passed-in-event-handlers`
        -   `no-positional-data-test-selectors`
        -   `no-potential-path-strings`
        -   `no-redundant-fn`
        -   `no-redundant-landmark-role`
        -   `no-unbalanced-curlies`
        -   `no-unknown-arguments-for-builtin-components`
        -   `no-yield-only`
        -   `require-has-block-helper`
        -   `require-input-label`
        -   `require-lang-attribute`
        -   `splat-attributes-only`

##### 💥 Breaking Change

-   [#&#8203;1714](https://togithub.com/ember-template-lint/ember-template-lint/pull/1714) Update recommended config to include 'no-down-event-binding' ([`@&#8203;MelSumner](https://togithub.com/MelSumner))`
-   [#&#8203;1697](https://togithub.com/ember-template-lint/ember-template-lint/pull/1697) Allow rule visitor to be an async function (remove `env` argument) ([`@&#8203;lifeart](https://togithub.com/lifeart))`
-   [#&#8203;1388](https://togithub.com/ember-template-lint/ember-template-lint/pull/1388) Remove automatic `TextNode` unwrapping by `attributeValue` functions in `ast-node-info` helper ([`@&#8203;josephdsumner](https://togithub.com/josephdsumner))`
-   [#&#8203;1643](https://togithub.com/ember-template-lint/ember-template-lint/pull/1643) Enable more `recommended` rules ([`@&#8203;bmish](https://togithub.com/bmish))`
-   [#&#8203;1642](https://togithub.com/ember-template-lint/ember-template-lint/pull/1642) Update `noImplicitThis` option default to true and `requireDash` option default to false in `no-curly-component-invocation` rule ([`@&#8203;bmish](https://togithub.com/bmish))`
-   [#&#8203;1639](https://togithub.com/ember-template-lint/ember-template-lint/pull/1639) Promote `octane` rules to `recommended` config and delete `octane` config ([`@&#8203;bmish](https://togithub.com/bmish))`
-   [#&#8203;1638](https://togithub.com/ember-template-lint/ember-template-lint/pull/1638) Add more rules to `stylistic` config ([`@&#8203;bmish](https://togithub.com/bmish))`
-   [#&#8203;1586](https://togithub.com/ember-template-lint/ember-template-lint/pull/1586) Add `no-aria-hidden-body` and `table-groups` rules to `a11y` config ([`@&#8203;MelSumner](https://togithub.com/MelSumner))`
-   [#&#8203;1549](https://togithub.com/ember-template-lint/ember-template-lint/pull/1549) Add `<textarea>` and `<select>` support to `require-input-label` rule ([`@&#8203;zelaznik](https://togithub.com/zelaznik))`
-   [#&#8203;1553](https://togithub.com/ember-template-lint/ember-template-lint/pull/1553) Convert `Linter.prototype.verify` and `Linter.prototype.verifyAndFix` to be async. ([`@&#8203;scalvert](https://togithub.com/scalvert))`
-   [#&#8203;1532](https://togithub.com/ember-template-lint/ember-template-lint/pull/1532) Add `s` and `u` elements to `no-obsolete-elements` rule elements list ([`@&#8203;bmish](https://togithub.com/bmish))`
-   [#&#8203;1535](https://togithub.com/ember-template-lint/ember-template-lint/pull/1535) Remove support for deprecated rule names ([`@&#8203;bmish](https://togithub.com/bmish))`
-   [#&#8203;1534](https://togithub.com/ember-template-lint/ember-template-lint/pull/1534) Enable `catchNonexistentRoles` by default on `no-invalid-role` rule ([`@&#8203;bmish](https://togithub.com/bmish))`
-   [#&#8203;1513](https://togithub.com/ember-template-lint/ember-template-lint/pull/1513) Fix `extends` overriding order ([`@&#8203;Turbo87](https://togithub.com/Turbo87))`
-   [#&#8203;1490](https://togithub.com/ember-template-lint/ember-template-lint/pull/1490) remove deprecated `whitelist` & `blacklist` configurations ([`@&#8203;jaydgruber](https://togithub.com/jaydgruber))`
-   [#&#8203;1463](https://togithub.com/ember-template-lint/ember-template-lint/pull/1463) ast-node-info: Remove trivial `isNode()` helpers ([`@&#8203;Turbo87](https://togithub.com/Turbo87))`
-   [#&#8203;1460](https://togithub.com/ember-template-lint/ember-template-lint/pull/1460) ast-node-info: Remove trivial `isElement()` helpers ([`@&#8203;Turbo87](https://togithub.com/Turbo87))`
-   [#&#8203;1452](https://togithub.com/ember-template-lint/ember-template-lint/pull/1452) Drop support for Node 13 ([`@&#8203;MelSumner](https://togithub.com/MelSumner))`
-   [#&#8203;1549](https://togithub.com/ember-template-lint/ember-template-lint/pull/1549) Add `<textarea>` and `<select>` support to `require-input-label` rule ([`@&#8203;zelaznik](https://togithub.com/zelaznik))`
-   [#&#8203;1513](https://togithub.com/ember-template-lint/ember-template-lint/pull/1513) / [#&#8203;1687](https://togithub.com/ember-template-lint/ember-template-lint/pull/1687) Fix `extends` overriding order ([`@&#8203;Turbo87](https://togithub.com/Turbo87))` / ([`@&#8203;renatoi](https://togithub.com/renatoi))`

##### 🚀 Enhancement

-   [#&#8203;1710](https://togithub.com/ember-template-lint/ember-template-lint/pull/1710) Adds `octane` config as an alias of `recommended` ([`@&#8203;scalvert](https://togithub.com/scalvert))`
-   Implement Todo feature, please review our [documentation here](https://togithub.com/ember-template-lint/ember-template-lint/blob/master/docs/todos.md) ([`@&#8203;scalvert](https://togithub.com/scalvert))` / ([`@&#8203;renatoi](https://togithub.com/renatoi))`
-   [#&#8203;1629](https://togithub.com/ember-template-lint/ember-template-lint/pull/1629) chore(deps): bump ember-template-recast from 4.2.1 to 5.0.1 ([`@&#8203;dependabot-preview\[bot\]](https://togithub.com/apps/dependabot-preview))`
-   [#&#8203;1595](https://togithub.com/ember-template-lint/ember-template-lint/pull/1595) Allow passing a top-level `meta` property in test harness ([`@&#8203;rwjblue](https://togithub.com/rwjblue))`
-   [#&#8203;1556](https://togithub.com/ember-template-lint/ember-template-lint/pull/1556) Allow linting individual files with arbitrary extensions. ([`@&#8203;rwjblue](https://togithub.com/rwjblue))`
-   [#&#8203;1631](https://togithub.com/ember-template-lint/ember-template-lint/pull/1631) Add `rootURL` to ignore list for index.html ([`@&#8203;scalvert](https://togithub.com/scalvert))`

##### Committers: 14

-   Alex Kanunnikov ([`@&#8203;lifeart](https://togithub.com/lifeart))`
-   Alex LaFroscia ([`@&#8203;alexlafroscia](https://togithub.com/alexlafroscia))`
-   Bryan Mishkin ([`@&#8203;bmish](https://togithub.com/bmish))`
-   Collin Adams ([`@&#8203;collinadams](https://togithub.com/collinadams))`
-   Joseph D. Sumner ([`@&#8203;josephdsumner](https://togithub.com/josephdsumner))`
-   Melanie Sumner ([`@&#8203;MelSumner](https://togithub.com/MelSumner))`
-   Rajasegar Chandran ([`@&#8203;rajasegar](https://togithub.com/rajasegar))`
-   Renato Iwashima ([`@&#8203;renatoi](https://togithub.com/renatoi))`
-   Robert Jackson ([`@&#8203;rwjblue](https://togithub.com/rwjblue))`
-   Steve Calvert ([`@&#8203;scalvert](https://togithub.com/scalvert))`
-   Steve Zelaznik ([`@&#8203;zelaznik](https://togithub.com/zelaznik))`
-   Tobias Bieniek ([`@&#8203;Turbo87](https://togithub.com/Turbo87))`
-   [`@&#8203;jaydgruber](https://togithub.com/jaydgruber)`

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/rust-lang/crates.io).

Author: bors

app/components/page-header.hbs

@@ -1,5 +1,5 @@
 <div local-class="header" data-test-page-header ...attributes>
-  {{#if hasBlock}}
+  {{#if (has-block)}}
     {{yield}}
   {{else}}
     <h1 local-class="heading">

app/components/pagination.hbs

@@ -1,17 +1,17 @@
 <nav local-class='pagination' aria-label="Pagination navigation">
-  <LinkTo @query={{hash page=@pagination.prevPage}} local-class="prev" @rel="prev" @title="previous page" data-test-pagination-prev>
+  <LinkTo @query={{hash page=@pagination.prevPage}} local-class="prev" rel="prev" title="previous page" data-test-pagination-prev>
     {{svg-jar "left-pag"}}
   </LinkTo>
   <ol>
     {{#each @pagination.pages as |page|}}
       <li>
-        <LinkTo @query={{hash page=page}} @title={{concat "Go to page " page}}>
+        <LinkTo @query={{hash page=page}} title={{concat "Go to page " page}}>
           {{ page }}
         </LinkTo>
       </li>
     {{/each}}
   </ol>
-  <LinkTo @query={{hash page=@pagination.nextPage}} local-class="next" @rel="next" @title="next page" data-test-pagination-next>
+  <LinkTo @query={{hash page=@pagination.nextPage}} local-class="next" rel="next" title="next page" data-test-pagination-next>
     {{svg-jar "right-pag"}}
   </LinkTo>
 </nav>

app/components/settings/api-tokens.hbs

@@ -30,7 +30,7 @@
         <Input
           @type="text"
           placeholder="New token name"
-          @disabled={{this.newToken.isSaving}}
+          disabled={{this.newToken.isSaving}}
           @value={{this.newToken.name}}
           data-test-focused-input
           {{auto-focus}}

app/styles/crates.module.css

@@ -16,20 +16,28 @@
     a:hover { background-color: var(--main-bg-dark); }
     a:global(.active) { background-color: var(--main-bg-dark); }
 
-    select {
-        display: none;
-        width: 100%;
-        padding: 5px;
-    }
-
     @media only screen and (max-width: 650px) {
         padding: 0;
         background-color: inherit;
         a { display: none; }
-        select { display: block; }
     }
 }
 
+.filter-dropdown-label {
+    display: none;
+
+    @media only screen and (max-width: 650px) {
+        display: flex;
+        align-items: center;
+        width: 100%;
+    }
+}
+
+.filter-dropdown {
+    flex-grow: 1;
+    margin-left: 20px;
+}
+
 .results-meta {
     display: flex;
     align-items: center;

app/templates/crate/owners.hbs

@@ -9,7 +9,7 @@
     <label local-class="email-input-label" for='new-owner-username'>
       Username
     </label>
-    <Input @type="text" id="new-owner-username" @value={{this.username}} placeholder="Username" local-class="email-input" @name="username" />
+    <Input @type="text" id="new-owner-username" @value={{this.username}} placeholder="Username" local-class="email-input" name="username" />
     <button type="submit" disabled={{not this.username}} local-class="submit-button" data-test-save-button>Save</button>
   </form>
 </div>

app/templates/crates.hbs

@@ -9,12 +9,16 @@
     </LinkTo>
   {{/each}}
 
-  <select {{on "change" this.handleSelection}}>
-    <option>Filter by the letter...</option>
-    {{#each this.alphabet as |letter|}}
-      <option value={{letter}} selected={{eq letter this.letter}}>{{ letter }}</option>
-    {{/each}}
-  </select>
+  <label local-class="filter-dropdown-label">
+    Filter by letter:
+
+    <select local-class="filter-dropdown" {{on "change" this.handleSelection}}>
+      <option value="">No Filter</option>
+      {{#each this.alphabet as |letter|}}
+        <option value={{letter}} selected={{eq letter this.letter}}>{{ letter }}</option>
+      {{/each}}
+    </select>
+  </label>
 </div>
 
 <div local-class="results-meta">

package.json

@@ -103,7 +103,7 @@
     "ember-set-body-class": "1.0.2",
     "ember-source": "3.25.1",
     "ember-svg-jar": "2.3.3",
-    "ember-template-lint": "2.21.0",
+    "ember-template-lint": "3.1.0",
     "ember-test-selectors": "5.0.0",
     "ember-tooltips": "3.4.7",
     "ember-truth-helpers": "3.0.0",

yarn.lock

@@ -1072,6 +1072,16 @@
     ember-cli-typescript "^4.0.0"
     heimdalljs "^0.3.0"
 
+"@ember-template-lint/todo-utils@^8.0.0-beta.3":
+  version "8.0.0-beta.3"
+  resolved "https://registry.yarnpkg.com/@ember-template-lint/todo-utils/-/todo-utils-8.0.0-beta.3.tgz#9a048c2787c781f80a6ae682787fbfcb5ea8e03d"
+  integrity sha512-L0XXY8U6Jk4c4OGSydhxa5K3/kyUpaqc6IpYW4wU8g1yu/zOj7XgKgmp48+t3dt1p6Xa+CHKnD1I86m99BEYXg==
+  dependencies:
+    "@types/eslint" "^7.2.6"
+    fs-extra "^9.0.1"
+    slash "^3.0.0"
+    tslib "^2.1.0"
+
 "@ember/edition-utils@^1.2.0":
   version "1.2.0"
   resolved "https://registry.yarnpkg.com/@ember/edition-utils/-/edition-utils-1.2.0.tgz#a039f542dc14c8e8299c81cd5abba95e2459cfa6"
@@ -2012,6 +2022,14 @@
   resolved "https://registry.yarnpkg.com/@types/ember__utils/-/ember__utils-3.16.2.tgz#3fa9a0666a3e8204262e2a2960289aaf01f29467"
   integrity sha512-tBbqewgegiKSpGZvGh3pbcoXwLCMvKVdLRE97vys75nAEz/vBzkGJm+PDz1HVaTkRukWbRhlDiTm2qFH8qRnSw==
 
+"@types/eslint@^7.2.6":
+  version "7.2.6"
+  resolved "https://registry.yarnpkg.com/@types/eslint/-/eslint-7.2.6.tgz#5e9aff555a975596c03a98b59ecd103decc70c3c"
+  integrity sha512-I+1sYH+NPQ3/tVqCeUSBwTE/0heyvtXqpIopUUArlBm0Kpocb8FbMa3AZ/ASKIFpN3rnEx932TTXDbt9OXsNDw==
+  dependencies:
+    "@types/estree" "*"
+    "@types/json-schema" "*"
+
 "@types/estree@*":
   version "0.0.46"
   resolved "https://registry.yarnpkg.com/@types/estree/-/estree-0.0.46.tgz#0fb6bfbbeabd7a30880504993369c4bf1deab1fe"
@@ -2070,7 +2088,7 @@
   dependencies:
     "@types/sizzle" "*"
 
-"@types/json-schema@^7.0.5":
+"@types/json-schema@*", "@types/json-schema@^7.0.5":
   version "7.0.7"
   resolved "https://registry.yarnpkg.com/@types/json-schema/-/json-schema-7.0.7.tgz#98a993516c859eb0d5c4c8f098317a9ea68db9ad"
   integrity sha512-cxWFQVseBm6O9Gbw1IWb8r6OS4OhSt3hPZLkFApLjM8TEXROBuQGLAH2i2gZpcXdLBIrpXuTDhH7Vbm1iXmNGA==
@@ -7023,11 +7041,12 @@ ember-svg-jar@2.3.3:
     mkdirp "^0.5.1"
     path-posix "^1.0.0"
 
-ember-template-lint@2.21.0:
-  version "2.21.0"
-  resolved "https://registry.yarnpkg.com/ember-template-lint/-/ember-template-lint-2.21.0.tgz#7e120abf309a8810eeed26c52377943faf15a95b"
-  integrity sha512-19QbEqJQdMfcRS7PsQsubflRowEtnkbD0tpYR4q/xq4lodmhU7hhOFvlTQgbxD/jwW5Ur+tkOwH4KFy9JwOyXA==
+ember-template-lint@3.1.0:
+  version "3.1.0"
+  resolved "https://registry.yarnpkg.com/ember-template-lint/-/ember-template-lint-3.1.0.tgz#3f634c733ac5e4b19d8ad782b653b02da04910cd"
+  integrity sha512-muGPBr71ZfesSxYtm6lLqbO3mpGh8JJnamqByPdN474/7MNexWGvmWDvV7bklrQ7UOoZ66Miu/0WRb9PYPrX9w==
   dependencies:
+    "@ember-template-lint/todo-utils" "^8.0.0-beta.3"
     chalk "^4.0.0"
     ember-template-recast "^5.0.1"
     find-up "^5.0.0"
@@ -14213,7 +14232,7 @@ tslib@^1, tslib@^1.9.0, tslib@^1.9.3:
   resolved "https://registry.yarnpkg.com/tslib/-/tslib-1.14.1.tgz#cf2d38bdc34a134bcaf1091c41f6619e2f672d00"
   integrity sha512-Xni35NKzjgMrwevysHTCArtLDpPvye8zV/0E4EyYn43P7/7qvQwPh9BGkHewbMulVntbigmcT7rdX3BNo9wRJg==
 
-tslib@^2.0.0, tslib@^2.0.3:
+tslib@^2.0.0, tslib@^2.0.3, tslib@^2.1.0:
   version "2.1.0"
   resolved "https://registry.yarnpkg.com/tslib/-/tslib-2.1.0.tgz#da60860f1c2ecaa5703ab7d39bc05b6bf988b97a"
   integrity sha512-hcVC3wYEziELGGmEEXue7D75zbwIIVUMWAVbHItGPx0ziyXxrOMQx4rQEVEV45Ut/1IotuEvwqPopzIOkDMf0A==