Skip to content

Commit f7921da

Browse files
Update posts/2021-07-29-Rust-1.54.0.md
Co-authored-by: Esteban Kuber <estebank@users.noreply.github.com>
1 parent ebacba6 commit f7921da

File tree

1 file changed

+18
-2
lines changed

1 file changed

+18
-2
lines changed

posts/2021-07-29-Rust-1.54.0.md

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,26 @@ Notably, unlike the previously stabilized `x86` and `x86_64` intrinsics, these d
5252

5353
This means that we can expose some of the intrinsics as entirely safe functions, for example [`v128_bitselect`](https://doc.rust-lang.org/beta/core/arch/wasm32/fn.v128_bitselect.html). However, there are still some intrinsics which are unsafe because they use raw pointers, such as [`v128_load`](https://doc.rust-lang.org/beta/core/arch/wasm32/fn.v128_load.html).
5454

55-
### Incremental Compilation is XXX by default
55+
### Incremental Compilation is re-enabled by default
5656

57-
TODO - Wesley is going to draft text here.
57+
Incremental compilation has been re-enabled by default in this release, after it being disabled by default in 1.52.
5858

59+
In Rust 1.52, additional validation was added when loading incremental compilation data from the on-disk cache.
60+
This resulted in a number of pre-existing potential soundness issues being uncovered as the validation changed these silent bugs into internal compiler errors (ICEs).
61+
In response, the Compiler Team decided to disable incremental compilation in the 1.52.1 patch, allowing users to avoid encountering the ICEs and the underlying unsoundness, at the expense of longer compile times. [^1]
62+
63+
Since then, we've conducted a [series of retrospectives][retros] and contributors have been hard at work resolving the reported issues, with some fixes landing in 1.53 and the majority landing in this release. [^2]
64+
65+
There are currently still two known issues which can result in an ICE.
66+
Due to the lack of automated crash reporting, we can't be certain of the full extent of impact of the outstanding issues. However, based on the feedback we received from users affected by the 1.52 release, we believe these issues to be rare.
67+
68+
Therefore, incremental compilation has been re-enabled in this release!
69+
70+
[^1]: The [1.52.1 release notes] contain a more detailed description of these events.
71+
[^2]: The tracking issue for the issues is [#84970].
72+
[#84970]: https://github.com/rust-lang/rust/issues/84970
73+
[1.52.1 release notes]: https://blog.rust-lang.org/2021/05/10/Rust-1.52.1.html
74+
[retros]: https://github.com/rust-lang/compiler-team/issues/435
5975
### Stabilized APIs
6076

6177
The following methods and trait implementations were stabilized.

0 commit comments

Comments
 (0)