Skip to content

Commit eb848bf

Browse files
committed
Review comments
1 parent 03422d3 commit eb848bf

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

content/c-abi-changes-for-wasm32-unknown-unknown.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ the non-standard definition remained in use for `wasm32-unknown-unknown`.
3434
The time has now come to correct this historical mistake and the Rust compiler
3535
will soon be using a correct ABI definition for the `wasm32-unknown-unknown`
3636
target. This means, however, that generated WebAssembly binaries will be
37-
different than before?
37+
different than before.
3838

3939
## What is a WebAssembly C ABI?
4040

@@ -129,6 +129,10 @@ Here we can see, sure enough, that `pair` is passed in linear memory and this
129129
function only has a single argument, not two. This argument is a pointer into
130130
linear memory which stores the `x` and `y` fields.
131131

132+
The Diplomat project has [compiled a much more comprehensive overview][quirks]
133+
than this and it's recommended to check that out if you're curious for an even
134+
deeper dive.
135+
132136
## What hasn't this been fixed?
133137

134138
For `wasm32-unknown-unknown` it was well-known at the time in 2021 when WASI's
@@ -256,3 +260,4 @@ can be removed.
256260
[conventions-struct]: https://github.com/WebAssembly/tool-conventions/blob/main/BasicCABI.md#function-arguments-and-return-values
257261
[wasm-bindgen]: https://github.com/rustwasm/wasm-bindgen
258262
[tracking]: https://github.com/rust-lang/rust/issues/138762
263+
[quirks]: https://github.com/rust-diplomat/diplomat/blob/main/docs/wasm_abi_quirks.md

0 commit comments

Comments
 (0)