Skip to content

Commit 6c2d910

Browse files
author
Kai Luo
committed
Add FIXME for leading '.' sign of a symbol
1 parent 04845bb commit 6c2d910

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/symbolize/gimli/xcoff.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,10 @@ impl<'a> Object<'a> {
133133
};
134134
let sym = self.syms.get(i)?;
135135
if (sym.address..sym.address + sym.size).contains(&addr) {
136+
// FIXME: Should we trim the leading '.' of
137+
// the symbol of a function entry?
138+
// If not, the rust mangler might not work properly.
139+
// Or we should update rust mangler to trim the leading '.'?
136140
Some(sym.name.trim_start_matches(".").as_bytes())
137141
} else {
138142
None

0 commit comments

Comments
 (0)