From 565b82cd5774b46bca61a1443341e0276dd58486 Mon Sep 17 00:00:00 2001 From: Yuta Saito Date: Sat, 2 Jul 2022 16:22:12 +0000 Subject: [PATCH] Use `target.[[Get]](key)` directly instead of `Reflect.get` Since it denies non-objects like strings according to the spec https://262.ecma-international.org/11.0/#sec-reflect.get Also it throws just `TypeError: Reflect.get called on non-object` while `target.[[Get]]` reports `TypeError: Cannot read properties of null (reading X)` when reading non-object properties --- packages/npm-packages/ruby-wasm-wasi/src/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/npm-packages/ruby-wasm-wasi/src/index.ts b/packages/npm-packages/ruby-wasm-wasi/src/index.ts index a05cb56260..0dbc4660fd 100644 --- a/packages/npm-packages/ruby-wasm-wasi/src/index.ts +++ b/packages/npm-packages/ruby-wasm-wasi/src/index.ts @@ -139,7 +139,7 @@ export class RubyVM { throw new Error("Function not implemented."); }, reflectGet: function (target, propertyKey) { - return Reflect.get(target, propertyKey); + return target[propertyKey]; }, reflectGetOwnPropertyDescriptor: function ( target,