lint: Remove unreachable code

okuramasafumi · okuramasafumi · commit b0e7f50511aa · 2024-07-09T20:59:57.000+09:00
This is an attempt to utilize RuboCop further. RuboCop was added in 9262fdd but only a few rules have been enabled. I believe we can utilize RuboCop more for better code quality, especially with Lint cops. This is the first step to enable other Lint cops. This commit also exclude some auto generated files.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -3,8 +3,12 @@ AllCops:
   DisabledByDefault: true
   Exclude:
     - rdoc.gemspec
+    - lib/rdoc/markdown.rb # Auto generated
+    - lib/rdoc/rd/block_parser.rb # Auto generated
 
 Layout/TrailingWhitespace:
   Enabled: true
 Layout/TrailingEmptyLines:
   Enabled: true
+Lint/UnreachableCode:
+  Enabled: true
diff --git a/lib/rdoc/rdoc.rb b/lib/rdoc/rdoc.rb
@@ -395,7 +395,6 @@ def parse_file filename
     $stderr.puts e.backtrace.join("\n\t") if $DEBUG_RDOC
 
     raise e
-    nil
   end
 
   ##

-Original file line number
+Diff line change
     $stderr.puts e.backtrace.join("\n\t") if $DEBUG_RDOC
     raise e
 -    nil
   end
   ##