Merge pull request #31 from robotpy/mypy

Add mypy checking to CI

Author: virtuald

.github/workflows/dist.yml

@@ -11,9 +11,24 @@ on:
 
 jobs:
   ci:
-    uses: robotpy/build-actions/.github/workflows/package-pure.yml@v2024-alpha
+    uses: robotpy/build-actions/.github/workflows/package-pure.yml@v2024
     with:
       enable_sphinx_check: false
     secrets:
       META_REPO_ACCESS_TOKEN: ${{ secrets.REPO_ACCESS_TOKEN }}
       PYPI_API_TOKEN: ${{ secrets.PYPI_PASSWORD }}
+
+  check-mypy:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v3
+    - uses: actions/setup-python@v4
+      with:
+        python-version: "3.12"
+    - name: Install requirements
+      run: |
+        pip --disable-pip-version-check install mypy setuptools wheel setuptools_scm
+        pip --disable-pip-version-check install --no-build-isolation -e .
+    - name: Run mypy
+      run: |
+        mypy commands2

commands2/button/commandjoystick.py

@@ -13,6 +13,8 @@ class CommandJoystick(CommandGenericHID):
     A version of Joystick with Trigger factories for command-based.
     """
 
+    _hid: Joystick
+
     def __init__(self, port: int):
         """
         Construct an instance of a controller.

commands2/button/commandps4controller.py

@@ -13,6 +13,8 @@ class CommandPS4Controller(CommandGenericHID):
     A version of PS4Controller with Trigger factories for command-based.
     """
 
+    _hid: PS4Controller
+
     def __init__(self, port: int):
         """
         Construct an instance of a device.

commands2/button/commandxboxcontroller.py

@@ -13,6 +13,8 @@ class CommandXboxController(CommandGenericHID):
     A version of XboxController with Trigger factories for command-based.
     """
 
+    _hid: XboxController
+
     def __init__(self, port: int):
         """
         Construct an instance of a controller.

commands2/command.py

@@ -6,7 +6,7 @@
 from enum import Enum
 from typing import TYPE_CHECKING, Any, Callable, Set
 
-from typing_extensions import Self
+from typing_extensions import Self, TypeAlias
 
 if TYPE_CHECKING:
     from .instantcommand import InstantCommand
@@ -54,17 +54,19 @@ class Command(Sendable):
     This class is provided by the NewCommands VendorDep
     """
 
-    InterruptionBehavior = InterruptionBehavior  # type alias for 2023 location
+    InterruptionBehavior: TypeAlias = (
+        InterruptionBehavior  # type alias for 2023 location
+    )
 
     requirements: Set[Subsystem]
 
     def __new__(cls, *args, **kwargs) -> Self:
         instance = super().__new__(
             cls,
         )
-        instance.requirements = set()
-        SendableRegistry.add(instance, cls.__name__)
         super().__init__(instance)
+        SendableRegistry.add(instance, cls.__name__)
+        instance.requirements = set()
         return instance
 
     def __init__(self):

commands2/commandscheduler.py

@@ -21,9 +21,9 @@ class CommandScheduler:
     methods to be called and for their default commands to be scheduled.
     """
 
-    _instance: Optional[Self] = None
+    _instance: Optional[CommandScheduler] = None
 
-    def __new__(cls) -> Self:
+    def __new__(cls) -> CommandScheduler:
         if cls._instance is None:
             return super().__new__(cls)
         return cls._instance

commands2/util.py

@@ -1,14 +1,14 @@
 from __future__ import annotations
 
-from typing import Iterable, Tuple, Union
+from typing import Iterable, List, Tuple, Union
 
 from .command import Command
 
 
 def flatten_args_commands(
     *commands: Union[Command, Iterable[Command]]
-) -> Tuple[Command]:
-    flattened_commands = []
+) -> Tuple[Command, ...]:
+    flattened_commands: List[Command] = []
     for command in commands:
         if isinstance(command, Command):
             flattened_commands.append(command)

commands2/wrappercommand.py

@@ -26,6 +26,7 @@ def __init__(self, command: Command):
 
         CommandScheduler.getInstance().registerComposedCommands([command])
         self._command = command
+        self.setName(self._command.getName())
 
     def initialize(self):
         """The initial subroutine of a command. Called once when the command is initially scheduled."""