Skip to content

seleniumLibrary new commit #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

seleniumLibrary new commit #1529

wants to merge 1 commit into from

Conversation

ritikasaboo
Copy link

@ritikasaboo ritikasaboo commented Dec 16, 2019

Fixes #1517

@aaltat
Copy link
Contributor

aaltat commented Dec 16, 2019

Please cleanup the PR.

  1. The robot framework output files and the geckodriver.log should never be part of the PR.
  2. The Approval tests approved files should have not been changed.
  3. There is failing unit test. Because of the added argument, mock does not match, please fix it.

@aaltat
Copy link
Contributor

aaltat commented Dec 17, 2019

And write tests for the change.

@aaltat
Copy link
Contributor

aaltat commented Jan 7, 2020

@colourmein13 do you still plan to work with the PR?

@aaltat
Copy link
Contributor

aaltat commented Jan 23, 2020

Closing due inactivity. Can be reopened if there is a need.

@aaltat aaltat closed this Jan 23, 2020
@ritikasaboo
Copy link
Author

Closing due inactivity. Can be reopened if there is a need.

Hey. Apologies as I got busy with other stuff.

  1. Should I add .log to my .gitignore? What output files are you talking about?
  2. I haven't changed the content, but I see what you mean.
  3. I have fixed the failed unittest. Should I create new PR for the new tests?

@aaltat
Copy link
Contributor

aaltat commented Jan 27, 2020

No worries, we do not have schedules and working in your own pace is always recommended.

  1. Modifications to .gitignore should not be needed. It looks like you do not use atest/run.py to run the tests and therefore output files are not created in the already ignored folder. There is a readme file which explain in more details how running tests works out of the box.
  2. It looks like you have deleted to whole branch from you fork and therefore I can not reopen this PR. I think most easiest way is to create the new PR whit all the changed needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add parameter to make Wait Until Page Contains case insensitive
2 participants