Merge pull request #779 from pranc1ngpegasus/fix/migrate-to-golangci-lint-v2

fix: migrate to golangci-lint v2

Author: massongit

.github/.golangci.yml renamed to .github/.golangci.v1.yml

@@ -0,0 +1,29 @@
+# https://golangci-lint.run/usage/configuration/
+version: "2"
+linters-settings:
+  govet:
+    check-shadowing: true
+  misspell:
+    locale: US
+  errcheck:
+    check-type-assertions: false
+    check-blank: false
+
+linters:
+  default: none
+  enable:
+    - govet
+    - misspell
+    - errcheck
+  exclusions:
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+
+formatters:
+  default: none
+
+issues:
+  max-same-issues: 0

.github/.golangci.v2.yml

@@ -7,6 +7,9 @@ jobs:
   golangci-lint:
     name: runner / golangci-lint
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        golangci-lint-version: ["v1", "v2"]
     steps:
       - name: Check out code into the Go module directory
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -15,14 +18,16 @@ jobs:
         with:
           github_token: ${{ secrets.github_token }}
           level: warning
-          golangci_lint_flags: "--config=.github/.golangci.yml ./testdata"
+          golangci_lint_version: ${{ matrix.golangci-lint-version == 'v1' && 'v1.64.8' || 'latest' }}
+          golangci_lint_flags: "--config=.github/.golangci.${{ matrix.golangci-lint-version }}.yml ./testdata"
 
   golangci-lint-platform:
     name: runner / golangci-lint-platform
     strategy:
       fail-fast: false
       matrix:
         platform: [ubuntu-latest, macos-latest, windows-latest]
+        golangci-lint-version: ["v1", "v2"]
     runs-on: ${{ matrix.platform }}
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -32,7 +37,8 @@ jobs:
           github_token: ${{ secrets.github_token }}
           tool_name: golangci-lint-${{ matrix.platform }}
           level: warning
-          golangci_lint_flags: "--config=.github/.golangci.yml ./testdata --timeout 10m"
+          golangci_lint_version: ${{ matrix.golangci-lint-version == 'v1' && 'v1.64.8' || 'latest' }}
+          golangci_lint_flags: "--config=.github/.golangci.${{ matrix.golangci-lint-version }}.yml ./testdata --timeout 10m"
 
   golangci-lint-github-pr-review:
     name: runner / golangci-lint (github-pr-review)
@@ -88,7 +94,7 @@ jobs:
           github_token: ${{ secrets.github_token }}
           tool_name: "golangci-lint-all-in-one"
           level: warning
-          golangci_lint_flags: "--enable-all --exclude-use-default=false ./testdata"
+          golangci_lint_flags: "--default all ./testdata"
 
   govet:
     name: runner / govet
@@ -100,7 +106,7 @@ jobs:
         uses: ./
         with:
           github_token: ${{ secrets.github_token }}
-          golangci_lint_flags: "--disable-all -E govet ./testdata"
+          golangci_lint_flags: "--default none -E govet ./testdata"
           tool_name: govet
 
   staticcheck:
@@ -113,23 +119,9 @@ jobs:
         uses: ./
         with:
           github_token: ${{ secrets.github_token }}
-          golangci_lint_flags: "--disable-all -E staticcheck ./testdata"
+          golangci_lint_flags: "--default none -E staticcheck ./testdata"
           tool_name: staticcheck
 
-  golint:
-    name: runner / golint
-    runs-on: ubuntu-latest
-    steps:
-      - name: Check out code into the Go module directory
-        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-      - name: golint
-        uses: ./
-        with:
-          github_token: ${{ secrets.github_token }}
-          golangci_lint_flags: "--disable-all -E golint ./testdata"
-          tool_name: golint
-          level: warning
-
   errcheck:
     name: runner / errcheck
     runs-on: ubuntu-latest
@@ -140,7 +132,7 @@ jobs:
         uses: ./
         with:
           github_token: ${{ secrets.github_token }}
-          golangci_lint_flags: "--disable-all -E errcheck ./testdata"
+          golangci_lint_flags: "--default none -E errcheck ./testdata"
           tool_name: errcheck
           level: warning
 
@@ -154,7 +146,7 @@ jobs:
         uses: ./
         with:
           github_token: ${{ secrets.github_token }}
-          golangci_lint_flags: "--disable-all -E misspell ./testdata"
+          golangci_lint_flags: "--default none -E misspell ./testdata"
           tool_name: misspell
           level: info
 

.github/workflows/reviewdog.yml

@@ -0,0 +1,15 @@
+import { isGolangciLintV1 } from "../src/main";
+
+describe("isV1", () => {
+  it("should return false if the version is latest", () => {
+    expect(isGolangciLintV1("latest")).toBe(false);
+  });
+
+  it("should return true if the version is v1.x.x", () => {
+    expect(isGolangciLintV1("v1.0.0")).toBe(true);
+  });
+
+  it("should return true if the version is v2.x.x", () => {
+    expect(isGolangciLintV1("v2.0.0")).toBe(false);
+  });
+});

__test__/main.test.ts

@@ -58,14 +58,14 @@ async function run(): Promise<void> {
     }
 
     const output = await core.group("Running golangci-lint ...", async (): Promise<exec.ExecOutput> => {
-      return await exec.getExecOutput(
-        golangci,
-        ["run", "--out-format", "line-number", ...flags.parse(golangciLintFlags)],
-        {
-          cwd,
-          ignoreReturnCode: true,
-        },
-      );
+      const options = isGolangciLintV1(golangciLintVersion)
+        ? ["run", "--out-format", "line-number", ...flags.parse(golangciLintFlags)]
+        : ["run", "--output.text.path", "stdout", ...flags.parse(golangciLintFlags)];
+
+      return await exec.getExecOutput(golangci, options, {
+        cwd,
+        ignoreReturnCode: true,
+      });
     });
 
     switch (output.exitCode) {
@@ -132,4 +132,17 @@ async function run(): Promise<void> {
   }
 }
 
+export function isGolangciLintV1(version: string): boolean {
+  if (version === "latest") {
+    return false;
+  }
+
+  const match = version.match(/^v?(\d+)/);
+  if (!match) {
+    throw new Error(`Invalid golangci-lint version: ${version}`);
+  }
+
+  return parseInt(match[1], 10) === 1;
+}
+
 void run();