Skip to content

Commit db3d156

Browse files
Various improvements to test env
1 parent 0e708cd commit db3d156

File tree

3 files changed

+11
-14
lines changed

3 files changed

+11
-14
lines changed

justfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ print-target:
6464
@echo {{ _resolved_target }}
6565

6666
test: (_target-installed target)
67-
cargo nextest run {{ _target-option }} --all-features
67+
cargo nextest run {{ _target-option }} --all-features --workspace
6868

6969
doctest:
7070
cargo test --doc

test-env/src/lib.rs

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
1-
use restate_sdk::{
2-
errors::HandlerError,
3-
prelude::{Endpoint, HttpServer},
4-
};
1+
use restate_sdk::prelude::{Endpoint, HttpServer};
52
use serde::{Deserialize, Serialize};
63
use std::time::Duration;
74
use testcontainers::{
@@ -16,7 +13,7 @@ use tokio::{
1613
};
1714
use tracing::{error, info, warn};
1815

19-
// addapted from from restate-admin-rest-model crate version 1.1.6
16+
// From restate-admin-rest-model
2017
#[derive(Serialize, Deserialize, Debug)]
2118
pub struct RegisterDeploymentRequestHttp {
2219
uri: String,
@@ -115,9 +112,8 @@ impl TestContainer {
115112
pub async fn start(mut self, endpoint: Endpoint) -> Result<TestContainer, anyhow::Error> {
116113
self.serve_endpoint(endpoint).await?;
117114
self.start_container().await?;
118-
let registered = self.register_endpoint().await;
119-
if registered.is_err() {
120-
return Err(anyhow::anyhow!("Failed to register endpoint"));
115+
if let Err(e) = self.register_endpoint().await {
116+
return Err(anyhow::anyhow!("Failed to register endpoint: {e}"));
121117
}
122118

123119
Ok(self)
@@ -254,7 +250,7 @@ impl TestContainer {
254250
Ok(())
255251
}
256252

257-
async fn register_endpoint(&mut self) -> Result<(), HandlerError> {
253+
async fn register_endpoint(&mut self) -> Result<(), anyhow::Error> {
258254
info!(
259255
"registering endpoint server: {}",
260256
self.endpoint_server_url.as_ref().unwrap()
@@ -277,7 +273,7 @@ impl TestContainer {
277273
use_http_11: false,
278274
force: false,
279275
dry_run: false,
280-
}; //, additional_headers: (), use_http_11: (), force: (), dry_run: () }
276+
};
281277

282278
let register_admin_url = format!("http://{}:{}/deployments", host, admin_port);
283279

test-env/tests/test_container.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ use restate_sdk::prelude::*;
33
use restate_sdk_test_env::TestContainer;
44
use tracing::info;
55

6-
// Should compile
76
#[restate_sdk::service]
87
trait MyService {
98
async fn my_handler() -> HandlerResult<String>;
@@ -40,12 +39,12 @@ async fn test_container() {
4039

4140
let endpoint = Endpoint::builder().bind(MyServiceImpl.serve()).build();
4241

43-
// simple test container intialization with default configuration
42+
// simple test container initialization with default configuration
4443
//let test_container = TestContainer::default().start(endpoint).await.unwrap();
4544

4645
// custom test container initialization with builder
4746
let test_container = TestContainer::builder()
48-
// optional passthrough logging from the resstate server testcontainer
47+
// optional passthrough logging from the restate server testcontainers
4948
// prints container logs to tracing::info level
5049
.with_container_logging()
5150
.with_container(
@@ -69,6 +68,8 @@ async fn test_container() {
6968
.await
7069
.unwrap();
7170

71+
dbg!(format!("{}/MyService/my_handler", ingress_url));
72+
7273
assert_eq!(response.status(), StatusCode::OK);
7374

7475
info!(

0 commit comments

Comments
 (0)