Skip to content
This repository was archived by the owner on Jun 15, 2023. It is now read-only.

Commit d24c0df

Browse files
committed
Fix roundtrip tests, ignore test files with .fixme suffix
1 parent 523ff1e commit d24c0df

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

tests/printer/reactJsx/__snapshots__/render.spec.js.snap

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ let make = {
2323
"
2424
`;
2525
26-
exports[`externalWithCustomName.react.res.fixme 1`] = `""`;
27-
2826
exports[`innerModule.react.res 1`] = `
2927
"module Bar = {
3028
@bs.obj
@@ -36,7 +34,7 @@ exports[`innerModule.react.res 1`] = `
3634
) => {\\"a\\": 'a, \\"b\\": 'b} = \\"\\"
3735
let make =
3836
(@warning(\\"-16\\") ~a, @warning(\\"-16\\") ~b, _) => {
39-
Js.log(\\"This function should be named \`Test$Bar\`\\")
37+
Js.log(\\"This function should be named \`InnerModule.react$Bar\`\\")
4038
ReactDOMRe.createDOMElementVariadic(\\"div\\", [])
4139
}
4240
let make = {
@@ -54,7 +52,7 @@ exports[`innerModule.react.res 1`] = `
5452
5553
let component =
5654
(@warning(\\"-16\\") ~a, @warning(\\"-16\\") ~b, _) => {
57-
Js.log(\\"This function should be named \`Test$Bar$component\`\\")
55+
Js.log(\\"This function should be named \`InnerModule.react$Bar$component\`\\")
5856
ReactDOMRe.createDOMElementVariadic(\\"div\\", [])
5957
}
6058
let component = {

tests/printer/reactJsx/innerModule.react.res

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@ module Bar = {
22
@react.component
33
let make = (~a, ~b, _) => {
44
Js.log(
5-
"This function should be named `Test$Bar`",
5+
"This function should be named `InnerModule.react$Bar`",
66
)
77
<div />
88
}
99
@react.component
1010
let component = (~a, ~b, _) => {
1111
Js.log(
12-
"This function should be named `Test$Bar$component`",
12+
"This function should be named `InnerModule.react$Bar$component`",
1313
)
1414
<div />
1515
}

tests/runner.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ function parseFileToSexp(filename) {
109109
return parseOcamlFileToSexp(filename);
110110

111111
case "reactJsx":
112-
return parseOcamlFileToSexp(filename, true);
112+
return parseNapkinFileToSexp(filename, true);
113113

114114
default:
115115
return parseNapkinFileToSexp(filename, false);
@@ -213,6 +213,14 @@ let makeReproducibleFilename = (txt) => {
213213
global.runPrinter = (dirname) => {
214214
fs.readdirSync(dirname).forEach((base) => {
215215
let filename = path.join(dirname, base);
216+
217+
if (filename.length > 6) {
218+
let suffix = filename.substring(filename.length - 6);
219+
if (suffix === ".fixme") {
220+
return;
221+
}
222+
}
223+
216224
if (!fs.lstatSync(filename).isFile() || base === "render.spec.js") {
217225
return;
218226
}

0 commit comments

Comments
 (0)