Printer: auto-pun record fields (#534)

* Printer: auto-pun record fields

* Add test cases for single-element records

Author: cknitt

src/res_printer.ml

@@ -4839,8 +4839,7 @@ and printRecordRow (lbl, expr) cmtTbl punningAllowed =
     match expr.pexp_desc with
     | Pexp_ident({txt = Lident key; loc = keyLoc}) when (
       punningAllowed &&
-      Longident.last lbl.txt = key &&
-      lbl.loc.loc_start.pos_cnum == keyLoc.loc_start.pos_cnum
+      Longident.last lbl.txt = key
     ) ->
       (* print punned field *)
       printLidentPath lbl cmtTbl;

tests/conversion/reason/expected/bracedJsx.res.txt

@@ -91,7 +91,7 @@ let make = () => {
           ],
         ),
       }
-    | SetValue(input) => {...state, input: input}
+    | SetValue(input) => {...state, input}
     }
   , {history: [], input: ""})
 

tests/conversion/reason/expected/braces.res.txt

@@ -20,5 +20,5 @@ let getDailyNewCases = x =>
   | Pair({prevRecord, record}) =>
     let confirmed = record.confirmed - prevRecord.confirmed
     let deaths = record.deaths - prevRecord.deaths
-    {confirmed: confirmed, deaths: deaths}
+    {confirmed, deaths}
   }

tests/printer/expr/expected/record.res.txt

@@ -42,12 +42,14 @@ let user = {name: {(ceo.name: string)}}
 
 // Punning
 let r = {a} // actually not a record, just an expression in braces
+let r = {a: a} // single-element record, not punned
+let r = {A.a: a} // single-element record, not punned
 let r = {a, b}
 let r = {a, b, c: 42}
 let r = {A.a, b}
-let r = {A.a: a, b}
-let r = {a: a, b}
-let r = {a, b: b}
+let r = {A.a, b}
+let r = {a, b}
+let r = {a, b}
 
 // Punning + comments
 let r = {

tests/printer/expr/record.res

@@ -32,6 +32,8 @@ let user = {name: {(ceo.name: string)}}
 
 // Punning
 let r = {a} // actually not a record, just an expression in braces
+let r = {a: a} // single-element record, not punned
+let r = {A.a: a} // single-element record, not punned
 let r = {a, b}
 let r = {a, b, c: 42}
 let r = {A.a, b}