spread props for lowercase

Author: mununki

cli/reactjs_jsx_v4.ml

@@ -535,18 +535,7 @@ let transformLowercaseCall3 ~config mapper jsxExprLoc callExprLoc attrs
         ]
       | nonEmptyProps ->
         let propsRecord =
-          Exp.record
-            (nonEmptyProps
-            |> List.filter_map (fun (label, expression) ->
-                   match label with
-                   | Labelled txt | Optional txt ->
-                     Some
-                       ( {txt = Lident txt; loc = Location.none},
-                         if isOptional label then
-                           Exp.attr (mapper.expr mapper expression) optionalAttr
-                         else mapper.expr mapper expression )
-                   | Nolabel -> None))
-            None
+          recordFromProps ~loc:Location.none ~removeKey:false nonEmptyProps
         in
         [
           (* "div" *)

tests/ppx/react/expected/lowercases.res.txt

@@ -7,3 +7,9 @@ let _ = ReactDOM.createDOMElementVariadic(
   "div",
   [ReactDOM.createDOMElementVariadic("p", [{React.string(x)}])],
 )
+let _ = ReactDOM.createDOMElementVariadic("div", ~props=str, [])
+let _ = ReactDOM.createDOMElementVariadic("div", ~props={...str, x: "x"}, [])
+
+// syntax error
+// let _ = <div x="x" {...str} />
+// let _ = <div {...str} {...str} />

tests/ppx/react/lowercases.res

@@ -3,4 +3,10 @@
 let _ = <div />
 let _ = <div key="k" />
 let _ = <div x />
-let _ = <div><p>{React.string(x)}</p></div>
+let _ = <div><p>{React.string(x)}</p></div>
+let _ = <div {...str} />
+let _ = <div {...str} x="x" />
+
+// syntax error
+// let _ = <div x="x" {...str} />
+// let _ = <div {...str} {...str} />