From 822ad9f900a174582cb8248b163074709251a872 Mon Sep 17 00:00:00 2001 From: Christoph Knittel Date: Sun, 13 Oct 2024 19:10:05 +0200 Subject: [PATCH 1/3] Benchmark: reduce alert threshold to 120% --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b102a453c7..fc521e044d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -346,7 +346,7 @@ jobs: output-file-path: tests/benchmark-output.json external-data-json-path: ./tests/benchmark-cache/benchmark-data.json github-token: ${{ secrets.GITHUB_TOKEN }} - alert-threshold: "150%" + alert-threshold: "120%" comment-always: true comment-on-alert: true summary-always: true From 9d5fc9dd5d6cce3878ad6f79700a6cab35a2d08b Mon Sep 17 00:00:00 2001 From: Christoph Knittel Date: Sun, 13 Oct 2024 19:11:29 +0200 Subject: [PATCH 2/3] Remove unneeded permissions --- .github/workflows/ci.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fc521e044d..b90d799d84 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,10 +11,6 @@ on: pull_request: branches: [master, 11.0_release] -permissions: - # allow posting comments to pull request - pull-requests: write - concurrency: group: ci-${{ github.ref }}-1 # Cancel previous builds for pull requests only. From 48f6d3ec0f387ce13e804b5f7da8803d1286cd92 Mon Sep 17 00:00:00 2001 From: Christoph Knittel Date: Mon, 14 Oct 2024 19:51:45 +0200 Subject: [PATCH 3/3] Remove summary-always --- .github/workflows/ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b90d799d84..502f44e42d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -345,7 +345,6 @@ jobs: alert-threshold: "120%" comment-always: true comment-on-alert: true - summary-always: true - name: Build playground compiler if: matrix.build_playground