From 02421166291de68353452729c3b2d1c8211c451e Mon Sep 17 00:00:00 2001 From: Christoph Knittel Date: Fri, 31 May 2024 20:53:44 +0200 Subject: [PATCH] Reactivate unused attribute check for `@int` --- CHANGELOG.md | 1 + jscomp/frontend/bs_ast_invariant.ml | 5 ++--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c3901ceb2c..49747b1d78 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -30,6 +30,7 @@ - Fix unhandled cases for exotic idents (allow to use exotic PascalCased identifiers for types). https://github.com/rescript-lang/rescript-compiler/pull/6777 - PPX v4: mark props type in externals as `@live` to avoid dead code warnings for prop fields in the editor tooling. https://github.com/rescript-lang/rescript-compiler/pull/6796 - Fix unused attribute check for `@as`. https://github.com/rescript-lang/rescript-compiler/pull/6795 +- Reactivate unused attribute check for `@int`. https://github.com/rescript-lang/rescript-compiler/pull/6802 #### :house: Internal diff --git a/jscomp/frontend/bs_ast_invariant.ml b/jscomp/frontend/bs_ast_invariant.ml index 136c7b3135..6b2e292dc8 100644 --- a/jscomp/frontend/bs_ast_invariant.ml +++ b/jscomp/frontend/bs_ast_invariant.ml @@ -28,9 +28,8 @@ *) let is_bs_attribute txt = match txt with - (* TODO #6636: "int" *) - | "as" | "bs" | "config" | "ignore" | "optional" | "string" | "uncurry" - | "unwrap" -> + | "as" | "bs" | "config" | "ignore" | "int" | "optional" | "string" + | "uncurry" | "unwrap" -> true | _ -> false