From e605d4ccc9ffc7273deb3c451cb7d908974ea4a8 Mon Sep 17 00:00:00 2001 From: Hyeseong Kim Date: Tue, 10 Oct 2023 20:14:54 +0900 Subject: [PATCH 1/2] drop Node.js v16 (EoL) support --- .github/workflows/ci.yml | 10 +++++----- CONTRIBUTING.md | 2 +- package-lock.json | 2 +- package.json | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index afc2afed6e..9c38f78433 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -82,7 +82,7 @@ jobs: - name: Use Node.js uses: actions/setup-node@v4 with: - node-version: 16 + node-version: 18 - name: Copy exes to platform bin dirs run: node ./scripts/copyExes.js @@ -169,7 +169,7 @@ jobs: - name: Use Node.js uses: actions/setup-node@v4 with: - node-version: 16 + node-version: 18 - name: Install npm packages run: npm ci --ignore-scripts @@ -279,7 +279,7 @@ jobs: - name: Use Node.js uses: actions/setup-node@v4 with: - node-version: 16 + node-version: 18 - name: NPM install run: npm ci --ignore-scripts @@ -340,7 +340,7 @@ jobs: - name: Use Node.js uses: actions/setup-node@v4 with: - node-version: 16 + node-version: 18 - name: Download artifacts uses: actions/download-artifact@v4 @@ -372,7 +372,7 @@ jobs: - name: Use Node.js uses: actions/setup-node@v4 with: - node-version: 16 + node-version: 18 registry-url: https://registry.npmjs.org # Needed to make auth work for publishing - name: Download artifacts diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 666b22de69..99852850d3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -14,7 +14,7 @@ Happy hacking! > Most of our contributors are working on Apple machines, so all our instructions are currently macOS / Linux centric. Contributions for Windows development welcome! -- [NodeJS v16](https://nodejs.org/) +- [NodeJS v18](https://nodejs.org/) - C compiler toolchain (usually installed with `xcode` on Mac) - `opam` (OCaml Package Manager) - VSCode (+ [OCaml Platform Extension](https://marketplace.visualstudio.com/items?itemName=ocamllabs.ocaml-platform)) diff --git a/package-lock.json b/package-lock.json index 59d6238f4d..ce22a97779 100644 --- a/package-lock.json +++ b/package-lock.json @@ -20,7 +20,7 @@ "prettier": "2.7.1" }, "engines": { - "node": ">=10" + "node": ">=18" } }, "node_modules/@babel/code-frame": { diff --git a/package.json b/package.json index 4611da39cb..f971840239 100644 --- a/package.json +++ b/package.json @@ -7,7 +7,7 @@ "prettier": "2.7.1" }, "engines": { - "node": ">=10" + "node": ">=18" }, "bin": { "bsc": "bsc", From a0766921fd0216c98898dc337faa548918a4c3c7 Mon Sep 17 00:00:00 2001 From: Hyeseong Kim Date: Wed, 11 Oct 2023 03:21:20 +0900 Subject: [PATCH 2/2] add CHANGELOG --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a25ffd015f..5556ddf4a6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,7 @@ - `lazy` syntax is no longer supported. If you're using it, use `Lazy` module or `React.lazy_` instead. https://github.com/rescript-lang/rescript-compiler/pull/6342 - Remove handling of attributes with `bs.` prefix (`@bs.as` -> `@as` etc.). https://github.com/rescript-lang/rescript-compiler/pull/6643 - Remove obsolete `@bs.open` feature. https://github.com/rescript-lang/rescript-compiler/pull/6629 +- Drop Node.js version <18 support, due to it reaching End-of-Life. https://github.com/rescript-lang/rescript-compiler/pull/6429 #### :house: Internal