remove symlinks

Author: cometkim

.gitignore

@@ -98,3 +98,4 @@ tests/analysis_tests/**/*.bs.js
 
 # package tarballs
 package.tgz
+*.exe

cli/common/bins.js

@@ -1,9 +1,6 @@
 // @ts-check
 
-import * as fs from "node:fs";
-
 /**
- * @import {BinaryPaths} from "@rescript/linux-x64"
  * @typedef {import("@rescript/linux-x64")} BinaryModuleExports
  */
 
@@ -17,29 +14,15 @@ try {
   throw new Error(`Platform ${target} is not supported!`);
 }
 
-const binPaths = mod.binPaths;
-// Compiler use symbolic links in the development process
-if (fs.lstatSync(binPaths.rescript_exe).isSymbolicLink()) {
-  for (const [key, binPath] of Object.entries(binPaths)) {
-    try {
-      binPaths[/** @type {keyof BinaryPaths} */ (key)] =
-        fs.realpathSync(binPath);
-    } catch {
-      // Cannot populate the realpath of a binary, some tests may fails.
-      //
-      // But we don't report error here,
-      // so pass even some binaries are not built yet.
-    }
-  }
-}
-
-export const platformDir = mod.binDir;
 export const {
-  bsb_helper_exe,
-  bsc_exe,
-  ninja_exe,
-  rescript_editor_analysis_exe,
-  rescript_tools_exe,
-  rescript_exe,
-  rewatch_exe,
-} = binPaths;
+  binDir,
+  binPaths: {
+    bsb_helper_exe,
+    bsc_exe,
+    ninja_exe,
+    rescript_editor_analysis_exe,
+    rescript_tools_exe,
+    rescript_exe,
+    rewatch_exe,
+  },
+} = mod;

lib_dev/paths.js

@@ -7,23 +7,6 @@ import * as path from "node:path";
  */
 export const projectDir = path.resolve(import.meta.dirname, "..");
 
-/**
- * For compatibility reasons, if the architecture is x64, omit it from the bin directory name.
- * So we'll have "darwin", "linux" and "win32" for x64 arch,
- * but "darwinarm64" and "linuxarm64" for arm64 arch.
- * Also, we do not have Windows ARM binaries yet. But the x64 binaries do work on Windows 11 ARM.
- * So omit the architecture for Windows, too.
- */
-export const platformName =
-  process.arch === "x64" || process.platform === "win32"
-    ? process.platform
-    : process.platform + process.arch;
-
-/**
- * path: `<projectDir>/<platform>` (e.g. linux, darwinarm64)
- */
-export const platformDir = path.resolve(projectDir, platformName);
-
 /**
  * path: `<projectDir>/compiler/`
  */

packages/@rescript/darwin-arm64/bin/.gitkeep

@@ -7,19 +7,17 @@
 import * as child_process from "node:child_process";
 import * as fs from "node:fs";
 import * as path from "node:path";
-import { platformDir } from "#dev/paths";
+import { binDir } from "#cli/bins";
 import { compilerBinDir, ninjaDir, rewatchDir } from "#dev/paths";
 
-fs.mkdirSync(platformDir, { recursive: true });
-
 /**
  * @param {string} dir
  * @param {string} exe
  */
 function copyExe(dir, exe) {
   const ext = process.platform === "win32" ? ".exe" : "";
   const src = path.join(dir, exe + ext);
-  const dest = path.join(platformDir, `${exe}.exe`);
+  const dest = path.join(binDir, `${exe}.exe`);
 
   // For some reason, the copy operation fails in Windows CI if the file already exists.
   if (process.platform === "win32" && fs.existsSync(dest)) {