test(syntax): use regex literal in test files

necessary to pass syntax roundtrip test since printing has changed

Author: glennsl

jscomp/syntax/tests/idempotency/nook-exchange/App.res

@@ -64,7 +64,7 @@ let make = () => {
   let url = ReasonReactRouter.useUrl()
   let (showLogin, setShowLogin) = React.useState(() => false)
   let itemDetails = {
-    let result = url.hash |> Js.Re.exec_(%re("/i(-?\d+)(:(\d+))?/g"))
+    let result = url.hash |> Js.Re.exec_(/i(-?\d+)(:(\d+))?/g)
     switch result {
     | Some(match_) =>
       let captures = Js.Re.captures(match_)

jscomp/syntax/tests/idempotency/nook-exchange/Emoji.res

@@ -31,7 +31,7 @@ module Styles = {
   let emoji = style(list{verticalAlign(#bottom), position(relative), top(px(-2))})
 }
 
-let emojiRegex = %re(`/(^|\\s)(\\:[a-zA-Z0-9-_+]+\\:)/g`)
+let emojiRegex = /(^|\s)(\:[a-zA-Z0-9-_+]+\:)/g
 
 let parseText = (text: string): React.element => {
   let children = []

jscomp/syntax/tests/idempotency/nook-exchange/ImportPage.res

@@ -654,7 +654,7 @@ let process = value => {
   let resultMap = Js.Dict.empty()
   let missingQueries = []
   rows->Array.forEach(row => {
-    let result = row |> Js.Re.exec_(%re("/(.*?) \[(.*?)\]$/g"))
+    let result = row |> Js.Re.exec_(/(.*?) \[(.*?)\]$/g)
     let itemWithVariant = switch result {
     | Some(match_) =>
       let captures = Js.Re.captures(match_)

jscomp/syntax/tests/idempotency/nook-exchange/Item.res

@@ -82,7 +82,7 @@ let loadTranslation: (string, Js.Json.t => unit) => unit = %raw(`function(langua
 
 exception UnexpectedType(string)
 
-let spaceRegex = %re("/\\s/g")
+let spaceRegex = /\s/g
 
 exception Unexpected
 let jsonToItems = (json: Js.Json.t) => {

jscomp/syntax/tests/idempotency/nook-exchange/ItemFilters.res

@@ -206,7 +206,7 @@ let doesItemMatchCategory = (~item: Item.t, ~category: string) =>
   }
 
 let removeAccents = str =>
-  str |> Js.String.normalizeByForm("NFD") |> Js.String.replaceByRe(%re("/[\u0300-\u036f]/g"), "")
+  str |> Js.String.normalizeByForm("NFD") |> Js.String.replaceByRe(/[\u0300-\u036f]/g, "")
 
 let doesItemMatchFilters = (~item: Item.t, ~filters: t) =>
   switch filters.text {
@@ -218,7 +218,7 @@ let doesItemMatchFilters = (~item: Item.t, ~filters: t) =>
     | None => false
     } || {
       let fragments =
-        (textLower |> Js.String.splitByRe(%re(`/[\\s-]+/`)))->Belt.Array.keepMap(x => x)
+        (textLower |> Js.String.splitByRe(/[\s-]+/))->Belt.Array.keepMap(x => x)
       fragments->Belt.Array.every(fragment =>
         Js.String.toLowerCase(Item.getName(item))
         |> removeAccents
@@ -253,8 +253,8 @@ let compareArrays = (a, b) => {
 
 let compareItemsABC = (a: Item.t, b: Item.t) => {
   // hack to sort "wooden-" before "wooden "
-  let aName = Item.getName(a) |> Js.String.replaceByRe(%re("/-/g"), " ")
-  let bName = Item.getName(b) |> Js.String.replaceByRe(%re("/-/g"), " ")
+  let aName = Item.getName(a) |> Js.String.replaceByRe(/-/g, " ")
+  let bName = Item.getName(b) |> Js.String.replaceByRe(/-/g, " ")
   int_of_float(Js.String.localeCompare(bName, aName))
 }
 let compareItemsSellPriceDesc = (a: Item.t, b: Item.t) =>
@@ -798,7 +798,7 @@ let make = (
       | "Escape" =>
         let url = ReasonReactRouter.dangerouslyGetInitialUrl()
         // don't trigger if ItemDetailOverlay is shown
-        if !(url.hash |> Js.Re.test_(%re("/i(-?\d+)(:(\d+))?/g"))) {
+        if !(url.hash |> Js.Re.test_(/i(-?\d+)(:(\d+))?/g)) {
           onChange({...filters, text: ""})
         }
       | "/" =>

jscomp/syntax/tests/idempotency/nook-exchange/UserStore.res

@@ -477,7 +477,7 @@ let toggleCatalogCheckboxSetting = (~enabled) => {
   )
 }
 
-let errorQuotationMarksRegex = %re(`/^"(.*)"$/`)
+let errorQuotationMarksRegex = /^"(.*)"$/
 let register = (~username, ~email, ~password) =>
   %Repromise.JsExn({
     let response = Fetch.fetchWithInit(

jscomp/syntax/tests/idempotency/pupilfirst/questions/QuestionsShow__QuestionEditor.res

@@ -183,7 +183,7 @@ module UpdateQuestionError = {
 let handleResponseCB = (id, title) => {
   let window = Webapi.Dom.window
   let parameterizedTitle =
-    title |> Js.String.toLowerCase |> Js.String.replaceByRe(%re("/[^0-9a-zA-Z]+/gi"), "-")
+    title |> Js.String.toLowerCase |> Js.String.replaceByRe(/[^0-9a-zA-Z]+/gi, "-")
   let redirectPath = "/questions/" ++ (id ++ ("/" ++ parameterizedTitle))
   redirectPath |> Webapi.Dom.Window.setLocation(window)
 }

jscomp/syntax/tests/idempotency/pupilfirst/schools/CurriculumEditor__ContentBlockCreator.res

@@ -292,10 +292,10 @@ let updateEmbedUrl = (send, event) => {
 }
 
 let embedUrlRegexes = [
-  %re("/https:\\/\\/.*slideshare\\.net/"),
-  %re("/https:\\/\\/.*vimeo\\.com/"),
-  %re("/https:\\/\\/.*youtube\\.com/"),
-  %re("/https:\\/\\/.*youtu\\.be/"),
+  /https:\/\/.*slideshare\.net/,
+  /https:\/\/.*vimeo\.com/,
+  /https:\/\/.*youtube\.com/,
+  /https:\/\/.*youtu\.be/,
 ]
 
 let validEmbedUrl = url => Belt.Array.some(embedUrlRegexes, regex => regex->Js.Re.test_(url))

jscomp/syntax/tests/idempotency/pupilfirst/schools/SA_Coaches_CoachEditor.res

@@ -94,7 +94,7 @@ let updateEmail = (send, email) => send(UpdateEmail(email, email |> emailInvalid
 let updateTitle = (send, title) => send(UpdateTitle(title, title |> nameOrTitleInvalid))
 
 let updateLinkedInUrl = (send, linkedinUrl) => {
-  let regex = %re(`/(https?)?:?(\\/\\/)?(([w]{3}||\\w\\w)\\.)?linkedin.com(\\w+:{0,1}\\w*@)?(\\S+)(:([0-9])+)?(\\/|\\/([\\w#!:.?+=&%@!\\-\\/]))?/`)
+  let regex = /(https?)?:?(\/\/)?(([w]{3}||\w\w)\.)?linkedin.com(\w+:{0,1}\w*@)?(\S+)(:([0-9])+)?(\/|\/([\w#!:.?+=&%@!\-\/]))?/
   let hasError = linkedinUrl |> String.length < 1 ? false : !Js.Re.test_(regex, linkedinUrl)
   send(UpdateLinkedInUrl(linkedinUrl, hasError))
 }

jscomp/syntax/tests/idempotency/pupilfirst/schools/StudentsEditor__StudentInfoForm.res

@@ -29,7 +29,7 @@ let updateName = (send, name) => {
 }
 
 let updateEmail = (send, email) => {
-  let regex = %re(`/.+@.+\\..+/i`)
+  let regex = /.+@.+\..+/i
   let hasError = !Js.Re.test_(regex, email)
   send(UpdateEmail(email, hasError))
 }

jscomp/syntax/tests/idempotency/pupilfirst/shared/EmailUtils.res

@@ -1,6 +1,5 @@
-let regularExpression = %re(
-  "/^(([^<>()\\[\\]\\.,;:\\s@\"]+(\\.[^<>()\\[\\]\\.,;:\\s@\"]+)*)|(\".+\"))@(([^<>()[\\]\\.,;:\\s@\"]+\\.)+[^<>()[\\]\\.,;:\\s@\"]{2,})$/i"
-)
+let regularExpression =
+  /^(([^<>()\[\]\.,;:\s@\"]+(\.[^<>()\[\]\.,;:\s@\"]+)*)|(\".+\"))@(([^<>()[\]\.,;:\s@\"]+\.)+[^<>()[\]\.,;:\s@\"]{2,})$/i
 
 let isInvalid = (allowBlank, email) =>
   if email |> String.trim |> String.length > 0 {

jscomp/syntax/tests/idempotency/reasonml.org/common/App.res

@@ -79,7 +79,7 @@ module Url = {
   }
 
   let isVersion = str =>
-    Js.String2.match_(str, %re("/latest|v\\d+(\\.\\d+)?(\\.\\d+)?/"))->Belt.Option.isSome
+    Js.String2.match_(str, /latest|v\d+(\.\d+)?(\.\d+)?/)->Belt.Option.isSome
 
   let parse = (route: string): t => {
     let fullpath = {

jscomp/syntax/tests/idempotency/reasonml.org/components/Markdown.res

@@ -311,7 +311,7 @@ module A = {
       // Ideally one would check if this link is relative first,
       // but it's very unlikely we'd refer to an absolute URL ending
       // with .md
-      let regex = %re("/\\.md(x)?|\\.html$/")
+      let regex = /\.md(x)?|\.html$/
       let href = switch Js.String2.split(href, "#") {
       | [pathname, anchor] => Js.String2.replaceByRe(pathname, regex, "") ++ ("#" ++ anchor)
       | [pathname] => Js.String2.replaceByRe(pathname, regex, "")

jscomp/syntax/tests/idempotency/wildcards-world-ui/Helper.res

@@ -3,7 +3,7 @@ let isPositiveStringInteger = str => {
 
   // NOTE: This allows leading 0s (which seams to not be a problem for web3 or truffle)
   //       This doesn't check if the number is smaller than 2^256 which is the largest integer ethereum can handle
-  let f = %re("/^([0-9]\d*)$/")
+  let f = /^([0-9]\d*)$/
 
   Js.Re.test_(f, str)
 }

jscomp/test/js_re_test.res

@@ -4,7 +4,7 @@ let suites = {
     (
       "captures",
       _ => {
-        let re = %re("/(\d+)-(?:(\d+))?/g")
+        let re = /(\d+)-(?:(\d+))?/g
         let str = "3-"
         switch re->Js.Re.exec_(str) {
         | Some(result) =>
@@ -35,15 +35,15 @@ let suites = {
     (
       "exec_literal",
       _ =>
-        switch %re("/[^.]+/")->Js.Re.exec_("http://xxx.domain.com") {
+        switch /[^.]+/->Js.Re.exec_("http://xxx.domain.com") {
         | Some(res) => Eq(Js.Nullable.return("http://xxx"), Js.Re.captures(res)[0])
         | None => FailWith("regex should match")
         },
     ),
     (
       "exec_no_match",
       _ =>
-        switch %re("/https:\/\/(.*)/")->Js.Re.exec_("http://xxx.domain.com") {
+        switch /https:\/\/(.*)/->Js.Re.exec_("http://xxx.domain.com") {
         | Some(_) => FailWith("regex should not match")
         | None => Ok(true)
         },
@@ -77,20 +77,20 @@ let suites = {
       _ => {
         let input = "foobar"
 
-        switch %re("/foo/g")->Js.Re.exec_(input) {
+        switch /foo/g->Js.Re.exec_(input) {
         | Some(res) => Eq(input, res |> Js.Re.input)
         | None => Fail()
         }
       },
     ),
     /* es2015 */
-    ("t_flags", _ => Eq("gi", %re("/./ig")->Js.Re.flags)),
-    ("t_global", _ => Eq(true, %re("/./ig")->Js.Re.global)),
-    ("t_ignoreCase", _ => Eq(true, %re("/./ig")->Js.Re.ignoreCase)),
+    ("t_flags", _ => Eq("gi", /./ig->Js.Re.flags)),
+    ("t_global", _ => Eq(true, /./ig->Js.Re.global)),
+    ("t_ignoreCase", _ => Eq(true, /./ig->Js.Re.ignoreCase)),
     (
       "t_lastIndex",
       _ => {
-        let re = %re("/na/g")
+        let re = /na/g
         let _ =
           re->Js.Re.exec_(
             "banana",
@@ -101,7 +101,7 @@ let suites = {
     (
       "t_setLastIndex",
       _ => {
-        let re = %re("/na/g")
+        let re = /na/g
 
         let before = Js.Re.lastIndex(re)
         let () = Js.Re.setLastIndex(re, 42)
@@ -110,11 +110,11 @@ let suites = {
         Eq((0, 42), (before, after))
       },
     ),
-    ("t_multiline", _ => Eq(false, %re("/./ig")->Js.Re.multiline)),
-    ("t_source", _ => Eq("f.+o", %re("/f.+o/ig")->Js.Re.source)),
+    ("t_multiline", _ => Eq(false, /./ig->Js.Re.multiline)),
+    ("t_source", _ => Eq("f.+o", /f.+o/ig->Js.Re.source)),
     /* es2015 */
-    ("t_sticky", _ => Eq(true, %re("/./yg")->Js.Re.sticky)),
-    ("t_unicode", _ => Eq(false, %re("/./yg")->Js.Re.unicode)),
+    ("t_sticky", _ => Eq(true, /./yg->Js.Re.sticky)),
+    ("t_unicode", _ => Eq(false, /./yg->Js.Re.unicode)),
   }
 }
 

jscomp/test/js_string_test.res

@@ -27,13 +27,13 @@ let suites = {
     ("lastIndexOf", _ => Eq(3, "foobarbaz"->Js.String2.lastIndexOf("bar"))),
     ("lastIndexOfFrom", _ => Eq(3, "foobarbaz"->Js.String2.lastIndexOfFrom("bar", 4))),
     ("localeCompare", _ => Eq(0., "foo"->Js.String2.localeCompare("foo"))),
-    ("match", _ => Eq(Some([Some("na"), Some("na")]), "banana"->Js.String2.match_(%re("/na+/g")))),
-    ("match - no match", _ => Eq(None, "banana"->Js.String2.match_(%re("/nanana+/g")))),
+    ("match", _ => Eq(Some([Some("na"), Some("na")]), "banana"->Js.String2.match_(/na+/g))),
+    ("match - no match", _ => Eq(None, "banana"->Js.String2.match_(/nanana+/g))),
     (
       "match - not found capture groups",
       _ => Eq(
         Some([Some("hello "), None]),
-        "hello word"->Js.String2.match_(%re("/hello (world)?/"))->Belt.Option.map(Js.Array.copy),
+        "hello word"->Js.String2.match_(/hello (world)?/)->Belt.Option.map(Js.Array.copy),
       ),
     ),
     /* es2015 */
@@ -44,7 +44,7 @@ let suites = {
     ("replace", _ => Eq("fooBORKbaz", "foobarbaz"->Js.String2.replace("bar", "BORK"))),
     (
       "replaceByRe",
-      _ => Eq("fooBORKBORK", "foobarbaz"->Js.String2.replaceByRe(%re("/ba./g"), "BORK")),
+      _ => Eq("fooBORKBORK", "foobarbaz"->Js.String2.replaceByRe(/ba./g, "BORK")),
     ),
     (
       "unsafeReplaceBy0",
@@ -56,7 +56,7 @@ let suites = {
             "DORK"
           }
 
-        Eq("fooBORKDORK", "foobarbaz"->Js.String2.unsafeReplaceBy0(%re("/ba./g"), replace))
+        Eq("fooBORKDORK", "foobarbaz"->Js.String2.unsafeReplaceBy0(/ba./g, replace))
       },
     ),
     (
@@ -69,7 +69,7 @@ let suites = {
             "DORK"
           }
 
-        Eq("fooBORKDORK", "foobarbaz"->Js.String2.unsafeReplaceBy1(%re("/ba./g"), replace))
+        Eq("fooBORKDORK", "foobarbaz"->Js.String2.unsafeReplaceBy1(/ba./g, replace))
       },
     ),
     (
@@ -82,7 +82,7 @@ let suites = {
             "DORK"
           }
 
-        Eq("fooBORKDORK", "foobarbaz"->Js.String2.unsafeReplaceBy2(%re("/ba./g"), replace))
+        Eq("fooBORKDORK", "foobarbaz"->Js.String2.unsafeReplaceBy2(/ba./g, replace))
       },
     ),
     (
@@ -95,10 +95,10 @@ let suites = {
             "DORK"
           }
 
-        Eq("fooBORKDORK", "foobarbaz"->Js.String2.unsafeReplaceBy3(%re("/ba./g"), replace))
+        Eq("fooBORKDORK", "foobarbaz"->Js.String2.unsafeReplaceBy3(/ba./g, replace))
       },
     ),
-    ("search", _ => Eq(3, "foobarbaz"->Js.String2.search(%re("/ba./g")))),
+    ("search", _ => Eq(3, "foobarbaz"->Js.String2.search(/ba./g))),
     ("slice", _ => Eq("bar", "foobarbaz"->Js.String2.slice(~from=3, ~to_=6))),
     ("sliceToEnd", _ => Eq("barbaz", "foobarbaz"->Js.String2.sliceToEnd(~from=3))),
     ("split", _ => Eq(["foo", "bar", "baz"], "foo bar baz"->Js.String2.split(" "))),
@@ -107,14 +107,14 @@ let suites = {
       "splitByRe",
       _ => Eq(
         [Some("a"), Some("#"), None, Some("b"), Some("#"), Some(":"), Some("c")],
-        "a#b#:c" |> Js.String.splitByRe(%re("/(#)(:)?/")),
+        "a#b#:c" |> Js.String.splitByRe(/(#)(:)?/),
       ),
     ),
     (
       "splitByReAtMost",
       _ => Eq(
         [Some("a"), Some("#"), None],
-        "a#b#:c" |> Js.String.splitByReAtMost(%re("/(#)(:)?/"), ~limit=3),
+        "a#b#:c" |> Js.String.splitByReAtMost(/(#)(:)?/, ~limit=3),
       ),
     ),
     /* es2015 */

jscomp/test/test_regex.res

@@ -1,5 +1,5 @@
-let v = %re("/b/ig")
-let r = %re("/Bucklescript是一个程序语言/")
+let v = /b/ig
+let r = /Bucklescript是一个程序语言/
 
 /* Js.log(v);;
  Js.log(r);; */