using table instead number for safe module type name

Author: mununki

jscomp/frontend/bs_builtin_ppx.ml

@@ -426,13 +426,10 @@ let local_module_name =
 
 (* Unpack requires core_type package for type inference;
    use module type bindings and a function to create safe local names instead. *)
-let local_module_type_name =
-  let v = ref 0 in
-  fun ({txt} : Longident.t Location.loc) ->
-    incr v;
-    "__"
-    ^ (Longident.flatten txt |> List.fold_left (fun ll l -> ll ^ l) "")
-    ^ string_of_int !v ^ "__"
+let local_module_type_name txt =
+  "_"
+  ^ (Longident.flatten txt |> List.fold_left (fun ll l -> ll ^ "_" ^ l) "")
+  ^ "__"
 
 let expand_reverse (stru : Ast_structure.t) (acc : Ast_structure.t) :
     Ast_structure.t =
@@ -466,14 +463,15 @@ let expand_reverse (stru : Ast_structure.t) (acc : Ast_structure.t) :
          }
     :: acc)
 
-let rec structure_mapper (self : mapper) (stru : Ast_structure.t) =
+let rec structure_mapper ~await_context (self : mapper) (stru : Ast_structure.t)
+    =
   match stru with
   | [] -> []
   | item :: rest -> (
     match item.pstr_desc with
     | Pstr_extension (({txt = "bs.raw" | "raw"; loc}, payload), _attrs) ->
       Ast_exp_handle_external.handle_raw_structure loc payload
-      :: structure_mapper self rest
+      :: structure_mapper ~await_context self rest
     (* | Pstr_extension (({txt = "i"}, _),_)
        ->
        structure_mapper self rest *)
@@ -490,7 +488,7 @@ let rec structure_mapper (self : mapper) (stru : Ast_structure.t) =
               next
           | PSig _ | PTyp _ | PPat _ ->
             Location.raise_errorf ~loc "private extension is not support")
-        | _ -> expand_reverse acc (structure_mapper self rest)
+        | _ -> expand_reverse acc (structure_mapper ~await_context self rest)
       in
       aux [] stru
     (* Dynamic import of module transformation: module M = @res.await Belt.List *)
@@ -499,30 +497,49 @@ let rec structure_mapper (self : mapper) (stru : Ast_structure.t) =
         as mb)
       when Res_parsetree_viewer.hasAwaitAttribute pmod_attributes ->
       let item = self.structure_item self item in
-      let safe_module_type_name = local_module_type_name {txt; loc} in
+      let safe_module_type_name = local_module_type_name txt in
+      let has_local_module_name =
+        Hashtbl.find_opt !await_context safe_module_type_name
+      in
+      (* module __Belt_List__ = module type of Belt.List *)
       let module_type_decl =
-        let open Ast_helper in
-        Str.modtype ~loc
-          (Mtd.mk ~loc
-             {txt = safe_module_type_name; loc}
-             ~typ:(Mty.typeof_ ~loc me))
+        match has_local_module_name with
+        | Some _ -> []
+        | None ->
+          let open Ast_helper in
+          Hashtbl.add !await_context safe_module_type_name safe_module_type_name;
+          [
+            Str.modtype ~loc
+              (Mtd.mk ~loc
+                 {txt = safe_module_type_name; loc}
+                 ~typ:(Mty.typeof_ ~loc me));
+          ]
       in
-      (* module __BeltList1__ = module type of Belt.List *)
       module_type_decl
-      :: {
-           item with
-           pstr_desc =
-             Pstr_module
-               {
-                 mb with
-                 pmb_expr =
-                   Ast_await.create_await_module_expression
-                     ~module_type_name:safe_module_type_name mb.pmb_expr;
-               };
-         }
-         (* module M = @res.await Belt.List *)
-      :: structure_mapper self rest
-    | _ -> self.structure_item self item :: structure_mapper self rest)
+      @ (* module M = @res.await Belt.List *)
+      {
+        item with
+        pstr_desc =
+          Pstr_module
+            {
+              mb with
+              pmb_expr =
+                Ast_await.create_await_module_expression
+                  ~module_type_name:safe_module_type_name mb.pmb_expr;
+            };
+      }
+      :: structure_mapper ~await_context self rest
+    | _ ->
+      self.structure_item self item :: structure_mapper ~await_context self rest
+    )
+
+let structure_mapper ~await_context (self : mapper) (stru : Ast_structure.t) =
+  let await_saved = !await_context in
+  let result =
+    structure_mapper ~await_context:(ref (Hashtbl.create 10)) self stru
+  in
+  await_context := await_saved;
+  result
 
 let mapper : mapper =
   {
@@ -533,7 +550,7 @@ let mapper : mapper =
     signature_item = signature_item_mapper;
     value_bindings = Ast_tuple_pattern_flatten.value_bindings_mapper;
     structure_item = structure_item_mapper;
-    structure = structure_mapper;
+    structure = structure_mapper ~await_context:(ref (Hashtbl.create 10));
     (* Ad-hoc way to internalize stuff *)
     label_declaration =
       (fun self lbl ->

jscomp/test/Import.js

@@ -48,11 +48,46 @@ var beltAsModule = await import("../../lib/js/belt_List.js");
 
 var M = await import("../../lib/js/belt_List.js");
 
-var each = M.forEach;
+var N0 = await import("../../lib/js/belt_List.js");
+
+var O = await import("../../lib/js/belt_List.js");
+
+var N1_each = O.forEach;
+
+var N1 = {
+  O: O,
+  each: N1_each
+};
+
+var N2 = await import("../../lib/js/belt_List.js");
+
+var N_each = N2.forEach;
+
+var N = {
+  N0: N0,
+  N1: N1,
+  N2: N2,
+  each: N_each
+};
+
+var M0 = await import("../../lib/js/belt_List.js");
+
+var M1 = await import("../../lib/js/belt_List.js");
+
+var each = M1.forEach;
+
+var M2;
+
+var each2 = O.forEach;
 
 exports.eachIntAsync = eachIntAsync;
 exports.eachIntLazy = eachIntLazy;
 exports.beltAsModule = beltAsModule;
 exports.M = M;
+exports.N = N;
+exports.M0 = M0;
+exports.M1 = M1;
 exports.each = each;
+exports.M2 = M2;
+exports.each2 = each2;
 /*  Not a pure module */

jscomp/test/Import.res

@@ -15,3 +15,25 @@ let beltAsModule = await Js.import(module(Belt.List: BeltList))
 // module M = unpack(@res.await Js.import(module(Belt.List: BeltList0)))
 module M = await Belt.List
 let each = M.forEach
+
+module N = {
+  module N0 = await Belt.List
+  let each = N0.forEach
+
+  module N1 = {
+    module O = await Belt.List
+    let each = O.forEach
+  }
+
+  module N2 = await Belt.List
+  let each = N2.forEach
+}
+
+module M0 = await Belt.List
+let each = M0.forEach
+
+module M1 = await Belt.List
+let each = M1.forEach
+
+module M2 = N.N1.O
+let each2 = M2.forEach