convert ext/

Author: aspeddro

jscomp/ext/ext_cmp.ml

@@ -2,7 +2,7 @@ type 'a compare = 'a -> 'a -> int
 
 type ('a, 'id) cmp = 'a compare
 
-external getCmp : ('a, 'id) cmp -> 'a compare = "%identity"
+external get_cmp : ('a, 'id) cmp -> 'a compare = "%identity"
 
 module type S = sig
   type id

jscomp/ext/ext_cmp.mli

@@ -2,7 +2,7 @@ type 'a compare = 'a -> 'a -> int
 
 type ('a, 'id) cmp
 
-external getCmp : ('a, 'id) cmp -> 'a compare = "%identity"
+external get_cmp : ('a, 'id) cmp -> 'a compare = "%identity"
 (** only used for data structures, not exported for client usage *)
 
 module type S = sig

jscomp/ext/ext_string_array.ml

@@ -25,23 +25,23 @@
 (* Invariant: the same as encoding Map_string.compare_key  *)
 let cmp = Ext_string.compare
 
-let rec binarySearchAux (arr : string array) (lo : int) (hi : int)
+let rec binary_search_aux (arr : string array) (lo : int) (hi : int)
     (key : string) : _ option =
   let mid = (lo + hi) / 2 in
-  let midVal = Array.unsafe_get arr mid in
-  let c = cmp key midVal in
+  let mid_val = Array.unsafe_get arr mid in
+  let c = cmp key mid_val in
   if c = 0 then Some mid
   else if c < 0 then
     (*  a[lo] =< key < a[mid] <= a[hi] *)
     if hi = mid then
-      let loVal = Array.unsafe_get arr lo in
-      if loVal = key then Some lo else None
-    else binarySearchAux arr lo mid key
+      let lo_val = Array.unsafe_get arr lo in
+      if lo_val = key then Some lo else None
+    else binary_search_aux arr lo mid key
   else if (*  a[lo] =< a[mid] < key <= a[hi] *)
           lo = mid then
-    let hiVal = Array.unsafe_get arr hi in
-    if hiVal = key then Some hi else None
-  else binarySearchAux arr mid hi key
+    let hi_val = Array.unsafe_get arr hi in
+    if hi_val = key then Some hi else None
+  else binary_search_aux arr mid hi key
 
 let find_sorted sorted key : int option =
   let len = Array.length sorted in
@@ -53,25 +53,25 @@ let find_sorted sorted key : int option =
     else
       let hi = Array.unsafe_get sorted (len - 1) in
       let c2 = cmp key hi in
-      if c2 > 0 then None else binarySearchAux sorted 0 (len - 1) key
+      if c2 > 0 then None else binary_search_aux sorted 0 (len - 1) key
 
-let rec binarySearchAssoc (arr : (string * _) array) (lo : int) (hi : int)
+let rec binary_search_assoc (arr : (string * _) array) (lo : int) (hi : int)
     (key : string) : _ option =
   let mid = (lo + hi) / 2 in
-  let midVal = Array.unsafe_get arr mid in
-  let c = cmp key (fst midVal) in
-  if c = 0 then Some (snd midVal)
+  let mid_val = Array.unsafe_get arr mid in
+  let c = cmp key (fst mid_val) in
+  if c = 0 then Some (snd mid_val)
   else if c < 0 then
     (*  a[lo] =< key < a[mid] <= a[hi] *)
     if hi = mid then
-      let loVal = Array.unsafe_get arr lo in
-      if fst loVal = key then Some (snd loVal) else None
-    else binarySearchAssoc arr lo mid key
+      let lo_val = Array.unsafe_get arr lo in
+      if fst lo_val = key then Some (snd lo_val) else None
+    else binary_search_assoc arr lo mid key
   else if (*  a[lo] =< a[mid] < key <= a[hi] *)
           lo = mid then
-    let hiVal = Array.unsafe_get arr hi in
-    if fst hiVal = key then Some (snd hiVal) else None
-  else binarySearchAssoc arr mid hi key
+    let hi_val = Array.unsafe_get arr hi in
+    if fst hi_val = key then Some (snd hi_val) else None
+  else binary_search_assoc arr mid hi key
 
 let find_sorted_assoc (type a) (sorted : (string * a) array) (key : string) :
     a option =
@@ -84,4 +84,4 @@ let find_sorted_assoc (type a) (sorted : (string * a) array) (key : string) :
     else
       let hi = Array.unsafe_get sorted (len - 1) in
       let c2 = cmp key (fst hi) in
-      if c2 > 0 then None else binarySearchAssoc sorted 0 (len - 1) key
+      if c2 > 0 then None else binary_search_assoc sorted 0 (len - 1) key

jscomp/ext/js_reserved_map.ml

@@ -790,21 +790,21 @@ let sorted_keywords = [|
 
 type element = string 
 
-let rec binarySearchAux (arr : element array) (lo : int) (hi : int) key : bool =   
+let rec binary_search_aux (arr : element array) (lo : int) (hi : int) key : bool =   
     let mid = (lo + hi)/2 in 
-    let midVal = Array.unsafe_get arr mid in 
+    let mid_val = Array.unsafe_get arr mid in 
     (* let c = cmp key midVal [@bs] in  *)
-    if key = midVal then true 
-    else if key < midVal then  (*  a[lo] =< key < a[mid] <= a[hi] *)
+    if key = mid_val then true 
+    else if key < mid_val then  (*  a[lo] =< key < a[mid] <= a[hi] *)
       if hi = mid then  
         (Array.unsafe_get arr lo) = key 
-      else binarySearchAux arr lo mid key 
+      else binary_search_aux arr lo mid key 
     else  (*  a[lo] =< a[mid] < key <= a[hi] *)
       if lo = mid then 
         (Array.unsafe_get arr hi) = key 
-      else binarySearchAux arr mid hi key 
+      else binary_search_aux arr mid hi key 
 
-let binarySearch (sorted : element array) (key : element)  : bool =  
+let binary_search (sorted : element array) (key : element)  : bool =  
   let len = Array.length sorted in 
   if len = 0 then false
   else 
@@ -815,6 +815,6 @@ let binarySearch (sorted : element array) (key : element)  : bool =
     let hi = Array.unsafe_get sorted (len - 1) in 
     (* let c2 = cmp key hi [@bs]in  *)
     if key > hi then false
-    else binarySearchAux sorted 0 (len - 1) key 
+    else binary_search_aux sorted 0 (len - 1) key 
 
-let is_reserved s = binarySearch sorted_keywords s     
+let is_reserved s = binary_search sorted_keywords s     

jscomp/ext/warnings.ml

@@ -26,7 +26,7 @@ type loc = {
   loc_ghost : bool;
 }
 
-type topLevelUnitHelp = FunctionCall | Other
+type top_level_unit_help = FunctionCall | Other
 
 type t =
   | Comment_start (*  1 *)
@@ -85,7 +85,7 @@ type t =
   | Bs_unimplemented_primitive of string (* 106 *)
   | Bs_integer_literal_overflow (* 107 *)
   | Bs_uninterpreted_delimiters of string (* 108 *)
-  | Bs_toplevel_expression_unit of (string * topLevelUnitHelp) option (* 109 *)
+  | Bs_toplevel_expression_unit of (string * top_level_unit_help) option (* 109 *)
 
 (* If you remove a warning, leave a hole in the numbering.  NEVER change
    the numbers of existing warnings.
@@ -499,15 +499,15 @@ let message = function
         | _ -> " ") 
 
         (match help with 
-        | Some (returnType, _) -> Printf.sprintf "`%s`" returnType 
+        | Some (return_type, _) -> Printf.sprintf "`%s`" return_type 
         | None -> "something that is not `unit`")
 
         (match help with 
-        | Some (_, helpTyp) ->
-          let helpText = (match helpTyp with 
+        | Some (_, help_typ) ->
+          let help_text = (match help_typ with 
           | FunctionCall -> "yourFunctionCall()" 
           | Other -> "yourExpression") in
-          Printf.sprintf "\n\n  Possible solutions:\n  - Assigning to a value that is then ignored: `let _ = %s`\n  - Piping into the built-in ignore function to ignore the result: `%s->ignore`" helpText helpText
+          Printf.sprintf "\n\n  Possible solutions:\n  - Assigning to a value that is then ignored: `let _ = %s`\n  - Piping into the built-in ignore function to ignore the result: `%s->ignore`" help_text help_text
         | _ -> "") 
 
 let sub_locs = function

jscomp/ext/warnings.mli

@@ -19,7 +19,7 @@ type loc = {
   loc_ghost : bool;
 }
 
-type topLevelUnitHelp = FunctionCall | Other
+type top_level_unit_help = FunctionCall | Other
 
 type t =
   | Comment_start (*  1 *)
@@ -78,7 +78,7 @@ type t =
   | Bs_unimplemented_primitive of string (* 106 *)
   | Bs_integer_literal_overflow (* 107 *)
   | Bs_uninterpreted_delimiters of string (* 108 *)
-  | Bs_toplevel_expression_unit of (string * topLevelUnitHelp) option (* 109 *)
+  | Bs_toplevel_expression_unit of (string * top_level_unit_help) option (* 109 *)
 
 val parse_options : bool -> string -> unit