fix outbound access

Author: cometkim

jscomp/syntax/src/res_scanner.ml

@@ -311,13 +311,12 @@ let scanExoticIdentifier scanner =
     (String.sub [@doesNotRaise]) scanner.src startOff (scanner.offset - startOff)
   in
   let name = Ext_ident.unwrap_exotic ident in
-  let _ =
-    if name = String.empty then
-      let endPos = position scanner in
-      scanner.err ~startPos ~endPos
-        (Diagnostics.message "A quoted identifier can't be empty string.")
-  in
-  if Ext_ident.is_uident name then Token.Lident ident
+  if name = String.empty then (
+    let endPos = position scanner in
+    scanner.err ~startPos ~endPos
+      (Diagnostics.message "A quoted identifier can't be empty string.");
+    Token.Lident ident)
+  else if Ext_ident.is_uident name then Token.Lident ident
     (* Exotic ident with uppercase letter should be encoded to avoid confusing in OCaml parsetree *)
   else Token.Lident name
 

jscomp/syntax/tests/parsing/errors/scanner/expected/exoticIdent.res.txt

@@ -92,6 +92,11 @@
 
   consecutive statements on a line must be separated by ';' or a newline
 
-type nonrec 
-type nonrec  = int
-let Fatal error: exception Invalid_argument("index out of bounds")
+type nonrec \""
+type nonrec \"" = int
+let \"" = [%rescript.exprhole ]
+let \"a
+ = b
+;;c
+;;{js| = 1
+|js}