Refactor: split tags.

Author: cristianoc

jscomp/gentype/EmitType.ml

@@ -195,16 +195,15 @@ let rec renderType ~(config : Config.t) ?(indent = None) ~typeNameIsInterface
                t |> renderType ~config ~indent ~typeNameIsInterface ~inFunType
              in
              let tagField =
-               case |> labelJSToString
-               |> field ~name:(Runtime.jsVariantTag ~polymorphic:false)
+               case |> labelJSToString |> field ~name:Runtime.jsVariantTag
              in
              match (unboxed, type_) with
              | true, type_ -> type_ |> render
              | false, type_ when polymorphic ->
                (* poly variant *)
                [
                  case |> labelJSToString
-                 |> field ~name:(Runtime.jsVariantTag ~polymorphic);
+                 |> field ~name:Runtime.jsPolymorphicVariantTag;
                  type_ |> render
                  |> field ~name:(Runtime.jsVariantValue ~polymorphic);
                ]

jscomp/gentype/Runtime.ml

@@ -24,10 +24,8 @@ let rec emitModuleAccessPath ~config moduleAccessPath =
   | Dot (p, moduleItem) ->
     p |> emitModuleAccessPath ~config |> EmitText.fieldAccess ~label:moduleItem
 
-let jsVariantTag ~polymorphic =
-  match polymorphic with
-  | true -> "NAME"
-  | false -> "TAG"
+let jsVariantTag = "TAG"
+let jsPolymorphicVariantTag = "NAME"
 
 let jsVariantPayloadTag ~n = "_" ^ string_of_int n
 

jscomp/gentype/Runtime.mli

@@ -15,6 +15,7 @@ val newModuleItem : name:string -> moduleItem
 val newRecordValue : unboxed:bool -> recordGen -> recordValue
 val recordGen : unit -> recordGen
 val recordValueToString : recordValue -> string
-val jsVariantTag : polymorphic:bool -> string
+val jsVariantTag : string
+val jsPolymorphicVariantTag : string
 val jsVariantPayloadTag : n:int -> string
 val jsVariantValue : polymorphic:bool -> string