uncomment aria-* attribute in JsxDOM

Author: mununki

CHANGELOG.md

@@ -12,6 +12,10 @@
 
 # 10.1.0-rc.1
 
+#### :boom: Breaking Change
+
+- Change the DOM element attribute `method` to `method_`
+
 ## :rocket: New Feature
 
 - Add extra variants for output filename suffixes in `bsconfig.json`: `.bs.mjs` and `.bs.cjs` are allowed https://github.com/rescript-lang/rescript-compiler/pull/5631
@@ -22,10 +26,6 @@
 - Fix location issue in make function in JSX V4 that breaks dead code elimination https://github.com/rescript-lang/syntax/pull/660
 - Fix parsing (hence pretty printing) of expressions with underscore `_` and comments.
 
-#### :nail_care: Polish
-
-- Remove type `JsxDOM.props`
-
 # 10.1.0-alpha.2
 
 #### :rocket: New Feature

jscomp/main/builtin_cmi_datasets.ml

@@ -39,26 +39,31 @@ type domProps = {
   (* accessibility *)
   (* https://www.w3.org/TR/wai-aria-1.1/ *)
   (* https://accessibilityresources.org/<aria-tag> is a great resource for these *)
-  (* [@bs.optional] [@bs.as "aria-current"] ariaCurrent: page|step|location|date|time|true|false, *)
+  ariaCurrent: [`page | `step | `location | `date | `time | `_true | `_false]
+  [@ns.optional] [@bs.as "aria-current"];
   ariaDetails: string
   [@ns.optional] [@bs.as "aria-details"];
   ariaDisabled: bool
   [@ns.optional] [@bs.as "aria-disabled"];
   ariaHidden: bool
   [@ns.optional] [@bs.as "aria-hidden"];
-  (* [@ns.optional] [@bs.as "aria-invalid"] ariaInvalid: grammar|false|spelling|true, *)
+  ariaInvalid: [`grammar | `spelling | `_true| `_false]
+  [@ns.optional] [@bs.as "aria-invalid"];
   ariaKeyshortcuts: string
   [@ns.optional] [@bs.as "aria-keyshortcuts"];
   ariaLabel: string
   [@ns.optional] [@bs.as "aria-label"];
   ariaRoledescription: string
   [@ns.optional] [@bs.as "aria-roledescription"];
   (* Widget Attributes *)
-  (* [@ns.optional] [@bs.as "aria-autocomplete"] ariaAutocomplete: inline|list|both|none, *)
-  (* [@ns.optional] [@bs.as "aria-checked"] ariaChecked: true|false|mixed, https://www.w3.org/TR/wai-aria-1.1/#valuetype_tristate *)
+  ariaAutocomplete: [`inline | `list | `both | `none]
+  [@ns.optional] [@bs.as "aria-autocomplete"];
+  ariaChecked: [`_true | `_false | `mixed] (* https://www.w3.org/TR/wai-aria-1.1/#valuetype_tristate *)
+  [@ns.optional] [@bs.as "aria-checked"];
   ariaExpanded: bool
   [@ns.optional] [@bs.as "aria-expanded"];
-  (* [@ns.optional] [@bs.as "aria-haspopup"] ariaHaspopup: false|true|menu|listbox|tree|grid|dialog, *)
+  ariaHaspopup: [`menu | `listbox | `tree | `grid | `dialog | `_true | `_false]
+  [@ns.optional] [@bs.as "aria-haspopup"];
   ariaLevel: int
   [@ns.optional] [@bs.as "aria-lavel"];
   ariaModal: bool
@@ -67,10 +72,12 @@ type domProps = {
   [@ns.optional] [@bs.as "aria-multiline"];
   ariaMultiselectable: bool
   [@ns.optional] [@bs.as "aria-multiselectable"];
-  (* [@ns.optional] [@bs.as "aria-orientation"] ariaOrientation: horizontal|vertical|undefined, *)
+   ariaOrientation: [`horizontal | `vertical | `undefined]
+  [@ns.optional] [@bs.as "aria-orientation"];
   ariaPlaceholder: string
   [@ns.optional] [@bs.as "aria-placeholder"];
-  (* [@ns.optional] [@bs.as "aria-pressed"] ariaPressed: true|false|mixed, https://www.w3.org/TR/wai-aria-1.1/#valuetype_tristate *)
+  ariaPressed: [`_true | `_false| `mixed] (* https://www.w3.org/TR/wai-aria-1.1/#valuetype_tristate *)
+  [@ns.optional] [@bs.as "aria-pressed"];
   ariaReadonly: bool
   [@ns.optional] [@bs.as "aria-readonly"];
   ariaRequired: bool
@@ -92,11 +99,13 @@ type domProps = {
   [@ns.optional] [@bs.as "aria-atomic"];
   ariaBusy: bool
   [@ns.optional] [@bs.as "aria-busy"];
-  (* [@ns.optional] [@bs.as "aria-live"] ariaLive: off|polite|assertive|rude *)
+  ariaLive: [`off | `polite | `assertive | `rude]
+  [@ns.optional] [@bs.as "aria-live"];
   ariaRelevant: string
   [@ns.optional] [@bs.as "aria-relevant"];
   (* Drag-and-Drop Attributes *)
-  (* [@ns.optional] [@bs.as "aria-dropeffect"] ariaDropeffect: copy|move|link|execute|popup|none *)
+  ariaDropeffect: [`copy | `move | `link | `execute | `popup | `none]
+  [@ns.optional] [@bs.as "aria-dropeffect"];
   ariaGrabbed: bool
   [@ns.optional] [@bs.as "aria-grabbed"];
   (* Relationship Attributes *)