diff --git a/CHANGELOG.md b/CHANGELOG.md index 223883c6e..e8b986131 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,10 @@ ## master +#### :nail_care: Polish + +- Change end position of cursor when completing `Some()` in patterns. https://github.com/rescript-lang/rescript-vscode/pull/857 + ## 1.28.0 #### :bug: Bug Fix diff --git a/analysis/src/CompletionBackEnd.ml b/analysis/src/CompletionBackEnd.ml index 690308ce2..f3846c4f7 100644 --- a/analysis/src/CompletionBackEnd.ml +++ b/analysis/src/CompletionBackEnd.ml @@ -1275,7 +1275,7 @@ let rec completeTypedValue ~full ~prefix ~completionContext ~mode Completion.createWithSnippet ~name:("Some(" ^ fieldName ^ ")") ~kind:(kindFromInnerType t) ~env - ~insertText:("Some(${1:" ^ fieldName ^ "})") + ~insertText:("Some(" ^ fieldName ^ ")$0") (); someAnyCase; noneCase; diff --git a/analysis/tests/src/expected/CompletionExpressions.res.txt b/analysis/tests/src/expected/CompletionExpressions.res.txt index e08ef128e..3c8f785fe 100644 --- a/analysis/tests/src/expected/CompletionExpressions.res.txt +++ b/analysis/tests/src/expected/CompletionExpressions.res.txt @@ -196,7 +196,7 @@ Path fnTakingRecord "tags": [], "detail": "otherRecord", "documentation": null, - "insertText": "Some(${1:nested})", + "insertText": "Some(nested)$0", "insertTextFormat": 2 }, { "label": "Some(_)", @@ -616,7 +616,7 @@ Path fnTakingRecordWithOptVariant "tags": [], "detail": "someVariant", "documentation": null, - "insertText": "Some(${1:someVariant})", + "insertText": "Some(someVariant)$0", "insertTextFormat": 2 }, { "label": "Some(_)",