From cc6002b2e7dfc1ae44c47dfbb0525a006a46c107 Mon Sep 17 00:00:00 2001 From: Zhang Date: Wed, 29 Jun 2022 18:01:09 +0800 Subject: [PATCH 1/3] do show prompt if in node_modules --- server/src/server.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/server/src/server.ts b/server/src/server.ts index 4dd00d68a..841921ca7 100644 --- a/server/src/server.ts +++ b/server/src/server.ts @@ -47,7 +47,8 @@ let projectsFiles: Map< // automatically, if there's no build currently running for the project. We // only want to prompt the user about this once, or it becomes // annoying. - hasPromptedToStartBuild: boolean; + // The type `never` means that we won't show the prompt if the project is inside node_modules + hasPromptedToStartBuild: boolean | "never"; } > = new Map(); // ^ caching AND states AND distributed system. Why does LSP has to be stupid like this @@ -188,7 +189,7 @@ let openedFile = (fileUri: string, fileContent: string) => { openFiles: new Set(), filesWithDiagnostics: new Set(), bsbWatcherByEditor: null, - hasPromptedToStartBuild: false, + hasPromptedToStartBuild: projectRootPath.includes("node_modules") ? "never" : false, }; projectsFiles.set(projectRootPath, projectRootState); compilerLogsWatcher.add( From a6f8f075bd39b066e945c5001246dfbd01561b5a Mon Sep 17 00:00:00 2001 From: Zhang Date: Wed, 29 Jun 2022 18:52:34 +0800 Subject: [PATCH 2/3] fix --- server/src/server.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/server.ts b/server/src/server.ts index 841921ca7..c5683387b 100644 --- a/server/src/server.ts +++ b/server/src/server.ts @@ -189,7 +189,7 @@ let openedFile = (fileUri: string, fileContent: string) => { openFiles: new Set(), filesWithDiagnostics: new Set(), bsbWatcherByEditor: null, - hasPromptedToStartBuild: projectRootPath.includes("node_modules") ? "never" : false, + hasPromptedToStartBuild: /(\/|\\)node_modules(\/|\\)/.test(projectRootPath) ? "never" : false, }; projectsFiles.set(projectRootPath, projectRootState); compilerLogsWatcher.add( From 974cc727811c6e087cf47ff2202fbaac096733ec Mon Sep 17 00:00:00 2001 From: Zheyu Zhang Date: Wed, 29 Jun 2022 19:57:31 +0800 Subject: [PATCH 3/3] reset ci